Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Payout fee when proven #7622

Closed
Tracked by #7820
LHerskind opened this issue Jul 26, 2024 · 3 comments
Closed
Tracked by #7820

refactor: Payout fee when proven #7622

LHerskind opened this issue Jul 26, 2024 · 3 comments
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jul 26, 2024

The fee payout should happen when proven and not when proposed as it is currently done. The reason we are currently "allowing" this is because the system does not handle reorgs so it is "same same".

@LHerskind
Copy link
Contributor Author

When #7937 is done this might be slightly simpler to do. Should be handled before #7938.

@LHerskind LHerskind self-assigned this Aug 13, 2024
@LHerskind
Copy link
Contributor Author

LHerskind commented Aug 13, 2024

It is insufficient that it happens at the time of a block being proven, it must happen when the block is included in the proven chain. This needs to happen as it is still possible for it to be re-orged even if the individual block is proven if a prior re-orgs.

Will wait addressing this slightly, as we can implicitly get around if when move along to the batch proving where we will likely move to sequential proving and not being able to run ahead in the same way, which removes this issue.

TL;DR: for sequential proving we can payout at verification, as it is the same as inclusion in proven chain.

I think that we might be unable to really support sequential verification though, as it could force a "domino" effect.

@LHerskind
Copy link
Contributor Author

This was fixed as part of #8262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant