Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moving fee payout + make proof submission sequential #8262

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

LHerskind
Copy link
Contributor

@LHerskind LHerskind commented Aug 29, 2024

Fixing #7622 and #8259

Copy link
Contributor Author

LHerskind commented Aug 29, 2024

@AztecBot
Copy link
Collaborator

AztecBot commented Aug 29, 2024

Benchmark results

Metrics with a significant change:

  • protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,364 (+106%)
  • avm_simulation_time_ms (FeeJuice:mint_public): 41.5 (-81%)
  • avm_simulation_time_ms (Token:transfer_public): 26.0 (-31%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,747 1,579 (+1%) 709 747 (-2%) 774
proof_construction_time_sha256_30_ms 11,466 3,088 1,376 1,428 1,461
proof_construction_time_sha256_100_ms 44,075 11,814 5,421 5,407 (-1%) 5,637 (-2%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 59.0 (+2%) 88.0
proof_construction_time_poseidon_hash_30_ms 1,527 421 206 (+1%) 229 (+3%) 278 (+4%)
proof_construction_time_poseidon_hash_100_ms 5,641 1,511 674 727 (+2%) 745 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 4,356 7,876 14,884
l1_rollup_calldata_gas 50,196 92,976 178,144
l1_rollup_execution_gas 845,574 1,579,250 3,364,474
l2_block_processing_time_in_ms 250 (-6%) 452 830 (-9%)
l2_block_building_time_in_ms 11,651 (+2%) 22,386 44,862
l2_block_rollup_simulation_time_in_ms 11,650 (+2%) 22,385 44,862
l2_block_public_tx_process_time_in_ms 9,974 (+2%) 20,687 43,131

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 3,053 (+2%) 3,902
node_database_size_in_bytes 12,623,952 16,728,144
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms
private-kernel-init 95.6 (+5%) 395 21,735 44,860 N/A
private-kernel-inner 173 (-2%) 699 72,544 45,007 N/A
private-kernel-reset-tiny 307 (-2%) 710 (-2%) 65,593 44,846 N/A
private-kernel-tail 166 (-1%) 134 (-3%) 50,644 52,257 N/A
base-parity 5.61 N/A 160 96.0 N/A
root-parity 35.5 N/A 73,948 96.0 N/A
base-rollup 2,976 (-1%) N/A 189,136 664 N/A
block-root-rollup 41.6 N/A 58,205 2,448 N/A
public-kernel-setup 85.5 N/A 105,085 71,222 N/A
public-kernel-app-logic 98.1 N/A 104,911 71,222 N/A
public-kernel-tail 862 N/A 390,582 16,414 N/A
private-kernel-reset-small 323 (+4%) N/A 66,341 45,629 N/A
private-kernel-tail-to-public ⚠️ 1,364 (+106%) 611 455,400 1,825 N/A
public-kernel-teardown 84.6 N/A 105,349 71,222 N/A
merge-rollup 20.2 N/A 38,174 664 N/A
undefined N/A N/A N/A N/A 79,500 (+2%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms
ContractClassRegisterer:register 1,344 11,731 341 (-1%)
ContractInstanceDeployer:deploy 1,408 11,731 18.3
MultiCallEntrypoint:entrypoint 1,920 11,731 403 (-1%)
FeeJuice:deploy 1,376 11,731 387 (-2%)
SchnorrAccount:constructor 1,312 11,731 73.7
SchnorrAccount:entrypoint 2,304 11,731 395 (+1%)
Token:privately_mint_private_note 1,280 11,731 103
FPC:fee_entrypoint_public 1,344 11,731 26.0 (+1%)
Token:transfer 1,312 11,731 226 (-1%)
Benchmarking:create_note 1,344 11,731 85.7 (+1%)
SchnorrAccount:verify_private_authwit 1,280 11,731 27.8 (-16%)
Token:unshield 1,376 11,731 524 (-1%)
FPC:fee_entrypoint_private 1,376 11,731 759 (+8%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
FeeJuice:_increase_public_balance 57.7 (-5%) 8,174
FeeJuice:set_portal 10.8 (-17%) 4,055
Token:constructor 81.8 (-2%) 29,082
FPC:constructor 55.3 (+2%) 18,940
FeeJuice:mint_public ⚠️ 41.5 (-81%) 6,522
Token:mint_public 327 (+3%) 12,704
Token:assert_minter_and_mint 43.7 (+2%) 8,467
AuthRegistry:set_authorized 39.9 (-18%) 4,194
FPC:prepare_fee 244 6,747
Token:transfer_public ⚠️ 26.0 (-31%) 39,863
FPC:pay_refund 51.7 (-6%) 9,398
Benchmarking:increment_balance 1,222 (-1%) 7,263
Token:_increase_public_balance 43.4 (-1%) 8,686
FPC:pay_refund_with_shielded_rebate 63.8 9,881

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.158 (-3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.22 (-2%) 3.96 (-3%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.116 (-3%) 0.112 (-3%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 11.4 17.9 (-8%) 31.1 (-15%) 60.5 (+1%) 115 (-13%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.109 0.104 (-9%) 0.101 (-15%) 0.104 (+1%) 0.103 (-14%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.7 (-1%) 25.7 (-8%) 44.1 (-9%) 83.9 (-1%) 162 (-16%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.112 (-1%) 0.103 (-10%) 0.107 (-10%) 0.104 (-1%) 0.102 (-18%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.7 (-3%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 132 (-1%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.107 (-3%) N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 64,779 668,997

Transaction size based on fee payment method

| Metric | |
| - | |

@LHerskind LHerskind marked this pull request as ready for review August 29, 2024 09:28
Base automatically changed from lh/36-s-slots to master August 29, 2024 17:42
@LHerskind LHerskind force-pushed the lh/7622-fee-when-proven branch from 6e919b8 to 7df45c3 Compare August 29, 2024 17:43
@LHerskind LHerskind merged commit 273b452 into master Aug 29, 2024
104 checks passed
@LHerskind LHerskind deleted the lh/7622-fee-when-proven branch August 29, 2024 20:51
TomAFrench added a commit that referenced this pull request Aug 30, 2024
* master: (28 commits)
  chore: bump noir-bignum to 0.3.2 (#8276)
  feat: Populate epoch 0 from initial validator set (#8286)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  chore(master): Release 0.51.1 (#8218)
  feat(avm): integrate new range and cmp gadgets (#8165)
  chore: rename process to propose for clarity (#8265)
  chore: Bump provernet agents to 8 and speed up bot (#8280)
  feat(avm): avm recursive verifier cpp (#8162)
  feat: moving fee payout + make proof submission sequential (#8262)
  feat: Block cheat codes in anvil (#8277)
  feat: wallet tx management (#8246)
  refactor(avm): replace range and cmp with gadgets (#8164)
  fix(docs): Update entrypoint details on accounts page (#8184)
  feat: l1-publisher cleanup (#8148)
  feat(avm): range check gadget (#7967)
  fix(ci): spot-runner-action was not built (#8274)
  fix: ts codegen (#8267)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants