Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename process to propose for clarity #8265

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

LHerskind
Copy link
Contributor

@LHerskind LHerskind commented Aug 29, 2024

Changes the naming of the process function on the rollup to become propose since it is a proposal for a block.

Copy link
Contributor Author

LHerskind commented Aug 29, 2024

@LHerskind LHerskind marked this pull request as ready for review August 29, 2024 11:36
@AztecBot
Copy link
Collaborator

AztecBot commented Aug 29, 2024

Benchmark results

Metrics with a significant change:

  • protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 662 (-21%)
  • avm_simulation_time_ms (Token:mint_public): 50.7 (-84%)
  • avm_simulation_time_ms (Token:assert_minter_and_mint): 317 (+625%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,799 (+1%) 1,571 (-1%) 722 (+1%) 765 (+3%) 788 (+1%)
proof_construction_time_sha256_30_ms 11,659 3,160 (+1%) 1,415 (+1%) 1,451 (-1%) 1,484
proof_construction_time_sha256_100_ms 45,068 (+2%) 12,181 5,870 (+2%) 5,870 5,997
proof_construction_time_poseidon_hash_ms 79.0 (+1%) 34.0 34.0 58.0 (-2%) 90.0 (+3%)
proof_construction_time_poseidon_hash_30_ms 1,534 423 202 (-1%) 227 (-1%) 270 (+1%)
proof_construction_time_poseidon_hash_100_ms 5,693 (+1%) 1,526 (+1%) 683 (+1%) 738 (+2%) 747 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 4,356 7,876 14,884
l1_rollup_calldata_gas 50,268 92,894 177,928
l1_rollup_execution_gas 845,602 1,579,124 3,364,214
l2_block_processing_time_in_ms 256 456 (-2%) 801 (-2%)
l2_block_building_time_in_ms 11,452 (-1%) 22,523 44,326 (-1%)
l2_block_rollup_simulation_time_in_ms 11,452 (-1%) 22,523 44,325 (-1%)
l2_block_public_tx_process_time_in_ms 9,779 20,804 42,600 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 2,983 (-2%) 4,152 (+2%)
node_database_size_in_bytes 12,623,952 16,699,472
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms
private-kernel-init 94.6 (+3%) 398 21,735 44,860 N/A
private-kernel-inner 178 (-11%) 709 72,544 45,007 N/A
private-kernel-reset-tiny 314 (+1%) 715 (-2%) 65,593 44,846 N/A
private-kernel-tail 169 (+1%) 136 50,644 52,257 N/A
base-parity 5.60 (-1%) N/A 160 96.0 N/A
root-parity 35.4 (-1%) N/A 73,948 96.0 N/A
base-rollup 3,004 N/A 189,136 664 N/A
block-root-rollup 41.5 N/A 58,205 2,448 N/A
public-kernel-setup 85.8 N/A 105,085 71,222 N/A
public-kernel-app-logic 98.1 (-1%) N/A 104,911 71,222 N/A
public-kernel-tail 863 N/A 390,582 16,414 N/A
private-kernel-reset-small 313 N/A 66,341 45,629 N/A
private-kernel-tail-to-public ⚠️ 662 (-21%) 613 (-6%) 455,400 1,825 N/A
public-kernel-teardown 84.4 (-1%) N/A 105,349 71,222 N/A
merge-rollup 20.5 (+2%) N/A 38,174 664 N/A
undefined N/A N/A N/A N/A 81,431 (+3%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms
ContractClassRegisterer:register 1,344 11,731 342 (-1%)
ContractInstanceDeployer:deploy 1,408 11,731 18.2 (-1%)
MultiCallEntrypoint:entrypoint 1,920 11,731 403 (-1%)
FeeJuice:deploy 1,376 11,731 392
SchnorrAccount:constructor 1,312 11,731 73.4 (-1%)
SchnorrAccount:entrypoint 2,336 11,731 412 (+3%)
Token:privately_mint_private_note 1,280 11,731 100 (-5%)
FPC:fee_entrypoint_public 1,344 11,731 25.7 (-12%)
Token:transfer 1,312 11,731 225 (-3%)
Benchmarking:create_note 1,344 11,731 91.4 (+5%)
SchnorrAccount:verify_private_authwit 1,280 11,731 28.3 (+1%)
Token:unshield 1,376 11,731 550 (+5%)
FPC:fee_entrypoint_private 1,376 11,731 737 (+4%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
FeeJuice:_increase_public_balance 58.0 (+1%) 8,174
FeeJuice:set_portal 13.7 (+14%) 4,055
Token:constructor 82.8 (-3%) 29,082
FPC:constructor 62.5 (+13%) 18,940
FeeJuice:mint_public 40.7 (-6%) 6,522
Token:mint_public ⚠️ 50.7 (-84%) 12,704
Token:assert_minter_and_mint ⚠️ 317 (+625%) 8,467
AuthRegistry:set_authorized 49.6 4,194
FPC:prepare_fee 252 (-3%) 6,747
Token:transfer_public 32.7 (-11%) 39,863
FPC:pay_refund 59.7 (-10%) 9,398
Benchmarking:increment_balance 1,232 7,263
Token:_increase_public_balance 41.7 8,686
FPC:pay_refund_with_shielded_rebate 65.4 (+4%) 9,881

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.160 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.16 (-3%) 3.94 (-1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.112 (-4%) 0.111 (-1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 11.3 17.7 30.5 (+1%) 60.4 (-2%) 113 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.108 0.103 0.0992 0.104 (-3%) 0.101 (+1%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.8 25.6 (-1%) 43.5 (+2%) 84.4 (-1%) 161 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.113 0.103 (-1%) 0.105 (+2%) 0.104 (-1%) 0.101
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.6 (-2%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 132 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.106 (-2%) N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 64,779 668,997

Transaction size based on fee payment method

| Metric | |
| - | |

Base automatically changed from lh/7622-fee-when-proven to master August 29, 2024 20:51
@LHerskind LHerskind enabled auto-merge (squash) August 29, 2024 21:11
@LHerskind LHerskind merged commit bf7a99d into master Aug 29, 2024
100 checks passed
@LHerskind LHerskind deleted the lh/process-becomes-propose branch August 29, 2024 21:33
TomAFrench added a commit that referenced this pull request Aug 30, 2024
* master: (28 commits)
  chore: bump noir-bignum to 0.3.2 (#8276)
  feat: Populate epoch 0 from initial validator set (#8286)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  chore(master): Release 0.51.1 (#8218)
  feat(avm): integrate new range and cmp gadgets (#8165)
  chore: rename process to propose for clarity (#8265)
  chore: Bump provernet agents to 8 and speed up bot (#8280)
  feat(avm): avm recursive verifier cpp (#8162)
  feat: moving fee payout + make proof submission sequential (#8262)
  feat: Block cheat codes in anvil (#8277)
  feat: wallet tx management (#8246)
  refactor(avm): replace range and cmp with gadgets (#8164)
  fix(docs): Update entrypoint details on accounts page (#8184)
  feat: l1-publisher cleanup (#8148)
  feat(avm): range check gadget (#7967)
  fix(ci): spot-runner-action was not built (#8274)
  fix: ts codegen (#8267)
  ...
codygunton pushed a commit that referenced this pull request Aug 30, 2024
Changes the naming of the `process` function on the rollup to become `propose` since it is a proposal for a block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants