fix: Fixes for the nightly test run against Sepolia #8229

PhilWindle · 2024-08-27T20:11:34Z

This PR makes some fixes to the nightly Sepolia test run

AztecBot · 2024-08-27T20:27:36Z

Benchmark results

Metrics with a significant change:

proof_construction_time_sha256_ms (16): 925 (+30%)
proof_construction_time_sha256_30_ms (16): 1,378 (-20%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 40.5 (+30%)
avm_simulation_time_ms (Token:transfer_public): 35.3 (+44%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,750 (-1%)	1,582 (+1%)	⚠️ 925 (+30%)	849 (+10%)	823 (+6%)
proof_construction_time_sha256_30_ms	11,463 (-1%)	3,080 (-2%)	⚠️ 1,378 (-20%)	1,429 (-12%)	1,463 (-7%)
proof_construction_time_sha256_100_ms	43,972	11,857	5,421 (-2%)	5,529 (+1%)	5,630 (-5%)
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0	44.0 (+29%)	65.0 (+12%)	90.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,529	420	281 (+1%)	262 (-1%)	286
proof_construction_time_poseidon_hash_100_ms	5,638	1,509 (-1%)	891	810 (-1%)	789

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,256	93,010	178,216
l1_rollup_execution_gas	842,916	1,576,566	3,361,828
l2_block_processing_time_in_ms	246 (-3%)	454 (+1%)	798 (-5%)
l2_block_building_time_in_ms	11,356	22,203 (-4%)	44,297 (-1%)
l2_block_rollup_simulation_time_in_ms	11,356	22,203 (-4%)	44,297 (-1%)
l2_block_public_tx_process_time_in_ms	9,645	20,393 (-5%)	42,468 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,034 (+2%)	3,953 (+2%)
node_database_size_in_bytes	12,623,952	16,748,624
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	97.1 (-3%)	378 (-5%)	21,735	44,860	N/A
private-kernel-inner	174 (-3%)	673 (-1%)	72,544	45,007	N/A
private-kernel-reset-tiny	309 (-10%)	700	65,593	44,846	N/A
private-kernel-tail	166 (-8%)	131	50,644	52,257	N/A
base-parity	5.56	N/A	160	96.0	N/A
root-parity	35.5	N/A	73,948	96.0	N/A
base-rollup	3,443 (-2%)	N/A	189,136	664	N/A
block-root-rollup	41.3 (+1%)	N/A	58,205	2,448	N/A
public-kernel-setup	84.4 (-1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	96.8 (-4%)	N/A	104,911	71,222	N/A
public-kernel-tail	854 (-3%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	314 (+2%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	1,383 (-1%)	588	455,400	1,825	N/A
public-kernel-teardown	83.9	N/A	105,349	71,222	N/A
merge-rollup	20.3 (-2%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	84,023

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (+1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	403
FeeJuice:deploy	1,376	11,731	390 (+1%)
SchnorrAccount:constructor	1,312	11,731	73.5 (+1%)
SchnorrAccount:entrypoint	2,304	11,731	394 (+1%)
Token:privately_mint_private_note	1,280	11,731	99.7 (+3%)
FPC:fee_entrypoint_public	1,344	11,731	24.5 (-11%)
Token:transfer	1,312	11,731	219 (-2%)
Benchmarking:create_note	1,344	11,731	85.7 (-1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.6
Token:unshield	1,376	11,731	521
FPC:fee_entrypoint_private	1,376	11,731	689

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	56.7 (-2%)	7,101
FeeJuice:set_portal	12.0 (+6%)	2,128
Token:constructor	88.6 (-6%)	25,285
FPC:constructor	53.9	17,853
FeeJuice:mint_public	38.7	5,415
Token:mint_public	70.2 (+2%)	10,101
Token:assert_minter_and_mint	⚠️ 40.5 (+30%)	6,844
AuthRegistry:set_authorized	46.3 (+24%)	3,969
FPC:prepare_fee	229	6,747
Token:transfer_public	⚠️ 35.3 (+44%)	38,126
FPC:pay_refund	52.5 (-3%)	9,398
Benchmarking:increment_balance	1,195	6,179
Token:_increase_public_balance	41.9 (+6%)	7,705
FPC:pay_refund_with_shielded_rebate	66.3 (+5%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.165 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17 (-2%)	3.84	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112	0.108	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.3 (+1%)	18.1 (+3%)	31.8 (+3%)	59.9 (+2%)	112 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (+1%)	0.105 (+3%)	0.103 (+2%)	0.103 (+2%)	0.100 (-2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.1 (-2%)	25.7	43.4 (-1%)	83.5 (+2%)	160 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.107 (-2%)	0.104 (-1%)	0.105 (-1%)	0.103 (+2%)	0.101 (-2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

spalladino · 2024-08-27T20:30:31Z

yarn-project/end-to-end/Earthfile

+E2E_TEST_PUBLIC_TESTNET:
+  FUNCTION


Why extract this to a function if it's only called from e2e-public-testnet? It'd save us from defining all the annoying ARGs below.

I just followed the existing pattern really. I did wonder if we might add a couple more tests at which point it maybe makes sense.

The way you have to pass those env vars through like that is really annoying.

spalladino · 2024-08-27T20:30:44Z

.github/workflows/sepolia-test.yml

+          --ETHEREUM_HOST="https://sepolia.infura.io/v3/${{ secrets.SEPOLIA_API_KEY }}" \
+          --L1_CHAIN_ID="11155111"
+
+  # e2e:


Reminder to delete commented-out code

spalladino · 2024-08-27T20:31:04Z

.github/workflows/sepolia-test.yml

+        #id: e2e_list
+        # run: echo "list=$(earthly ls ./yarn-project/end-to-end | grep 'public-testnet' |  sed 's/+//' | jq -R . | jq -cs .)" >> $GITHUB_OUTPUT


Suggested change

#id: e2e_list

# run: echo "list=$(earthly ls ./yarn-project/end-to-end | grep 'public-testnet' | sed 's/+//' | jq -R . | jq -cs .)" >> $GITHUB_OUTPUT

spalladino · 2024-08-27T20:31:10Z

.github/workflows/sepolia-test.yml

+    # outputs:
+    #   e2e_list: ${{ steps.e2e_list.outputs.list }}


Suggested change

# outputs:

# e2e_list: ${{ steps.e2e_list.outputs.list }}

* master: (207 commits) refactor: disallow prune in devnet + add onlyOwners (#8134) refactor: add partial note support for value note (#8141) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg Update external-ci-approved.yml fix: Fixes for the nightly test run against Sepolia (#8229) fix: Docker containers healthchecks (#8228) chore: Create external-ci-approved.yml (#8235) refactor: rework balances map (#8127) feat: Add CLI command for gathering proving metrics (#8221) chore: Less noisy AVM failures in proving (#8227) chore: open an issue if publishing bb fails (#8223) feat: spartan token transfer (#8163) fix: Attempt to fix nightly test (#8222) feat: initial validator set (#8133) chore: Configure interval mining for anvil (#8211) fix: remove devnet ARM builds for now (#8202) fix: Export brillig names in contract functions (#8212) ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.51.1</summary> ## [0.51.1](aztec-package-v0.51.0...aztec-package-v0.51.1) (2024-08-29) ### Features * Add status check to prover agent ([#8248](#8248)) ([7b3006a](7b3006a)) * Faster L1 deployment ([#8234](#8234)) ([51d6699](51d6699)) * Spartan token transfer ([#8163](#8163)) ([38f0157](38f0157)) </details> <details><summary>barretenberg.js: 0.51.1</summary> ## [0.51.1](barretenberg.js-v0.51.0...barretenberg.js-v0.51.1) (2024-08-29) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.51.1</summary> ## [0.51.1](aztec-packages-v0.51.0...aztec-packages-v0.51.1) (2024-08-29) ### Features * Add CLI command for gathering proving metrics ([#8221](#8221)) ([5929a42](5929a42)) * Add status check to prover agent ([#8248](#8248)) ([7b3006a](7b3006a)) * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](#8264)) ([bdd9b06](bdd9b06)) * **avm:** Range check gadget ([#7967](#7967)) ([0dd954e](0dd954e)) * **docs:** Add partial notes doc ([#8192](#8192)) ([4299bbd](4299bbd)) * Faster L1 deployment ([#8234](#8234)) ([51d6699](51d6699)) * Initial validator set ([#8133](#8133)) ([6d31ad2](6d31ad2)) * L1-publisher cleanup ([#8148](#8148)) ([6ae2535](6ae2535)) * Proof surgery class ([#8236](#8236)) ([10d7edd](10d7edd)) * Request specific transactions through the p2p layer ([#8185](#8185)) ([54e1cc7](54e1cc7)) * Slot duration flexibility ([#8122](#8122)) ([708e4e5](708e4e5)) * Spartan token transfer ([#8163](#8163)) ([38f0157](38f0157)) ### Bug Fixes * Attempt to fix nightly test ([#8222](#8222)) ([477eec5](477eec5)) * **avm-simulator:** Await avm bytecode check ([#8268](#8268)) ([4410eb3](4410eb3)) * **bb-prover:** Create structure for AVM vk ([#8233](#8233)) ([55b6ba2](55b6ba2)) * **bb:** Mac build ([#8255](#8255)) ([ac54f5c](ac54f5c)) * **ci:** Spot-runner-action was not built ([#8274](#8274)) ([c1509c1](c1509c1)) * **ci:** Try fix brotli edge-case ([#8256](#8256)) ([e03ea0b](e03ea0b)) * Docker containers healthchecks ([#8228](#8228)) ([19edbbb](19edbbb)) * **docs:** Update entrypoint details on accounts page ([#8184](#8184)) ([8453ec7](8453ec7)) * Export brillig names in contract functions ([#8212](#8212)) ([4745741](4745741)) * Fixes for the nightly test run against Sepolia ([#8229](#8229)) ([cfc65c6](cfc65c6)) * Handle constant output for sha256 ([#8251](#8251)) ([0653ba5](0653ba5)) * Log public vm errors as warn in prover-agent ([#8247](#8247)) ([9f4ea9f](9f4ea9f)) * Remove devnet ARM builds for now ([#8202](#8202)) ([81ef715](81ef715)) * Remove fundFpc step from bootstrap ([#8245](#8245)) ([a742531](a742531)) * Ts codegen ([#8267](#8267)) ([cb58800](cb58800)) ### Miscellaneous * Add check to just release images to devnet-deploys ([#8242](#8242)) ([aa6791d](aa6791d)) * Add partial note support for value note ([#8141](#8141)) ([daa57cc](daa57cc)) * Always run `build-check` step in `publish-bb.yml` ([#8240](#8240)) ([5e9749f](5e9749f)) * **avm:** Replace range and cmp with gadgets ([#8164](#8164)) ([cc12558](cc12558)) * Basic network matrix ([#8257](#8257)) ([2a76b1a](2a76b1a)), closes [#8001](#8001) * **bb:** Use std::span in pippenger for scalars ([#8269](#8269)) ([2323cd5](2323cd5)) * Configure interval mining for anvil ([#8211](#8211)) ([eba57b4](eba57b4)) * Create external-ci-approved.yml ([#8235](#8235)) ([24b059b](24b059b)) * Disallow prune in devnet + add onlyOwners ([#8134](#8134)) ([c736f96](c736f96)) * Fix various warnings in noir code ([#8258](#8258)) ([1c6b478](1c6b478)) * Less noisy AVM failures in proving ([#8227](#8227)) ([03bcd62](03bcd62)) * Open an issue if publishing bb fails ([#8223](#8223)) ([2d7a775](2d7a775)) * Reinstate l1-contracts package ([#8250](#8250)) ([263a912](263a912)) * Remove unused generic parameters ([#8249](#8249)) ([00ed045](00ed045)) * Replace relative paths to noir-protocol-circuits ([1783c80](1783c80)) * Replace relative paths to noir-protocol-circuits ([ffe1f35](ffe1f35)) * Report prover metrics ([#8155](#8155)) ([dc7bcdf](dc7bcdf)), closes [#7675](#7675) * Rework balances map ([#8127](#8127)) ([1cac3dd](1cac3dd)), closes [#8104](#8104) * Run CI after merges to provernet ([#8244](#8244)) ([97e5e25](97e5e25)) ### Documentation * Minor fixes ([#8273](#8273)) ([2b8af9e](2b8af9e)) </details> <details><summary>barretenberg: 0.51.1</summary> ## [0.51.1](barretenberg-v0.51.0...barretenberg-v0.51.1) (2024-08-29) ### Features * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](#8264)) ([bdd9b06](bdd9b06)) * **avm:** Range check gadget ([#7967](#7967)) ([0dd954e](0dd954e)) * Proof surgery class ([#8236](#8236)) ([10d7edd](10d7edd)) ### Bug Fixes * **bb-prover:** Create structure for AVM vk ([#8233](#8233)) ([55b6ba2](55b6ba2)) * **bb:** Mac build ([#8255](#8255)) ([ac54f5c](ac54f5c)) * Handle constant output for sha256 ([#8251](#8251)) ([0653ba5](0653ba5)) ### Miscellaneous * **avm:** Replace range and cmp with gadgets ([#8164](#8164)) ([cc12558](cc12558)) * **bb:** Use std::span in pippenger for scalars ([#8269](#8269)) ([2323cd5](2323cd5)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

PhilWindle added 11 commits August 27, 2024 17:02

Fix

50ccf6e

Another try

542c51b

And again

ae2b75b

And again

f90afec

Fix attempt

e185700

Try against Sepolia

5ff1bb4

Yaml fix

ea696d6

Fix

4f4de35

Another run

e236e90

Try again

df36f0e

Another attempt

1c29a6b

spalladino approved these changes Aug 27, 2024

View reviewed changes

Remove comments

9903f2f

PhilWindle enabled auto-merge (squash) August 27, 2024 20:50

Fix e2e test

b9f0c5b

PhilWindle merged commit cfc65c6 into master Aug 27, 2024
97 of 101 checks passed

PhilWindle deleted the pw/fix-attempt-2 branch August 27, 2024 21:57

AztecBot mentioned this pull request Aug 27, 2024

chore(master): Release 0.51.1 #8218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fixes for the nightly test run against Sepolia #8229

fix: Fixes for the nightly test run against Sepolia #8229

PhilWindle commented Aug 27, 2024

AztecBot commented Aug 27, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

spalladino Aug 27, 2024

PhilWindle Aug 27, 2024

spalladino Aug 27, 2024

PhilWindle Aug 27, 2024

spalladino Aug 27, 2024

spalladino Aug 27, 2024

		#id: e2e_list
		# run: echo "list=$(earthly ls ./yarn-project/end-to-end \| grep 'public-testnet' \| sed 's/+//' \| jq -R . \| jq -cs .)" >> $GITHUB_OUTPUT

		E2E_TEST_PUBLIC_TESTNET:
		FUNCTION

fix: Fixes for the nightly test run against Sepolia #8229

fix: Fixes for the nightly test run against Sepolia #8229

Conversation

PhilWindle commented Aug 27, 2024

AztecBot commented Aug 27, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

spalladino Aug 27, 2024

Choose a reason for hiding this comment

PhilWindle Aug 27, 2024

Choose a reason for hiding this comment

spalladino Aug 27, 2024

Choose a reason for hiding this comment

PhilWindle Aug 27, 2024

Choose a reason for hiding this comment

spalladino Aug 27, 2024

Choose a reason for hiding this comment

spalladino Aug 27, 2024

Choose a reason for hiding this comment

AztecBot commented Aug 27, 2024 •

edited

Loading