Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove multiple pedersen hash methods #2955

Closed
wants to merge 1 commit into from

Conversation

kevaundray
Copy link
Contributor

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@kevaundray kevaundray changed the title chore: remove multiple hash methods chore: remove multiple pedersen hash methods Oct 21, 2023
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_history_trial_decrypting_time_in_ms (10): 242 (+66%)
  • note_trial_decrypting_time_in_ms (8): 28.0 (-30%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 69c1d663 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,792 868,316 3,448,004
l1_rollup_execution_gas 841,879 3,595,424 22,203,373
l2_block_processing_time_in_ms 1,017 (-2%) 3,862 (-2%) 15,198 (-2%)
note_successful_decrypting_time_in_ms 325 (-4%) 1,007 (-3%) 3,888 (-4%)
note_trial_decrypting_time_in_ms ⚠️ 28.0 (-30%) 109 (+1%) 137 (-1%)
l2_block_building_time_in_ms 8,907 (-1%) 35,919 156,673 (-1%)
l2_block_rollup_simulation_time_in_ms 6,598 (-1%) 26,666 (+1%) 104,928
l2_block_public_tx_process_time_in_ms 2,270 (-3%) 9,130 (-3%) 51,286 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 12,206 (+8%) 23,744 (+8%)
note_history_successful_decrypting_time_in_ms 2,546 (+8%) 4,990 (+4%)
note_history_trial_decrypting_time_in_ms 126 (+3%) ⚠️ 242 (+66%)
node_database_size_in_bytes 1,629,370 1,095,838
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 47.3 61,697 18,841
private-kernel-ordering 23.7 (+2%) 24,233 8,089
base-rollup 855 639,797 811
root-rollup 39.7 (+5%) 4,072 1,097
private-kernel-inner 44.0 (+3%) 81,504 18,841
public-kernel-private-input 48.3 (+1%) 41,455 18,841
public-kernel-non-first-iteration 31.5 (+2%) 41,497 18,841
merge-rollup 0.928 (+12%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,508

@kevaundray
Copy link
Contributor Author

This is not blocked by #2592 and should go in after it has been merged

@kevaundray
Copy link
Contributor Author

This has been merged in piecewise in #3029

@kevaundray kevaundray closed this Oct 26, 2023
@kevaundray kevaundray deleted the kw/pedersen-ref-smaller-api branch October 26, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants