chore: All pedersen compress_native methods now return a grumpkin::fq #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
changed the base branch from
master
to
kw/pedersen-ref-smaller-api
kevaundray
commented
Oct 21, 2023
| @@ -424,8 +424,7 @@ template <typename Curve> struct verification_key { | |||
|
|
|||
| barretenberg::fr compressed_key; | |||
| if constexpr (HasPlookup<Builder>) { | |||
| compressed_key = from_buffer<barretenberg::fr>( | |||
| crypto::pedersen_commitment::lookup::compress_native(preimage_data, hash_index)); | |||
| compressed_key = crypto::pedersen_commitment::lookup::compress_native(preimage_data, hash_index); | |||
There was a problem hiding this comment.
Not related to this PR, I think this deserves a small comment -- seeing native computation being done in the stdlib always raises suspicions for me. This same computation is also done in the non-stdlib variant of this method
|
This is not blocked by #2592 and should go in after it has been merged |
|
Closing as this has now been included in the mega PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2955
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.