feat: Goblin Translator flavor and permutation correctness (Goblin Translator part 7) #2961

Rumata888 · 2023-10-22T17:38:31Z

This PR:

Introduces the Goblin Translator flavor with definitions of all polynomials, etc
Adds a relation correctness test for Goblin Translator permutation
Adds functions for constructing ordered and concatenated constraint polynomials used in the permutation

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

AztecBot · 2023-10-22T18:03:55Z

Benchmark results

Metrics with a significant change:

l2_block_building_time_in_ms (32): 58,359 (-16%)
l2_block_rollup_simulation_time_in_ms (32): 52,852 (-16%)
note_successful_decrypting_time_in_ms (8): 349 (-17%)
note_successful_decrypting_time_in_ms (128): 4,045 (-21%)
note_trial_decrypting_time_in_ms (8): 50.0 (+138%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit faffc39a and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,936	868,160	3,449,744
l1_rollup_execution_gas	842,023	3,595,268	22,205,113
l2_block_processing_time_in_ms	2,348 (-12%)	8,749 (-15%)	34,484 (-14%)
note_successful_decrypting_time_in_ms	⚠️ 349 (-17%)	1,301 (-4%)	⚠️ 4,045 (-21%)
note_trial_decrypting_time_in_ms	⚠️ 50.0 (+138%)	107 (-3%)	137 (-5%)
l2_block_building_time_in_ms	14,741 (-15%)	⚠️ 58,359 (-16%)	233,686 (-15%)
l2_block_rollup_simulation_time_in_ms	13,354 (-15%)	⚠️ 52,852 (-16%)	211,573 (-15%)
l2_block_public_tx_process_time_in_ms	1,346 (-14%)	5,382 (-14%)	21,650 (-14%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	24,648 (-2%)	48,120 (-2%)
note_history_successful_decrypting_time_in_ms	2,489 (-4%)	4,968 (-2%)
note_history_trial_decrypting_time_in_ms	123 (-1%)	147
node_database_size_in_bytes	1,630,637	1,100,452
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	82.5 (-8%)	61,697	18,841
private-kernel-ordering	50.8 (-7%)	24,233	8,089
base-rollup	2,090 (-8%)	656,309	811
root-rollup	89.5 (-6%)	4,072	1,097
private-kernel-inner	59.5 (-8%)	81,504	18,841
public-kernel-private-input	47.0 (-7%)	41,455	18,841
public-kernel-non-first-iteration	29.2 (-7%)	41,497	18,841
merge-rollup	0.891 (-11%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	29,393

zac-williamson · 2023-10-23T15:37:59Z

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp

+        X_LO_Y_HI,
+        X_HI_Z_1,
+        Y_LO_Z_2,
+        /*P.xₗₒ split into 2 68 bit limbs*/


Is the 68 bits a fixed parameter or can it vary? Instead of using a magic number, could you replaced with a name constant?

A lot has to change in the code to switch from 68-bit limbs. I'll replace with the name

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp

zac-williamson · 2023-10-23T15:44:48Z

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp

+      public:
+        DataType& lagrange_first = std::get<0>(this->_data);
+        DataType& lagrange_last = std::get<1>(this->_data);
+        DataType& lagrange_odd = std::get<2>(this->_data);


pedantic comment: lagrange_odd === lagrange_even_shift. Might improve performance if we used the shifted even polynomial (maybe add a a comment highlighting this as a potential future improvement?)

Added an issue

barretenberg/cpp/src/barretenberg/honk/proof_system/permutation_library.hpp

zac-williamson · 2023-10-24T11:05:11Z

barretenberg/cpp/src/barretenberg/honk/proof_system/permutation_library.hpp

+template <typename Flavor, typename StorageHandle> void compute_concatenated_polynomials(StorageHandle* proving_key)
+{
+    // Concatenation groups are vectors of polynomials that are concatenated together
+    auto concatenation_groups = proving_key->get_concatenation_groups();


can we replace auto with a proper type? It would make it easier to read what is happening here. If the type is complex, a using declaration would be better than auto as the reader would know where to look to read the type definition.

zac-williamson · 2023-10-24T11:05:24Z

barretenberg/cpp/src/barretenberg/honk/proof_system/permutation_library.hpp

+    auto concatenation_groups = proving_key->get_concatenation_groups();
+
+    // Resulting concatenated polynomials
+    auto targets = proving_key->get_concatenated_constraints();


same thing about `auto type

barretenberg/cpp/src/barretenberg/honk/proof_system/permutation_library.hpp

zac-williamson

I left several comments with requested changes, but they are all minor. Overall great work, thank you for breaking this down into small PRs

…anslator part 7) (#2961) This PR: 1. Introduces the Goblin Translator flavor with definitions of all polynomials, etc 2. Adds a relation correctness test for Goblin Translator permutation 3. Adds functions for constructing ordered and concatenated constraint polynomials used in the permutation

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.12.0</summary> ## [0.12.0](aztec-packages-v0.11.1...aztec-packages-v0.12.0) (2023-10-26) ### ⚠ BREAKING CHANGES * remove plookup pedersen methods from c_bind namespace ([#3033](#3033)) ### Features * Add function selector to cli to make it easier for to call functions ([#3053](#3053)) ([e0f0a8e](e0f0a8e)), closes [#1996](#1996) * Added correctness tests for several small relations in Goblin Translator (Goblin Translator part 8) ([#2963](#2963)) ([4c83250](4c83250)) * AWS mainnet fork ([#2986](#2986)) ([f491362](f491362)) * Correctness tests for decomposition and non-native field relations (Goblin Translator Part 9) ([#2981](#2981)) ([cdc830d](cdc830d)) * Enable sol verifier tests in ci ([#2997](#2997)) ([058de1e](058de1e)) * Goblin Translator flavor and permutation correctness (Goblin Translator part 7) ([#2961](#2961)) ([737f17f](737f17f)) * Linking errors ([#3004](#3004)) ([388a47b](388a47b)), closes [#2969](#2969) ### Bug Fixes * Fix clang-16 check ([#3030](#3030)) ([7a5a8b3](7a5a8b3)) * Fix docusaurus yellow paper build ([#3063](#3063)) ([db54c1f](db54c1f)) * Run deploy step for mainnet fork ([#3052](#3052)) ([9b6be22](9b6be22)) * Try fix publish bb ([#3036](#3036)) ([51248b5](51248b5)) * Unboxing - nargo.toml injection of "-" for "_" ([#3018](#3018)) ([83d6c51](83d6c51)) ### Miscellaneous * **acir_tests:** Add script to regenerate double_verify_proof inputs ([#3005](#3005)) ([9c4eab2](9c4eab2)) * Add portal contract option to deploy subcommand of aztec-cli ([#3032](#3032)) ([546b410](546b410)) * Fix `pedersen_compress_with_hash_index` c_bind function ([#3054](#3054)) ([a136f6e](a136f6e)) * Msg sender is 0 when no entrypoint is called ([#3024](#3024)) ([53c6680](53c6680)), closes [#2949](#2949) * Optimize pedersen hash for the common usecase by not allocating when input fits in scratch space ([#3056](#3056)) ([a0d290d](a0d290d)) * Proxy redundant `hash` methods ([#3046](#3046)) ([df389b5](df389b5)) * Remove "non-core artifact" nargo generated files ([#3026](#3026)) ([03ebb8e](03ebb8e)), closes [#2977](#2977) * Remove `pedersen_buffer_to_field` from c_bind ([#3045](#3045)) ([de7e63b](de7e63b)) * Remove pedersen hash oracle ([#3023](#3023)) ([0e6958c](0e6958c)) * Remove plookup pedersen methods from c_bind namespace ([#3033](#3033)) ([a8ea391](a8ea391)) * Rename pedersen typescript methods to be called `hash` instead of compress ([#3047](#3047)) ([2f7cc5f](2f7cc5f)) * Run check rebuild on boxes ([#3000](#3000)) ([c503d91](c503d91)) * Same prettier in boxes and everywhere else ([#3025](#3025)) ([0769d20](0769d20)), closes [#2978](#2978) </details> <details><summary>barretenberg.js: 0.12.0</summary> ## [0.12.0](barretenberg.js-v0.11.1...barretenberg.js-v0.12.0) (2023-10-26) ### ⚠ BREAKING CHANGES * remove plookup pedersen methods from c_bind namespace ([#3033](#3033)) ### Miscellaneous * Proxy redundant `hash` methods ([#3046](#3046)) ([df389b5](df389b5)) * Remove `pedersen_buffer_to_field` from c_bind ([#3045](#3045)) ([de7e63b](de7e63b)) * Remove plookup pedersen methods from c_bind namespace ([#3033](#3033)) ([a8ea391](a8ea391)) * Rename pedersen typescript methods to be called `hash` instead of compress ([#3047](#3047)) ([2f7cc5f](2f7cc5f)) </details> <details><summary>barretenberg: 0.12.0</summary> ## [0.12.0](barretenberg-v0.11.1...barretenberg-v0.12.0) (2023-10-26) ### ⚠ BREAKING CHANGES * remove plookup pedersen methods from c_bind namespace ([#3033](#3033)) ### Features * Added correctness tests for several small relations in Goblin Translator (Goblin Translator part 8) ([#2963](#2963)) ([4c83250](4c83250)) * Correctness tests for decomposition and non-native field relations (Goblin Translator Part 9) ([#2981](#2981)) ([cdc830d](cdc830d)) * Enable sol verifier tests in ci ([#2997](#2997)) ([058de1e](058de1e)) * Goblin Translator flavor and permutation correctness (Goblin Translator part 7) ([#2961](#2961)) ([737f17f](737f17f)) ### Bug Fixes * Fix clang-16 check ([#3030](#3030)) ([7a5a8b3](7a5a8b3)) ### Miscellaneous * **acir_tests:** Add script to regenerate double_verify_proof inputs ([#3005](#3005)) ([9c4eab2](9c4eab2)) * Fix `pedersen_compress_with_hash_index` c_bind function ([#3054](#3054)) ([a136f6e](a136f6e)) * Proxy redundant `hash` methods ([#3046](#3046)) ([df389b5](df389b5)) * Remove `pedersen_buffer_to_field` from c_bind ([#3045](#3045)) ([de7e63b](de7e63b)) * Remove pedersen hash oracle ([#3023](#3023)) ([0e6958c](0e6958c)) * Remove plookup pedersen methods from c_bind namespace ([#3033](#3033)) ([a8ea391](a8ea391)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.12.0</summary> ## [0.12.0](AztecProtocol/aztec-packages@aztec-packages-v0.11.1...aztec-packages-v0.12.0) (2023-10-26) ### ⚠ BREAKING CHANGES * remove plookup pedersen methods from c_bind namespace ([#3033](AztecProtocol/aztec-packages#3033)) ### Features * Add function selector to cli to make it easier for to call functions ([#3053](AztecProtocol/aztec-packages#3053)) ([e0f0a8e](AztecProtocol/aztec-packages@e0f0a8e)), closes [#1996](AztecProtocol/aztec-packages#1996) * Added correctness tests for several small relations in Goblin Translator (Goblin Translator part 8) ([#2963](AztecProtocol/aztec-packages#2963)) ([4c83250](AztecProtocol/aztec-packages@4c83250)) * AWS mainnet fork ([#2986](AztecProtocol/aztec-packages#2986)) ([f491362](AztecProtocol/aztec-packages@f491362)) * Correctness tests for decomposition and non-native field relations (Goblin Translator Part 9) ([#2981](AztecProtocol/aztec-packages#2981)) ([cdc830d](AztecProtocol/aztec-packages@cdc830d)) * Enable sol verifier tests in ci ([#2997](AztecProtocol/aztec-packages#2997)) ([058de1e](AztecProtocol/aztec-packages@058de1e)) * Goblin Translator flavor and permutation correctness (Goblin Translator part 7) ([#2961](AztecProtocol/aztec-packages#2961)) ([737f17f](AztecProtocol/aztec-packages@737f17f)) * Linking errors ([#3004](AztecProtocol/aztec-packages#3004)) ([388a47b](AztecProtocol/aztec-packages@388a47b)), closes [#2969](AztecProtocol/aztec-packages#2969) ### Bug Fixes * Fix clang-16 check ([#3030](AztecProtocol/aztec-packages#3030)) ([7a5a8b3](AztecProtocol/aztec-packages@7a5a8b3)) * Fix docusaurus yellow paper build ([#3063](AztecProtocol/aztec-packages#3063)) ([db54c1f](AztecProtocol/aztec-packages@db54c1f)) * Run deploy step for mainnet fork ([#3052](AztecProtocol/aztec-packages#3052)) ([9b6be22](AztecProtocol/aztec-packages@9b6be22)) * Try fix publish bb ([#3036](AztecProtocol/aztec-packages#3036)) ([51248b5](AztecProtocol/aztec-packages@51248b5)) * Unboxing - nargo.toml injection of "-" for "_" ([#3018](AztecProtocol/aztec-packages#3018)) ([83d6c51](AztecProtocol/aztec-packages@83d6c51)) ### Miscellaneous * **acir_tests:** Add script to regenerate double_verify_proof inputs ([#3005](AztecProtocol/aztec-packages#3005)) ([9c4eab2](AztecProtocol/aztec-packages@9c4eab2)) * Add portal contract option to deploy subcommand of aztec-cli ([#3032](AztecProtocol/aztec-packages#3032)) ([546b410](AztecProtocol/aztec-packages@546b410)) * Fix `pedersen_compress_with_hash_index` c_bind function ([#3054](AztecProtocol/aztec-packages#3054)) ([a136f6e](AztecProtocol/aztec-packages@a136f6e)) * Msg sender is 0 when no entrypoint is called ([#3024](AztecProtocol/aztec-packages#3024)) ([53c6680](AztecProtocol/aztec-packages@53c6680)), closes [#2949](AztecProtocol/aztec-packages#2949) * Optimize pedersen hash for the common usecase by not allocating when input fits in scratch space ([#3056](AztecProtocol/aztec-packages#3056)) ([a0d290d](AztecProtocol/aztec-packages@a0d290d)) * Proxy redundant `hash` methods ([#3046](AztecProtocol/aztec-packages#3046)) ([df389b5](AztecProtocol/aztec-packages@df389b5)) * Remove "non-core artifact" nargo generated files ([#3026](AztecProtocol/aztec-packages#3026)) ([03ebb8e](AztecProtocol/aztec-packages@03ebb8e)), closes [#2977](AztecProtocol/aztec-packages#2977) * Remove `pedersen_buffer_to_field` from c_bind ([#3045](AztecProtocol/aztec-packages#3045)) ([de7e63b](AztecProtocol/aztec-packages@de7e63b)) * Remove pedersen hash oracle ([#3023](AztecProtocol/aztec-packages#3023)) ([0e6958c](AztecProtocol/aztec-packages@0e6958c)) * Remove plookup pedersen methods from c_bind namespace ([#3033](AztecProtocol/aztec-packages#3033)) ([a8ea391](AztecProtocol/aztec-packages@a8ea391)) * Rename pedersen typescript methods to be called `hash` instead of compress ([#3047](AztecProtocol/aztec-packages#3047)) ([2f7cc5f](AztecProtocol/aztec-packages@2f7cc5f)) * Run check rebuild on boxes ([#3000](AztecProtocol/aztec-packages#3000)) ([c503d91](AztecProtocol/aztec-packages@c503d91)) * Same prettier in boxes and everywhere else ([#3025](AztecProtocol/aztec-packages#3025)) ([0769d20](AztecProtocol/aztec-packages@0769d20)), closes [#2978](AztecProtocol/aztec-packages#2978) </details> <details><summary>barretenberg.js: 0.12.0</summary> ## [0.12.0](AztecProtocol/aztec-packages@barretenberg.js-v0.11.1...barretenberg.js-v0.12.0) (2023-10-26) ### ⚠ BREAKING CHANGES * remove plookup pedersen methods from c_bind namespace ([#3033](AztecProtocol/aztec-packages#3033)) ### Miscellaneous * Proxy redundant `hash` methods ([#3046](AztecProtocol/aztec-packages#3046)) ([df389b5](AztecProtocol/aztec-packages@df389b5)) * Remove `pedersen_buffer_to_field` from c_bind ([#3045](AztecProtocol/aztec-packages#3045)) ([de7e63b](AztecProtocol/aztec-packages@de7e63b)) * Remove plookup pedersen methods from c_bind namespace ([#3033](AztecProtocol/aztec-packages#3033)) ([a8ea391](AztecProtocol/aztec-packages@a8ea391)) * Rename pedersen typescript methods to be called `hash` instead of compress ([#3047](AztecProtocol/aztec-packages#3047)) ([2f7cc5f](AztecProtocol/aztec-packages@2f7cc5f)) </details> <details><summary>barretenberg: 0.12.0</summary> ## [0.12.0](AztecProtocol/aztec-packages@barretenberg-v0.11.1...barretenberg-v0.12.0) (2023-10-26) ### ⚠ BREAKING CHANGES * remove plookup pedersen methods from c_bind namespace ([#3033](AztecProtocol/aztec-packages#3033)) ### Features * Added correctness tests for several small relations in Goblin Translator (Goblin Translator part 8) ([#2963](AztecProtocol/aztec-packages#2963)) ([4c83250](AztecProtocol/aztec-packages@4c83250)) * Correctness tests for decomposition and non-native field relations (Goblin Translator Part 9) ([#2981](AztecProtocol/aztec-packages#2981)) ([cdc830d](AztecProtocol/aztec-packages@cdc830d)) * Enable sol verifier tests in ci ([#2997](AztecProtocol/aztec-packages#2997)) ([058de1e](AztecProtocol/aztec-packages@058de1e)) * Goblin Translator flavor and permutation correctness (Goblin Translator part 7) ([#2961](AztecProtocol/aztec-packages#2961)) ([737f17f](AztecProtocol/aztec-packages@737f17f)) ### Bug Fixes * Fix clang-16 check ([#3030](AztecProtocol/aztec-packages#3030)) ([7a5a8b3](AztecProtocol/aztec-packages@7a5a8b3)) ### Miscellaneous * **acir_tests:** Add script to regenerate double_verify_proof inputs ([#3005](AztecProtocol/aztec-packages#3005)) ([9c4eab2](AztecProtocol/aztec-packages@9c4eab2)) * Fix `pedersen_compress_with_hash_index` c_bind function ([#3054](AztecProtocol/aztec-packages#3054)) ([a136f6e](AztecProtocol/aztec-packages@a136f6e)) * Proxy redundant `hash` methods ([#3046](AztecProtocol/aztec-packages#3046)) ([df389b5](AztecProtocol/aztec-packages@df389b5)) * Remove `pedersen_buffer_to_field` from c_bind ([#3045](AztecProtocol/aztec-packages#3045)) ([de7e63b](AztecProtocol/aztec-packages@de7e63b)) * Remove pedersen hash oracle ([#3023](AztecProtocol/aztec-packages#3023)) ([0e6958c](AztecProtocol/aztec-packages@0e6958c)) * Remove plookup pedersen methods from c_bind namespace ([#3033](AztecProtocol/aztec-packages#3033)) ([a8ea391](AztecProtocol/aztec-packages@a8ea391)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Added flavor and permutation correctness test

c7372c4

Rumata888 added the crypto cryptography label Oct 22, 2023

Rumata888 self-assigned this Oct 22, 2023

Cleanup

e2daa84

Rumata888 marked this pull request as ready for review October 22, 2023 18:52

Rumata888 requested a review from zac-williamson October 22, 2023 19:07

Rumata888 changed the title ~~feat: Goblin Translator flavor and permutation correctness~~ feat: Goblin Translator flavor and permutation correctness (Goblin Translator part 7) Oct 22, 2023

Rumata888 requested review from maramihali and removed request for maramihali October 23, 2023 13:57

zac-williamson reviewed Oct 23, 2023

View reviewed changes

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp Show resolved Hide resolved

zac-williamson reviewed Oct 23, 2023

View reviewed changes

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp Show resolved Hide resolved

zac-williamson reviewed Oct 23, 2023

View reviewed changes

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp Show resolved Hide resolved

zac-williamson reviewed Oct 23, 2023

View reviewed changes

zac-williamson reviewed Oct 24, 2023

View reviewed changes

barretenberg/cpp/src/barretenberg/honk/proof_system/permutation_library.hpp Show resolved Hide resolved

zac-williamson reviewed Oct 24, 2023

View reviewed changes

barretenberg/cpp/src/barretenberg/honk/proof_system/permutation_library.hpp Show resolved Hide resolved

zac-williamson reviewed Oct 24, 2023

View reviewed changes

barretenberg/cpp/src/barretenberg/honk/proof_system/permutation_library.hpp Show resolved Hide resolved

zac-williamson requested changes Oct 24, 2023

View reviewed changes

Rumata888 added 2 commits October 24, 2023 21:32

Addressed Zac's comments

178409c

Merge branch 'master' into is/goblin_translator_flavor_and_friends

2ef2c25

Rumata888 requested a review from zac-williamson October 24, 2023 21:38

Reverted incorrectly addressing comments

8a5776e

zac-williamson approved these changes Oct 24, 2023

View reviewed changes

Merge branch 'master' into is/goblin_translator_flavor_and_friends

1904a9b

Rumata888 merged commit 737f17f into master Oct 24, 2023
2 checks passed

Rumata888 deleted the is/goblin_translator_flavor_and_friends branch October 24, 2023 23:18

AztecBot mentioned this pull request Oct 24, 2023

chore(master): Release 0.12.0 #3021

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Goblin Translator flavor and permutation correctness (Goblin Translator part 7) #2961

feat: Goblin Translator flavor and permutation correctness (Goblin Translator part 7) #2961

Rumata888 commented Oct 22, 2023 •

edited

Loading

AztecBot commented Oct 22, 2023 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

zac-williamson Oct 23, 2023

Rumata888 Oct 24, 2023

zac-williamson Oct 23, 2023

Rumata888 Oct 24, 2023

zac-williamson Oct 24, 2023

Rumata888 Oct 24, 2023

zac-williamson Oct 24, 2023

Rumata888 Oct 24, 2023

zac-williamson left a comment

feat: Goblin Translator flavor and permutation correctness (Goblin Translator part 7) #2961

feat: Goblin Translator flavor and permutation correctness (Goblin Translator part 7) #2961

Conversation

Rumata888 commented Oct 22, 2023 • edited Loading

Checklist:

AztecBot commented Oct 22, 2023 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zac-williamson left a comment

Choose a reason for hiding this comment

Rumata888 commented Oct 22, 2023 •

edited

Loading

AztecBot commented Oct 22, 2023 •

edited

Loading