refactor: nuking old BlockHeader

[benesjan]

Fixes #3937
Fixes #3564
Fixes #4134

[benesjan]

Current dependencies on/for this PR:

• master
  • PR refactor: unifying Header serialization accross domains #4230
    • PR refactor: nuking old BlockHeader #4154 👈
      • PR feat: removing redundant values from PrivateCircuitPublicInputs #4255

This stack of pull requests is managed by Graphite.

[github-actions]

Changes to circuit sizes

Generated at commit: 497e01b8f11cb7c8356fc2392c02f0e80edc9d7f, compared to commit: d7e2d9c80262dd4dff714caac575785b3bf14482

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_ordering_simulated	+11 ❌	+2.24%	+22 ❌	+2.23%
public_kernel_public_previous_simulated	+11 ❌	+1.30%	+22 ❌	+1.30%
private_kernel_inner_simulated	+11 ❌	+1.30%	+22 ❌	+1.30%
public_kernel_private_previous_simulated	+11 ❌	+1.30%	+22 ❌	+1.30%
private_kernel_init_simulated	+11 ❌	+1.30%	+22 ❌	+1.30%
public_kernel_public_previous	+34 ❌	+0.07%	+3,465 ❌	+1.24%
public_kernel_private_previous	+34 ❌	+0.07%	+3,465 ❌	+1.24%
private_kernel_inner	+23 ❌	+0.02%	+3,453 ❌	+0.66%
rollup_base	+7 ❌	+0.01%	+1,500 ❌	+0.11%
private_kernel_init	+17 ❌	+0.05%	+32 ❌	+0.01%
private_kernel_ordering	+17 ❌	+0.01%	+32 ❌	+0.01%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_ordering_simulated	502 (+11)	+2.24%	1,007 (+22)	+2.23%
public_kernel_public_previous_simulated	858 (+11)	+1.30%	1,719 (+22)	+1.30%
private_kernel_inner_simulated	858 (+11)	+1.30%	1,719 (+22)	+1.30%
public_kernel_private_previous_simulated	858 (+11)	+1.30%	1,719 (+22)	+1.30%
private_kernel_init_simulated	858 (+11)	+1.30%	1,719 (+22)	+1.30%
public_kernel_public_previous	47,161 (+34)	+0.07%	282,740 (+3,465)	+1.24%
public_kernel_private_previous	47,169 (+34)	+0.07%	282,748 (+3,465)	+1.24%
private_kernel_inner	92,894 (+23)	+0.02%	523,078 (+3,453)	+0.66%
rollup_base	128,061 (+7)	+0.01%	1,361,580 (+1,500)	+0.11%
private_kernel_init	36,576 (+17)	+0.05%	334,035 (+32)	+0.01%
private_kernel_ordering	196,212 (+17)	+0.01%	504,360 (+32)	+0.01%

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 382dfbed and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,776	866,812	3,448,252
l1_rollup_execution_gas	314,263	984,552	3,667,909
l2_block_processing_time_in_ms	1,150	4,354	17,223
note_successful_decrypting_time_in_ms	264 (+4%)	911 (+3%)	3,509 (+5%)
note_trial_decrypting_time_in_ms	77.7 (+20%)	178 (-6%)	150 (+2%)
l2_block_building_time_in_ms	16,646 (+1%)	65,808 (+1%)	264,292 (+1%)
l2_block_rollup_simulation_time_in_ms	11,877	46,936	189,288
l2_block_public_tx_process_time_in_ms	4,740 (+4%)	18,751 (+4%)	74,756 (+4%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,431 (+1%)	25,784 (+1%)
note_history_successful_decrypting_time_in_ms	2,447 (+14%)	4,486 (+7%)
note_history_trial_decrypting_time_in_ms	97.9 (-43%)	209 (+19%)
node_database_size_in_bytes	17,309,776	33,140,816
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	221	44,897	26,193
private-kernel-ordering	181 (+2%)	44,513	14,929 (+1%)
base-rollup	1,258	128,970	881
root-rollup	81.6	4,088	677
private-kernel-inner	322 (+4%)	72,056	26,193
public-kernel-private-input	223 (+3%)	32,615 (+1%)	26,193
public-kernel-non-first-iteration	223 (+4%)	32,657 (+1%)	26,193
merge-rollup	7.59	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.3	12.7	17.0 (-1%)	23.2 (+1%)	63.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.595	0.632	0.541	0.526 (-1%)	0.483 (+1%)	0.441	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	78.9 (+1%)	47.7	239	461	901	3,544
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.488 (+3%)	0.489	0.436	0.431	0.430	0.427
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	108 (+4%)	56.9	347	689 (+1%)	1,365	5,395
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.507 (+3%)	0.497 (-1%)	0.474	0.474	0.474	0.471
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.578	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,575 (+1%)	36,454 (+10%)

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	399 (+1%)	1,147 (+3%)

Metric	1 public data writes
tx_sequencer_processing_time_ms	583 (+5%)

[LHerskind]

Have a few comments/questions but solid work, looks really good.
Most of it is comment/questions, but if you address some that was directly on code and simply add a response to the others would be great before merging.

[LHerskind]

If I recall, at some point you would like to have publicInputs.historicalHeader.toACVM()? It this still something you think could be good to have. I think the use of toFieldArray() is quite nice here, but not sure if that is the target to use that structure generally.

[benesjan]

Yes, I had a plan to do it in this issue (might split it to a separate issue now that I think about it).

In general it seems to be a good idea to have all the serialization in the classes themselves so I would probably implement a FieldReader in foundation/serialize (akin to BufferReader) and use that in these types which are passed in the witness.

[benesjan]

The changes to this file were made by bootstrap after rebase.

[benesjan]

Yes, I had a plan to do it in this issue (might split it to a separate issue now that I think about it).

In general it seems to be a good idea to have all the serialization in the classes themselves so I would probably implement a FieldReader in foundation/serialize (akin to BufferReader) and use that in these types which are passed in the witness.