feat: limit exposed functions on note utils

[LHerskind]

• Removes the note_hash as it was only used in the note_utils.
• Uses the compute_note_hash_for_read_or_nullify instead of its inner functions when results will be the same
  • This increases cost, but here I'm doing it for clarity making it easier for us to have something useful first that is understandable and then optimize later.
• Stop exposing the inner functions to enhance clarity (at performance cost)

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 87.8 (+145%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9e6250aa and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,728	866,920	3,446,668
l1_rollup_execution_gas	314,215	984,660	3,666,325
l2_block_processing_time_in_ms	1,155 (-1%)	4,334 (-1%)	17,165 (-1%)
note_successful_decrypting_time_in_ms	256 (-2%)	863 (-5%)	3,288 (-5%)
note_trial_decrypting_time_in_ms	65.4 (-9%)	⚠️ 87.8 (+145%)	138 (+1%)
l2_block_building_time_in_ms	15,759 (-1%)	62,270 (-1%)	250,741 (-1%)
l2_block_rollup_simulation_time_in_ms	11,327 (-1%)	44,750 (-1%)	180,801
l2_block_public_tx_process_time_in_ms	4,403 (-1%)	17,425 (-1%)	69,701 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,352	27,692 (+9%)
note_history_successful_decrypting_time_in_ms	2,217 (+5%)	4,428 (+4%)
note_history_trial_decrypting_time_in_ms	154 (+40%)	203 (+12%)
node_database_size_in_bytes	17,285,200	32,972,880 (-1%)
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	214	44,777	26,073
private-kernel-ordering	170 (-1%)	44,393	14,809
base-rollup	1,197	128,850	881
root-rollup	79.0	4,088	677
private-kernel-inner	300 (-1%)	71,816	26,073
public-kernel-private-input	209	32,375	26,073
public-kernel-non-first-iteration	207	32,417	26,073
merge-rollup	7.61 (-1%)	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	10.6 (-1%)	12.5 (-2%)	16.8	22.7 (-1%)	63.5 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.592	0.590 (-1%)	0.534 (-1%)	0.521	0.476 (-1%)	0.439 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	75.0 (+1%)	47.3 (-1%)	238 (-1%)	460	897 (-1%)	3,538 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.459	0.486	0.435 (-1%)	0.431	0.427 (-1%)	0.426 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	106 (+2%)	56.4 (-1%)	350 (-2%)	748 (+9%)	1,352 (-1%)	5,383 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.506 (+2%)	0.495	0.474 (-1%)	0.518 (+10%)	0.470 (-1%)	0.470 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	58.0 (+3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.594 (+3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,706

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	386 (+1%)	1,090 (-1%)

Metric	1 public data writes
tx_sequencer_processing_time_ms	542 (-1%)

[benesjan]

LGTM

[rahul-kothari]

note hash lifecycle is such a maze. thank you for making it easier to navigate!