feat: updating global vars with fees #4421

benesjan · 2024-02-05T15:32:48Z

benesjan · 2024-02-05T15:33:01Z

Current dependencies on/for this PR:

master
- PR feat: updating global vars with fees #4421 👈
  - PR refactor: cleanup of abi.nr in aztec-nr #4473
    - PR test: testing all values in PublicGlobalVariables and PrivateGlobalVariables #4481
      - PR chore: simulator utils cleanup #4507
        
        PR test: testing historical header in contexts #4509
        
        PR refactor: aligning some naming in BaseOrMergeRollupPublicInputs #4510

This stack of pull requests is managed by Graphite.

github-actions · 2024-02-05T16:48:24Z

Changes to circuit sizes

Generated at commit: 4f732410aba2d5f61ba7a1e680acf3d590cdd160, compared to commit: fabeac8b3f9971763a9a723ac6983e5ea8330f46

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_public_previous	+4 ❌	+0.01%	+626 ❌	+0.25%
public_kernel_private_previous	+4 ❌	+0.01%	+626 ❌	+0.25%
private_kernel_inner	+2 ❌	+0.00%	+625 ❌	+0.12%
private_kernel_ordering_simulated	+2 ❌	+0.29%	+4 ❌	+0.10%
public_kernel_public_previous_simulated	+2 ❌	+0.18%	+4 ❌	+0.08%
private_kernel_inner_simulated	+2 ❌	+0.18%	+4 ❌	+0.08%
public_kernel_private_previous_simulated	+2 ❌	+0.18%	+4 ❌	+0.08%
private_kernel_init_simulated	+2 ❌	+0.18%	+4 ❌	+0.08%
rollup_base_simulated	0 ➖	0.00%	+2 ❌	+0.07%
rollup_base	0 ➖	0.00%	+622 ❌	+0.05%
private_kernel_init	+2 ❌	+0.01%	+4 ❌	+0.00%
private_kernel_ordering	+2 ❌	+0.00%	+4 ❌	+0.00%
rollup_merge	+2 ❌	+0.71%	0 ➖	0.00%
rollup_root	+2 ❌	+0.10%	0 ➖	0.00%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_public_previous	46,875 (+4)	+0.01%	251,327 (+626)	+0.25%
public_kernel_private_previous	46,883 (+4)	+0.01%	251,335 (+626)	+0.25%
private_kernel_inner	92,628 (+2)	+0.00%	520,100 (+625)	+0.12%
private_kernel_ordering_simulated	703 (+2)	+0.29%	4,097 (+4)	+0.10%
public_kernel_public_previous_simulated	1,115 (+2)	+0.18%	4,894 (+4)	+0.08%
private_kernel_inner_simulated	1,115 (+2)	+0.18%	4,894 (+4)	+0.08%
public_kernel_private_previous_simulated	1,115 (+2)	+0.18%	4,894 (+4)	+0.08%
private_kernel_init_simulated	1,115 (+2)	+0.18%	4,894 (+4)	+0.08%
rollup_base_simulated	11 (0)	0.00%	2,793 (+2)	+0.07%
rollup_base	128,780 (0)	0.00%	1,365,150 (+622)	+0.05%
private_kernel_init	36,346 (+2)	+0.01%	331,145 (+4)	+0.00%
private_kernel_ordering	196,169 (+2)	+0.00%	504,325 (+4)	+0.00%
rollup_merge	285 (+2)	+0.71%	40,983 (0)	0.00%
rollup_root	1,956 (+2)	+0.10%	99,124 (0)	0.00%

AztecBot · 2024-02-06T15:44:23Z

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 545b3341 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,700	180,580	720,100
l1_rollup_calldata_gas	222,832	871,336	3,466,024
l1_rollup_execution_gas	316,023	989,784	3,686,402
l2_block_processing_time_in_ms	1,147 (-1%)	4,354 (+1%)	17,241
note_successful_decrypting_time_in_ms	301 (-2%)	971 (+1%)	3,657 (+2%)
note_trial_decrypting_time_in_ms	12.1 (-40%)	99.1 (+7%)	152 (+8%)
l2_block_building_time_in_ms	17,788 (-1%)	70,181	282,048 (-1%)
l2_block_rollup_simulation_time_in_ms	13,081	51,538	207,791
l2_block_public_tx_process_time_in_ms	4,674 (-3%)	18,519 (-2%)	73,996 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,792 (-10%)	26,402 (-10%)
note_history_successful_decrypting_time_in_ms	2,517 (+4%)	4,595 (+1%)
note_history_trial_decrypting_time_in_ms	132 (+54%)	216 (+7%)
node_database_size_in_bytes	17,326,160	32,989,264
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	305 (-2%)	44,528	25,825 (-1%)
private-kernel-ordering	194 (-2%)	44,145 (-1%)	16,225 (-2%)
base-rollup	1,404	128,654	933 (+6%)
root-rollup	82.3	4,192 (+3%)	729 (+8%)
private-kernel-inner	435 (-2%)	71,331	25,825 (-1%)
public-kernel-private-input	240 (-2%)	32,287 (-1%)	25,825 (-1%)
public-kernel-non-first-iteration	237 (-3%)	32,329 (-1%)	25,825 (-1%)
merge-rollup	7.84 (+4%)	2,712 (+4%)	933 (+6%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	10.6 (-3%)	12.6	17.0	22.8	63.6 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.593	0.591 (-4%)	0.536	0.529	0.478	0.440	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.2 (-1%)	47.6	238	461	898	3,548
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.459 (-1%)	0.488	0.434 (-1%)	0.432	0.428	0.427
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	104 (+1%)	56.6	348	687	1,368 (+1%)	5,391
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.495 (+1%)	0.496	0.472	0.473	0.475	0.471
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.4	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.577	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,859 (-2%)	40,144

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	544 (-2%)	1,301 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.484 (-19%)	574 (-2%)

LHerskind

Minor comments. Good stuff

l1-contracts/slither_output.md

l1-contracts/src/core/libraries/HeaderLib.sol

yarn-project/aztec-node/src/aztec-node/server.ts

LHerskind · 2024-02-06T17:16:10Z

yarn-project/aztec-nr/aztec/src/abi.nr

-impl Serialize<4> for PublicGlobalVariables {
-    fn serialize(self) -> [Field; 4] {
-        [self.chain_id, self.version, self.block_number, self.timestamp]
+impl Serialize<6> for PublicGlobalVariables {


I think this implementation is already in the types in global_variables.nr, should we not just be importing that so we don't end up repeating.

If not removing it, can you use the constant value instead of a hardcoded number in here?

Makes sense. I will try removing it in the PR up the stack.

LHerskind · 2024-02-06T17:24:00Z

yarn-project/sequencer-client/src/config.ts

@@ -76,5 +79,8 @@ export function getConfigEnvVars(): SequencerClientConfig {
    publisherPrivateKey,
    maxTxsPerBlock: SEQ_MAX_TX_PER_BLOCK ? +SEQ_MAX_TX_PER_BLOCK : 32,
    minTxsPerBlock: SEQ_MIN_TX_PER_BLOCK ? +SEQ_MIN_TX_PER_BLOCK : 1,
+    // TODO: undefined should not be allowed for the following 2 values in PROD
+    coinbase: COINBASE ? EthAddress.fromString(COINBASE) : undefined,


Unclear if you could just use address zero. If the fees require a refund that is initiated by the fee recipient that one will be a problem. But if not could likely work, but just throwing away all fees and rewards.

I think we should do that because if the intention of the sequencer is to burn their rewards they can set coinbase to 0x000000000000000000000000000000000000dEaD and feeRecipient to some other burner value. Allowing for 0 could lead to accidental losses due to misconfiguration.

But I also think that it makes sense to tackle later as currently it's convenient to not have to bother with proper configs so would just create the issue and link it in here an in sequencer.ts. Would you agree?

LHerskind · 2024-02-06T17:25:28Z

yarn-project/sequencer-client/src/sequencer/sequencer.ts

@@ -31,6 +31,9 @@ export class Sequencer {
  private pollingIntervalMs: number = 1000;
  private maxTxsPerBlock = 32;
  private minTxsPerBLock = 1;
+  // TODO: zero values should not be allowed for the following 2 values in PROD


Similar to above. Should we look at constraining it to not be 0?

#4421 (comment)

LHerskind

Would be neat adding a private test just ensuring that the historical headers are correctly populated. This would likely be useful anyway to ensure that the full header is populated as expected 👀

LHerskind · 2024-02-07T12:13:38Z

yarn-project/simulator/src/public/index.test.ts

@@ -618,4 +632,110 @@ describe('ACIR public execution simulator', () => {
      });
    });
  });
+
+  describe('Global variables in public context', () => {


Should probably add the same in private to be thorough.

Will add the more thorough header tests in a separate PR.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (#4420) * Add expression width into acir (#4014) * init storage macro (#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Add bit size to const opcode (#4385) ([4113cfd](4113cfd)) * Add expression width into acir (#4014) ([4113cfd](4113cfd)) * Allow brillig to read arrays directly from memory (#4460) ([4113cfd](4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (#4478) ([4113cfd](4113cfd)) * **avm:** Back in avm context with macro - refactor context (#4438) ([4113cfd](4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **avm:** Support variable size SET opcode ([#4465](#4465)) ([545b334](545b334)) * **aztec-nr:** Initial work for aztec public vm macro (#4400) ([4113cfd](4113cfd)) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) * Canonical instance deployer contract ([#4436](#4436)) ([b4acc8c](b4acc8c)) * Init storage macro (#4200) ([4113cfd](4113cfd)) * Updating global vars with fees ([#4421](#4421)) ([34109eb](34109eb)), closes [#3824](#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](#4474)) ([fabeac8](fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](#4487)) ([e1d3f5a](e1d3f5a)) * **docs:** Update mdx files to md ([#4459](#4459)) ([e67d94b](e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](#4472)) ([0a8905a](0a8905a)) * Parse instance deployed event ([#4482](#4482)) ([62b171a](62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](#4486)) ([2082fed](2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ([4113cfd](4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (#4415) ([4113cfd](4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](#4483)) ([92d0aa4](92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](#4456)) ([83a3136](83a3136)) * Rename bigint_neg into bigint_sub (#4420) ([4113cfd](4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](902bbd4)) * Surpress chained macro warning (#4396) ([4113cfd](4113cfd)) * Sync to noir-lang/noir ([4113cfd](4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](#4467)) ([2c82b62](2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Fixes #3824

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (#4420) * Add expression width into acir (#4014) * init storage macro (#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Add bit size to const opcode (#4385) ([4113cfd](4113cfd)) * Add expression width into acir (#4014) ([4113cfd](4113cfd)) * Allow brillig to read arrays directly from memory (#4460) ([4113cfd](4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (#4478) ([4113cfd](4113cfd)) * **avm:** Back in avm context with macro - refactor context (#4438) ([4113cfd](4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **avm:** Support variable size SET opcode ([#4465](#4465)) ([545b334](545b334)) * **aztec-nr:** Initial work for aztec public vm macro (#4400) ([4113cfd](4113cfd)) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) * Canonical instance deployer contract ([#4436](#4436)) ([b4acc8c](b4acc8c)) * Init storage macro (#4200) ([4113cfd](4113cfd)) * Updating global vars with fees ([#4421](#4421)) ([34109eb](34109eb)), closes [#3824](#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](#4474)) ([fabeac8](fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](#4487)) ([e1d3f5a](e1d3f5a)) * **docs:** Update mdx files to md ([#4459](#4459)) ([e67d94b](e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](#4472)) ([0a8905a](0a8905a)) * Parse instance deployed event ([#4482](#4482)) ([62b171a](62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](#4486)) ([2082fed](2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ([4113cfd](4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (#4415) ([4113cfd](4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](#4483)) ([92d0aa4](92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](#4456)) ([83a3136](83a3136)) * Rename bigint_neg into bigint_sub (#4420) ([4113cfd](4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](902bbd4)) * Surpress chained macro warning (#4396) ([4113cfd](4113cfd)) * Sync to noir-lang/noir ([4113cfd](4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](#4467)) ([2c82b62](2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420) * Add expression width into acir (AztecProtocol/aztec-packages#4014) * init storage macro (AztecProtocol/aztec-packages#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](AztecProtocol/aztec-packages#4464)) ([5e16063](AztecProtocol/aztec-packages@5e16063)) * Add bit size to const opcode (AztecProtocol/aztec-packages#4385) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Add expression width into acir (AztecProtocol/aztec-packages#4014) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Allow brillig to read arrays directly from memory (AztecProtocol/aztec-packages#4460) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](AztecProtocol/aztec-packages#4478)) ([bbfa337](AztecProtocol/aztec-packages@bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (AztecProtocol/aztec-packages#4478) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **avm:** Back in avm context with macro - refactor context (AztecProtocol/aztec-packages#4438) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](AztecProtocol/aztec-packages#4441)) ([934fabc](AztecProtocol/aztec-packages@934fabc)), closes [#4304](AztecProtocol/aztec-packages#4304) * **avm:** Support variable size SET opcode ([#4465](AztecProtocol/aztec-packages#4465)) ([545b334](AztecProtocol/aztec-packages@545b334)) * **aztec-nr:** Initial work for aztec public vm macro (AztecProtocol/aztec-packages#4400) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **bb:** Op counting mode ([#4437](AztecProtocol/aztec-packages#4437)) ([5d00cff](AztecProtocol/aztec-packages@5d00cff)) * Canonical instance deployer contract ([#4436](AztecProtocol/aztec-packages#4436)) ([b4acc8c](AztecProtocol/aztec-packages@b4acc8c)) * Init storage macro (AztecProtocol/aztec-packages#4200) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Updating global vars with fees ([#4421](AztecProtocol/aztec-packages#4421)) ([34109eb](AztecProtocol/aztec-packages@34109eb)), closes [#3824](AztecProtocol/aztec-packages#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](AztecProtocol/aztec-packages#4474)) ([fabeac8](AztecProtocol/aztec-packages@fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](AztecProtocol/aztec-packages#4487)) ([e1d3f5a](AztecProtocol/aztec-packages@e1d3f5a)) * **docs:** Update mdx files to md ([#4459](AztecProtocol/aztec-packages#4459)) ([e67d94b](AztecProtocol/aztec-packages@e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](AztecProtocol/aztec-packages#4472)) ([0a8905a](AztecProtocol/aztec-packages@0a8905a)) * Parse instance deployed event ([#4482](AztecProtocol/aztec-packages#4482)) ([62b171a](AztecProtocol/aztec-packages@62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](AztecProtocol/aztec-packages#4486)) ([2082fed](AztecProtocol/aztec-packages@2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221) [skip ci] ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (AztecProtocol/aztec-packages#4415) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](AztecProtocol/aztec-packages#4483)) ([92d0aa4](AztecProtocol/aztec-packages@92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](AztecProtocol/aztec-packages#4456)) ([83a3136](AztecProtocol/aztec-packages@83a3136)) * Rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](AztecProtocol/aztec-packages@902bbd4)) * Surpress chained macro warning (AztecProtocol/aztec-packages#4396) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Sync to noir-lang/noir ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](AztecProtocol/aztec-packages#4467)) ([2c82b62](AztecProtocol/aztec-packages@2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](AztecProtocol/aztec-packages#4464)) ([5e16063](AztecProtocol/aztec-packages@5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](AztecProtocol/aztec-packages#4478)) ([bbfa337](AztecProtocol/aztec-packages@bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](AztecProtocol/aztec-packages#4441)) ([934fabc](AztecProtocol/aztec-packages@934fabc)), closes [#4304](AztecProtocol/aztec-packages#4304) * **bb:** Op counting mode ([#4437](AztecProtocol/aztec-packages#4437)) ([5d00cff](AztecProtocol/aztec-packages@5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Fixes AztecProtocol#3824

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (AztecProtocol#4420) * Add expression width into acir (AztecProtocol#4014) * init storage macro (AztecProtocol#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([AztecProtocol#4464](AztecProtocol#4464)) ([5e16063](AztecProtocol@5e16063)) * Add bit size to const opcode (AztecProtocol#4385) ([4113cfd](AztecProtocol@4113cfd)) * Add expression width into acir (AztecProtocol#4014) ([4113cfd](AztecProtocol@4113cfd)) * Allow brillig to read arrays directly from memory (AztecProtocol#4460) ([4113cfd](AztecProtocol@4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([AztecProtocol#4478](AztecProtocol#4478)) ([bbfa337](AztecProtocol@bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (AztecProtocol#4478) ([4113cfd](AztecProtocol@4113cfd)) * **avm:** Back in avm context with macro - refactor context (AztecProtocol#4438) ([4113cfd](AztecProtocol@4113cfd)) * **avm:** Generic bytecode deserialization ([AztecProtocol#4441](AztecProtocol#4441)) ([934fabc](AztecProtocol@934fabc)), closes [AztecProtocol#4304](AztecProtocol#4304) * **avm:** Support variable size SET opcode ([AztecProtocol#4465](AztecProtocol#4465)) ([545b334](AztecProtocol@545b334)) * **aztec-nr:** Initial work for aztec public vm macro (AztecProtocol#4400) ([4113cfd](AztecProtocol@4113cfd)) * **bb:** Op counting mode ([AztecProtocol#4437](AztecProtocol#4437)) ([5d00cff](AztecProtocol@5d00cff)) * Canonical instance deployer contract ([AztecProtocol#4436](AztecProtocol#4436)) ([b4acc8c](AztecProtocol@b4acc8c)) * Init storage macro (AztecProtocol#4200) ([4113cfd](AztecProtocol@4113cfd)) * Updating global vars with fees ([AztecProtocol#4421](AztecProtocol#4421)) ([34109eb](AztecProtocol@34109eb)), closes [AztecProtocol#3824](AztecProtocol#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([AztecProtocol#4474](AztecProtocol#4474)) ([fabeac8](AztecProtocol@fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([AztecProtocol#4487](AztecProtocol#4487)) ([e1d3f5a](AztecProtocol@e1d3f5a)) * **docs:** Update mdx files to md ([AztecProtocol#4459](AztecProtocol#4459)) ([e67d94b](AztecProtocol@e67d94b)) * **docs:** Update private voting tutorial cli commands ([AztecProtocol#4472](AztecProtocol#4472)) ([0a8905a](AztecProtocol@0a8905a)) * Parse instance deployed event ([AztecProtocol#4482](AztecProtocol#4482)) ([62b171a](AztecProtocol@62b171a)) ### Miscellaneous * Able to run noir-sync manually ([AztecProtocol#4486](AztecProtocol#4486)) ([2082fed](AztecProtocol@2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol#4221) [skip ci] ([4113cfd](AztecProtocol@4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (AztecProtocol#4415) ([4113cfd](AztecProtocol@4113cfd)) * Lift rollup address check & deplot kv-store to npm ([AztecProtocol#4483](AztecProtocol#4483)) ([92d0aa4](AztecProtocol@92d0aa4)) * Nuked `OptionallyRevealedData` ([AztecProtocol#4456](AztecProtocol#4456)) ([83a3136](AztecProtocol@83a3136)) * Rename bigint_neg into bigint_sub (AztecProtocol#4420) ([4113cfd](AztecProtocol@4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](AztecProtocol@902bbd4)) * Surpress chained macro warning (AztecProtocol#4396) ([4113cfd](AztecProtocol@4113cfd)) * Sync to noir-lang/noir ([4113cfd](AztecProtocol@4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([AztecProtocol#4467](AztecProtocol#4467)) ([2c82b62](AztecProtocol@2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([AztecProtocol#4464](AztecProtocol#4464)) ([5e16063](AztecProtocol@5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([AztecProtocol#4478](AztecProtocol#4478)) ([bbfa337](AztecProtocol@bbfa337)) * **avm:** Generic bytecode deserialization ([AztecProtocol#4441](AztecProtocol#4441)) ([934fabc](AztecProtocol@934fabc)), closes [AztecProtocol#4304](AztecProtocol#4304) * **bb:** Op counting mode ([AztecProtocol#4437](AztecProtocol#4437)) ([5d00cff](AztecProtocol@5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

benesjan force-pushed the 02-05-feat_updating_global_vars_with_fees branch 2 times, most recently from d25bfbc to d3bead9 Compare February 5, 2024 16:23

benesjan force-pushed the 02-05-feat_updating_global_vars_with_fees branch 6 times, most recently from 45c2d72 to 1dd3ec5 Compare February 6, 2024 15:00

benesjan force-pushed the 02-05-feat_updating_global_vars_with_fees branch 2 times, most recently from 70e294d to e636fcc Compare February 6, 2024 16:02

benesjan marked this pull request as ready for review February 6, 2024 16:25

benesjan requested a review from LHerskind February 6, 2024 16:25

LHerskind reviewed Feb 6, 2024

View reviewed changes

benesjan force-pushed the 02-05-feat_updating_global_vars_with_fees branch from e636fcc to 61d7839 Compare February 7, 2024 08:32

benesjan mentioned this pull request Feb 7, 2024

refactor: cleanup of abi.nr in aztec-nr #4473

Merged

benesjan force-pushed the 02-05-feat_updating_global_vars_with_fees branch from 0ee178b to 7e10360 Compare February 7, 2024 11:19

benesjan added 11 commits February 7, 2024 11:20

feat: updating global vars with fees

112377b

WIP

c7c6045

updated PublicGlobalVariables

ea29d7a

sequencer config

7640853

WIP

4bdc685

updated test data

6eabab6

updated publisher and decoder tests

ca16d87

fix

3d6f48a

updated yellow paper

0ae7511

updated slither output

09ab96a

updated slither output 2

3ca2461

benesjan added 7 commits February 7, 2024 11:20

cleanup

8cc8587

populating fee addrs in aztec node

92faf73

HEADER_LENGTH constant

1708c2e

fix ordering

2b75090

testing global cars in public context

f5f5742

updated slither output

1121aa9

test data update

8cbae10

benesjan force-pushed the 02-05-feat_updating_global_vars_with_fees branch from 7e10360 to 8cbae10 Compare February 7, 2024 11:20

benesjan requested a review from LHerskind February 7, 2024 12:02

LHerskind approved these changes Feb 7, 2024

View reviewed changes

benesjan merged commit 34109eb into master Feb 7, 2024
88 checks passed

benesjan deleted the 02-05-feat_updating_global_vars_with_fees branch February 7, 2024 12:28

AztecBot mentioned this pull request Feb 7, 2024

chore(master): Release 0.23.0 #4466

Merged

benesjan mentioned this pull request Feb 7, 2024

test: testing all values in PublicGlobalVariables and PrivateGlobalVariables #4481

Merged

TomAFrench pushed a commit that referenced this pull request Feb 7, 2024

feat: updating global vars with fees (#4421)

7e00384

Fixes #3824

This was referenced Feb 8, 2024

chore: simulator utils cleanup #4507

Merged

test: testing historical header in contexts #4509

Merged

refactor: aligning some naming in BaseOrMergeRollupPublicInputs #4510

Merged

michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024

feat: updating global vars with fees (AztecProtocol#4421)

337fc77

Fixes AztecProtocol#3824

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: updating global vars with fees #4421

feat: updating global vars with fees #4421

benesjan commented Feb 5, 2024

benesjan commented Feb 5, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

AztecBot commented Feb 6, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

LHerskind left a comment

LHerskind Feb 6, 2024

benesjan Feb 7, 2024

LHerskind Feb 6, 2024

benesjan Feb 7, 2024 •

edited

Loading

LHerskind Feb 6, 2024

benesjan Feb 7, 2024

LHerskind left a comment

LHerskind Feb 7, 2024

benesjan Feb 7, 2024

feat: updating global vars with fees #4421

feat: updating global vars with fees #4421

Conversation

benesjan commented Feb 5, 2024

benesjan commented Feb 5, 2024 • edited Loading

github-actions bot commented Feb 5, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

AztecBot commented Feb 6, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

LHerskind left a comment

Choose a reason for hiding this comment

LHerskind Feb 6, 2024

Choose a reason for hiding this comment

benesjan Feb 7, 2024

Choose a reason for hiding this comment

LHerskind Feb 6, 2024

Choose a reason for hiding this comment

benesjan Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

LHerskind Feb 6, 2024

Choose a reason for hiding this comment

benesjan Feb 7, 2024

Choose a reason for hiding this comment

LHerskind left a comment

Choose a reason for hiding this comment

LHerskind Feb 7, 2024

Choose a reason for hiding this comment

benesjan Feb 7, 2024

Choose a reason for hiding this comment

benesjan commented Feb 5, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

AztecBot commented Feb 6, 2024 •

edited

Loading

benesjan Feb 7, 2024 •

edited

Loading