feat(avm): support variable size SET opcode #4465

fcarreiro · 2024-02-06T18:07:11Z

Closes #4267.

fcarreiro · 2024-02-06T18:07:28Z

Current dependencies on/for this PR:

master
- PR feat(avm): support variable size SET opcode #4465 👈

This stack of pull requests is managed by Graphite.

AztecBot · 2024-02-06T18:40:43Z

Benchmark results

Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 12.8 (-88%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 16a2eca1 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,636	180,516	720,036
l1_rollup_calldata_gas	222,684	870,960	3,465,948
l1_rollup_execution_gas	315,171	988,700	3,685,605
l2_block_processing_time_in_ms	1,165 (+1%)	4,381	17,313
note_successful_decrypting_time_in_ms	301	960 (-3%)	3,583 (-3%)
note_trial_decrypting_time_in_ms	⚠️ 12.8 (-88%)	89.1 (-27%)	142 (-3%)
l2_block_building_time_in_ms	17,867	70,816	283,398
l2_block_rollup_simulation_time_in_ms	13,057	51,639	207,380
l2_block_public_tx_process_time_in_ms	4,782	19,030	75,758 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,721 (+6%)	27,403 (+4%)
note_history_successful_decrypting_time_in_ms	2,320 (-8%)	4,553 (-2%)
note_history_trial_decrypting_time_in_ms	75.6 (-14%)	268 (+19%)
node_database_size_in_bytes	17,326,160	33,017,936
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	310	44,476	26,153
private-kernel-ordering	198	44,473	16,553
base-rollup	1,405 (-1%)	128,930	881
root-rollup	82.0	4,088	677
private-kernel-inner	444	71,607	26,153
public-kernel-private-input	247	32,563	26,153
public-kernel-non-first-iteration	245	32,605	26,153
merge-rollup	7.62	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	10.7 (-9%)	12.7 (-1%)	17.1 (+1%)	23.0	65.4 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.594	0.596 (-6%)	0.539 (-1%)	0.531 (+2%)	0.481	0.450 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	75.0 (-1%)	47.6	240 (+1%)	461	904	3,584
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.464	0.488	0.438 (+1%)	0.432	0.431	0.431 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	103 (-1%)	56.7	351	686 (-1%)	1,370	5,425
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.493 (-1%)	0.497	0.478	0.473	0.474	0.473
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.5	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.578	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	17,187	39,991

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	553	1,314 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.500 (-2%)	590

dbanks12

LGTM! One comment.

dbanks12 · 2024-02-06T18:53:49Z

yarn-project/simulator/src/avm/opcodes/memory.ts

+  public serialize(): Buffer {
+    const format: OperandType[] = [
+      ...Set.wireFormatBeforeConst,
+      getOperandTypeFromInTag(this.inTag),
+      ...Set.wireFormatAfterConst,
+    ];
+    return serialize(format, this);
+  }
+
+  public static deserialize<T extends { new (...args: any[]): InstanceType<T> }>(
+    this: T,
+    buf: BufferCursor | Buffer,
+  ): InstanceType<T> {
+    if (buf instanceof Buffer) {
+      buf = new BufferCursor(buf);
+    }
+    const beforeConst = deserialize(buf, Set.wireFormatBeforeConst);
+    const tag = beforeConst[beforeConst.length - 1];
+    const val = deserialize(buf, [getOperandTypeFromInTag(tag)]);
+    const afterConst = deserialize(buf, Set.wireFormatAfterConst);
+    const res = [...beforeConst, ...val, ...afterConst];
+    const args = res.slice(1) as ConstructorParameters<typeof Set>; // Remove opcode.
+    return new this(...args);
+  }
+


I'd add brief comments explaining why Set requires custom (de)serialization.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (#4420) * Add expression width into acir (#4014) * init storage macro (#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Add bit size to const opcode (#4385) ([4113cfd](4113cfd)) * Add expression width into acir (#4014) ([4113cfd](4113cfd)) * Allow brillig to read arrays directly from memory (#4460) ([4113cfd](4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (#4478) ([4113cfd](4113cfd)) * **avm:** Back in avm context with macro - refactor context (#4438) ([4113cfd](4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **avm:** Support variable size SET opcode ([#4465](#4465)) ([545b334](545b334)) * **aztec-nr:** Initial work for aztec public vm macro (#4400) ([4113cfd](4113cfd)) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) * Canonical instance deployer contract ([#4436](#4436)) ([b4acc8c](b4acc8c)) * Init storage macro (#4200) ([4113cfd](4113cfd)) * Updating global vars with fees ([#4421](#4421)) ([34109eb](34109eb)), closes [#3824](#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](#4474)) ([fabeac8](fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](#4487)) ([e1d3f5a](e1d3f5a)) * **docs:** Update mdx files to md ([#4459](#4459)) ([e67d94b](e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](#4472)) ([0a8905a](0a8905a)) * Parse instance deployed event ([#4482](#4482)) ([62b171a](62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](#4486)) ([2082fed](2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ([4113cfd](4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (#4415) ([4113cfd](4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](#4483)) ([92d0aa4](92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](#4456)) ([83a3136](83a3136)) * Rename bigint_neg into bigint_sub (#4420) ([4113cfd](4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](902bbd4)) * Surpress chained macro warning (#4396) ([4113cfd](4113cfd)) * Sync to noir-lang/noir ([4113cfd](4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](#4467)) ([2c82b62](2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Closes #4267.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (#4420) * Add expression width into acir (#4014) * init storage macro (#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Add bit size to const opcode (#4385) ([4113cfd](4113cfd)) * Add expression width into acir (#4014) ([4113cfd](4113cfd)) * Allow brillig to read arrays directly from memory (#4460) ([4113cfd](4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (#4478) ([4113cfd](4113cfd)) * **avm:** Back in avm context with macro - refactor context (#4438) ([4113cfd](4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **avm:** Support variable size SET opcode ([#4465](#4465)) ([545b334](545b334)) * **aztec-nr:** Initial work for aztec public vm macro (#4400) ([4113cfd](4113cfd)) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) * Canonical instance deployer contract ([#4436](#4436)) ([b4acc8c](b4acc8c)) * Init storage macro (#4200) ([4113cfd](4113cfd)) * Updating global vars with fees ([#4421](#4421)) ([34109eb](34109eb)), closes [#3824](#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](#4474)) ([fabeac8](fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](#4487)) ([e1d3f5a](e1d3f5a)) * **docs:** Update mdx files to md ([#4459](#4459)) ([e67d94b](e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](#4472)) ([0a8905a](0a8905a)) * Parse instance deployed event ([#4482](#4482)) ([62b171a](62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](#4486)) ([2082fed](2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ([4113cfd](4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (#4415) ([4113cfd](4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](#4483)) ([92d0aa4](92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](#4456)) ([83a3136](83a3136)) * Rename bigint_neg into bigint_sub (#4420) ([4113cfd](4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](902bbd4)) * Surpress chained macro warning (#4396) ([4113cfd](4113cfd)) * Sync to noir-lang/noir ([4113cfd](4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](#4467)) ([2c82b62](2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420) * Add expression width into acir (AztecProtocol/aztec-packages#4014) * init storage macro (AztecProtocol/aztec-packages#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](AztecProtocol/aztec-packages#4464)) ([5e16063](AztecProtocol/aztec-packages@5e16063)) * Add bit size to const opcode (AztecProtocol/aztec-packages#4385) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Add expression width into acir (AztecProtocol/aztec-packages#4014) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Allow brillig to read arrays directly from memory (AztecProtocol/aztec-packages#4460) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](AztecProtocol/aztec-packages#4478)) ([bbfa337](AztecProtocol/aztec-packages@bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (AztecProtocol/aztec-packages#4478) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **avm:** Back in avm context with macro - refactor context (AztecProtocol/aztec-packages#4438) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](AztecProtocol/aztec-packages#4441)) ([934fabc](AztecProtocol/aztec-packages@934fabc)), closes [#4304](AztecProtocol/aztec-packages#4304) * **avm:** Support variable size SET opcode ([#4465](AztecProtocol/aztec-packages#4465)) ([545b334](AztecProtocol/aztec-packages@545b334)) * **aztec-nr:** Initial work for aztec public vm macro (AztecProtocol/aztec-packages#4400) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **bb:** Op counting mode ([#4437](AztecProtocol/aztec-packages#4437)) ([5d00cff](AztecProtocol/aztec-packages@5d00cff)) * Canonical instance deployer contract ([#4436](AztecProtocol/aztec-packages#4436)) ([b4acc8c](AztecProtocol/aztec-packages@b4acc8c)) * Init storage macro (AztecProtocol/aztec-packages#4200) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Updating global vars with fees ([#4421](AztecProtocol/aztec-packages#4421)) ([34109eb](AztecProtocol/aztec-packages@34109eb)), closes [#3824](AztecProtocol/aztec-packages#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](AztecProtocol/aztec-packages#4474)) ([fabeac8](AztecProtocol/aztec-packages@fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](AztecProtocol/aztec-packages#4487)) ([e1d3f5a](AztecProtocol/aztec-packages@e1d3f5a)) * **docs:** Update mdx files to md ([#4459](AztecProtocol/aztec-packages#4459)) ([e67d94b](AztecProtocol/aztec-packages@e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](AztecProtocol/aztec-packages#4472)) ([0a8905a](AztecProtocol/aztec-packages@0a8905a)) * Parse instance deployed event ([#4482](AztecProtocol/aztec-packages#4482)) ([62b171a](AztecProtocol/aztec-packages@62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](AztecProtocol/aztec-packages#4486)) ([2082fed](AztecProtocol/aztec-packages@2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221) [skip ci] ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (AztecProtocol/aztec-packages#4415) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](AztecProtocol/aztec-packages#4483)) ([92d0aa4](AztecProtocol/aztec-packages@92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](AztecProtocol/aztec-packages#4456)) ([83a3136](AztecProtocol/aztec-packages@83a3136)) * Rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](AztecProtocol/aztec-packages@902bbd4)) * Surpress chained macro warning (AztecProtocol/aztec-packages#4396) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Sync to noir-lang/noir ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](AztecProtocol/aztec-packages#4467)) ([2c82b62](AztecProtocol/aztec-packages@2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](AztecProtocol/aztec-packages#4464)) ([5e16063](AztecProtocol/aztec-packages@5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](AztecProtocol/aztec-packages#4478)) ([bbfa337](AztecProtocol/aztec-packages@bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](AztecProtocol/aztec-packages#4441)) ([934fabc](AztecProtocol/aztec-packages@934fabc)), closes [#4304](AztecProtocol/aztec-packages#4304) * **bb:** Op counting mode ([#4437](AztecProtocol/aztec-packages#4437)) ([5d00cff](AztecProtocol/aztec-packages@5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Closes AztecProtocol#4267.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (AztecProtocol#4420) * Add expression width into acir (AztecProtocol#4014) * init storage macro (AztecProtocol#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([AztecProtocol#4464](AztecProtocol#4464)) ([5e16063](AztecProtocol@5e16063)) * Add bit size to const opcode (AztecProtocol#4385) ([4113cfd](AztecProtocol@4113cfd)) * Add expression width into acir (AztecProtocol#4014) ([4113cfd](AztecProtocol@4113cfd)) * Allow brillig to read arrays directly from memory (AztecProtocol#4460) ([4113cfd](AztecProtocol@4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([AztecProtocol#4478](AztecProtocol#4478)) ([bbfa337](AztecProtocol@bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (AztecProtocol#4478) ([4113cfd](AztecProtocol@4113cfd)) * **avm:** Back in avm context with macro - refactor context (AztecProtocol#4438) ([4113cfd](AztecProtocol@4113cfd)) * **avm:** Generic bytecode deserialization ([AztecProtocol#4441](AztecProtocol#4441)) ([934fabc](AztecProtocol@934fabc)), closes [AztecProtocol#4304](AztecProtocol#4304) * **avm:** Support variable size SET opcode ([AztecProtocol#4465](AztecProtocol#4465)) ([545b334](AztecProtocol@545b334)) * **aztec-nr:** Initial work for aztec public vm macro (AztecProtocol#4400) ([4113cfd](AztecProtocol@4113cfd)) * **bb:** Op counting mode ([AztecProtocol#4437](AztecProtocol#4437)) ([5d00cff](AztecProtocol@5d00cff)) * Canonical instance deployer contract ([AztecProtocol#4436](AztecProtocol#4436)) ([b4acc8c](AztecProtocol@b4acc8c)) * Init storage macro (AztecProtocol#4200) ([4113cfd](AztecProtocol@4113cfd)) * Updating global vars with fees ([AztecProtocol#4421](AztecProtocol#4421)) ([34109eb](AztecProtocol@34109eb)), closes [AztecProtocol#3824](AztecProtocol#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([AztecProtocol#4474](AztecProtocol#4474)) ([fabeac8](AztecProtocol@fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([AztecProtocol#4487](AztecProtocol#4487)) ([e1d3f5a](AztecProtocol@e1d3f5a)) * **docs:** Update mdx files to md ([AztecProtocol#4459](AztecProtocol#4459)) ([e67d94b](AztecProtocol@e67d94b)) * **docs:** Update private voting tutorial cli commands ([AztecProtocol#4472](AztecProtocol#4472)) ([0a8905a](AztecProtocol@0a8905a)) * Parse instance deployed event ([AztecProtocol#4482](AztecProtocol#4482)) ([62b171a](AztecProtocol@62b171a)) ### Miscellaneous * Able to run noir-sync manually ([AztecProtocol#4486](AztecProtocol#4486)) ([2082fed](AztecProtocol@2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol#4221) [skip ci] ([4113cfd](AztecProtocol@4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (AztecProtocol#4415) ([4113cfd](AztecProtocol@4113cfd)) * Lift rollup address check & deplot kv-store to npm ([AztecProtocol#4483](AztecProtocol#4483)) ([92d0aa4](AztecProtocol@92d0aa4)) * Nuked `OptionallyRevealedData` ([AztecProtocol#4456](AztecProtocol#4456)) ([83a3136](AztecProtocol@83a3136)) * Rename bigint_neg into bigint_sub (AztecProtocol#4420) ([4113cfd](AztecProtocol@4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](AztecProtocol@902bbd4)) * Surpress chained macro warning (AztecProtocol#4396) ([4113cfd](AztecProtocol@4113cfd)) * Sync to noir-lang/noir ([4113cfd](AztecProtocol@4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([AztecProtocol#4467](AztecProtocol#4467)) ([2c82b62](AztecProtocol@2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([AztecProtocol#4464](AztecProtocol#4464)) ([5e16063](AztecProtocol@5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([AztecProtocol#4478](AztecProtocol#4478)) ([bbfa337](AztecProtocol@bbfa337)) * **avm:** Generic bytecode deserialization ([AztecProtocol#4441](AztecProtocol#4441)) ([934fabc](AztecProtocol@934fabc)), closes [AztecProtocol#4304](AztecProtocol#4304) * **bb:** Op counting mode ([AztecProtocol#4437](AztecProtocol#4437)) ([5d00cff](AztecProtocol@5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

feat(avm): support variable size SET opcode

4ad7159

fcarreiro force-pushed the fc/avm-set-variable-size branch from 96097c4 to 4ad7159 Compare February 6, 2024 18:12

fcarreiro requested a review from dbanks12 February 6, 2024 18:13

fcarreiro marked this pull request as ready for review February 6, 2024 18:14

dbanks12 approved these changes Feb 6, 2024

View reviewed changes

dbanks12 merged commit 545b334 into master Feb 6, 2024
87 checks passed

dbanks12 deleted the fc/avm-set-variable-size branch February 6, 2024 18:54

AztecBot mentioned this pull request Feb 6, 2024

chore(master): Release 0.23.0 #4466

Merged

TomAFrench pushed a commit that referenced this pull request Feb 7, 2024

feat(avm): support variable size SET opcode (#4465)

b948616

Closes #4267.

michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024

feat(avm): support variable size SET opcode (AztecProtocol#4465)

f5eefb9

Closes AztecProtocol#4267.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): support variable size SET opcode #4465

feat(avm): support variable size SET opcode #4465

fcarreiro commented Feb 6, 2024 •

edited

Loading

fcarreiro commented Feb 6, 2024

AztecBot commented Feb 6, 2024

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

dbanks12 left a comment

dbanks12 Feb 6, 2024

feat(avm): support variable size SET opcode #4465

feat(avm): support variable size SET opcode #4465

Conversation

fcarreiro commented Feb 6, 2024 • edited Loading

fcarreiro commented Feb 6, 2024

AztecBot commented Feb 6, 2024

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

dbanks12 left a comment

Choose a reason for hiding this comment

dbanks12 Feb 6, 2024

Choose a reason for hiding this comment

fcarreiro commented Feb 6, 2024 •

edited

Loading