feat: Remove proof from L1 Rollup process #7347

spalladino · 2024-07-04T18:11:28Z

Moves the proof verification from Rollup.process and into a new submitProof method, called separately from the sequencer. Eventually we'll want to move it out of the sequencer completely, but this way we don't break the current e2e flow.

See #7346

spalladino · 2024-07-04T18:11:41Z

feat: Remove proof from L1 Rollup process #7347 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spalladino and the rest of your teammates on Graphite

AztecBot · 2024-07-04T18:51:11Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (Token:assert_minter_and_mint): 65.0 (+60%)
avm_simulation_time_ms (Token:_increase_public_balance): 15.2 (-77%)
avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 160 (+43%)
app_circuit_proving_time_in_ms (Token:transfer_public (avm)): 3,623 (-16%)
l1_rollup_calldata_gas (4): 6,588 (-30%)
l1_rollup_calldata_gas (8): 6,590 (-30%)
l1_rollup_calldata_gas (16): 6,588 (-30%)
l1_rollup_calldata_size_in_bytes (4): 708 (-50%)
l1_rollup_calldata_size_in_bytes (8): 708 (-50%)
l1_rollup_calldata_size_in_bytes (16): 708 (-50%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,709 (-1%)	1,534 (-1%)	703	737 (-2%)	768 (-1%)
proof_construction_time_sha256_30_ms	11,686 (-1%)	3,136 (-1%)	1,410	1,421 (-2%)	1,462
proof_construction_time_sha256_100_ms	43,675 (-1%)	11,739 (-1%)	6,201 (+14%)	5,386	5,319 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	60.0 (+3%)	89.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,515 (-1%)	416	199	223 (-1%)	270 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,604 (-1%)	1,511 (-1%)	684 (+1%)	731	745 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	⚠️ 708 (-50%)	⚠️ 708 (-50%)	⚠️ 708 (-50%)
l1_rollup_calldata_gas	⚠️ 6,588 (-30%)	⚠️ 6,590 (-30%)	⚠️ 6,588 (-30%)
l1_rollup_execution_gas	583,050 (-5%)	583,203 (-5%)	583,352 (-5%)
l2_block_processing_time_in_ms	757 (+1%)	1,442 (+1%)	2,679
l2_block_building_time_in_ms	12,972 (-1%)	25,526 (-1%)	51,146 (+1%)
l2_block_rollup_simulation_time_in_ms	12,972 (-1%)	25,526 (-1%)	51,146 (+1%)
l2_block_public_tx_process_time_in_ms	10,916 (-2%)	23,304 (-1%)	48,875 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,133	10,039 (+1%)
node_database_size_in_bytes	12,460,112	16,236,624
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	109	427 (-2%)	13,724 (-1%)	20,002	55,022	76,256	2,316	524,288
private-kernel-inner	227	765	48,999 (+5%)	82,134	55,022	76,256	2,316	2,097,152
private-kernel-tail	1,059 (-1%)	2,530	44,570	62,409	62,089	14,944	400	2,097,152
base-parity	6.37 (-1%)	944 (+5%)	2,452	160	96.0	2,240	3.00	131,072
root-parity	70.4 (-1%)	67.4 (+10%)	34,088 (+1%)	27,868	96.0	2,752	19.0	2,097,152
base-rollup	4,166	5,056 (-1%)	78,783	172,028	632	3,552	44.0	4,194,304
root-rollup	128 (-1%)	76.5	19,693 (+1%)	25,053	652	3,488	42.0	1,048,576
public-kernel-setup	192	2,332	36,638	103,911	80,310	108,992	3,339	2,097,152
public-kernel-app-logic	148 (-1%)	3,273 (-1%)	37,241 (-1%)	103,911	80,310	108,992	3,339	2,097,152
public-kernel-tail	895 (-1%)	23,695	157,035 (+1%)	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	292	1,134 (-4%)	28,400 (+1%)	79,273	55,022	76,256	2,316	1,048,576
public-kernel-teardown	137	3,256 (-1%)	37,235 (+2%)	103,911	80,310	108,992	3,339	2,097,152
merge-rollup	40.0 (-1%)	N/A	N/A	16,094	632	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,742 (+1%)	48,867	N/A	N/A	108,992	3,339	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,312	9,344	395 (-1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	25.4	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	625 (-1%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,344	9,344	576 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	436	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	779 (+1%)	16,352	4,910 (-2%)	131,072	444
Token:privately_mint_private_note	1,248	9,344	519 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	105 (-4%)	16,352	1,902	65,536	444
Token:transfer	1,280	9,344	1,615	16,352	10,437 (-2%)	524,288	444
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	91,232	1,609 (-8%)	N/A	N/A
FPC:prepare_fee (avm)	26,664	N/A	N/A	91,296	3,012 (+1%)	N/A	N/A
Token:transfer_public (avm)	42,914	N/A	N/A	91,296	⚠️ 3,623 (-16%)	N/A	N/A
AuthRegistry:consume (avm)	33,100	N/A	N/A	91,232	2,886 (-4%)	N/A	N/A
FPC:pay_refund (avm)	36,829	N/A	N/A	91,264	17,736 (-2%)	N/A	N/A
Benchmarking:create_note	1,312	9,344	429 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	41.8	N/A	N/A	N/A	N/A
Token:unshield	1,344	9,344	1,325 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,694	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	78.3	13,790
GasToken:set_portal	12.4 (+10%)	3,339
Token:constructor	102	23,692
FPC:constructor	72.6 (+1%)	13,592
GasToken:mint_public	65.3 (-2%)	10,158
Token:mint_public	385 (+6%)	19,034
Token:assert_minter_and_mint	⚠️ 65.0 (+60%)	12,925
AuthRegistry:set_authorized	33.8 (-15%)	7,812
FPC:prepare_fee	100 (+2%)	15,062
Token:transfer_public	44.0 (-7%)	31,218
FPC:pay_refund	126 (-2%)	25,260
Benchmarking:increment_balance	1,328	15,267
Token:_increase_public_balance	⚠️ 15.2 (-77%)	15,006
FPC:pay_refund_with_shielded_rebate	⚠️ 160 (+43%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.151

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.605	0.516	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.5	75.6	131	246	466 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.496	0.465	0.450	0.447	0.437
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.1	111 (-1%)	182	354	689
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.508	0.500 (-1%)	0.484	0.480	0.474
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.523	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,105	667,868

Transaction size based on fee payment method

| Metric | |
| - | |

spalladino · 2024-07-08T14:44:58Z

Rolling back to draft so we include the submitProof method in L1 in this PR as well, so as not to break the e2e.

spalladino · 2024-07-08T22:11:28Z

Do not merge until @ludamad has approved!

alexghr

LGTM. I'll let @ludamad approve & merge this in.

alexghr · 2024-07-09T11:35:31Z

l1-contracts/src/core/Rollup.sol

+    bytes calldata _aggregationObject,
+    bytes calldata _proof
+  ) external override(IRollup) {
+    HeaderLib.Header memory header = HeaderLib.decode(_header);


I think submitProof should also verify the block it's verifying is available on L1 🤔

Yeah, submitProof is missing a lot of checks. I just wanted to get something working for now.

alexghr · 2024-07-09T11:37:55Z

l1-contracts/src/core/Rollup.sol

+    OUTBOX.insert(
+      header.globalVariables.blockNumber, header.contentCommitment.outHash, l2ToL1TreeMinHeight
+    );
+
+    // pay the coinbase 1 gas token if it is not empty and header.totalFees is not zero
+    if (header.globalVariables.coinbase != address(0) && header.totalFees > 0) {
+      GAS_TOKEN.transfer(address(header.globalVariables.coinbase), header.totalFees);
+    }


Hmm, shouldn't this go out only after the block is proven (to avoid the block being reverted due to missing proof)? If that's the case, I'd add a note/todo about it

It's one of the items I got on the design doc, yep. Fee payment will have to change quite a lot.

Batch proof for multiple blocks will be uploaded separately. Related to #7346

spalladino · 2024-07-10T14:03:19Z

Got confirmation from ludamad on being good to merge

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.3</summary> ## [0.46.3](aztec-package-v0.46.2...aztec-package-v0.46.3) (2024-07-11) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.3</summary> ## [0.46.3](barretenberg.js-v0.46.2...barretenberg.js-v0.46.3) (2024-07-11) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.3</summary> ## [0.46.3](aztec-packages-v0.46.2...aztec-packages-v0.46.3) (2024-07-11) ### Features * Add CLI argument for debugging comptime blocks (noir-lang/noir#5192) ([97ecff5](97ecff5)) * Add reset tiny and optimize tail ([#7422](#7422)) ([399917b](399917b)) * **avm:** Calldatacopy and return gadget ([#7415](#7415)) ([ec39e4e](ec39e4e)), closes [#7381](#7381) [#7211](#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](#7419)) ([108fc5f](108fc5f)) * Integrate new proving systems in e2e ([#6971](#6971)) ([723a0c1](723a0c1)) * Lsp rename/find-all-references for struct members (noir-lang/noir#5443) ([97ecff5](97ecff5)) * MSM sorting ([#7351](#7351)) ([5cbdc54](5cbdc54)) * **optimization:** Deduplicate more instructions (noir-lang/noir#5457) ([97ecff5](97ecff5)) * Prefix operator overload trait dispatch (noir-lang/noir#5423) ([97ecff5](97ecff5)) * Remove proof from L1 Rollup process ([#7347](#7347)) ([2645eab](2645eab)), closes [#7346](#7346) * Remove ram tables in note_getter ([#7434](#7434)) ([fd67da3](fd67da3)) * Sync from aztec-packages (noir-lang/noir#5467) ([97ecff5](97ecff5)) * Typing return values of embedded_curve_ops ([#7413](#7413)) ([db96077](db96077)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](#7438)) ([2a7494b](2a7494b)) * Memory init with no other ops gate counting ([#7427](#7427)) ([e7177ba](e7177ba)) * Pass secrets to ci-arm.yml ([#7436](#7436)) ([619501d](619501d)) * Remove compile-time error for invalid indices (noir-lang/noir#5466) ([97ecff5](97ecff5)) * Using different generators in private refund ([#7414](#7414)) ([59b92ca](59b92ca)), closes [#7320](#7320) ### Miscellaneous * **bb:** Fix double increment ([#7428](#7428)) ([7870a58](7870a58)) * **boxes:** Adding an init command for an empty project ([#7398](#7398)) ([a6a605d](a6a605d)) * Bump bb to 0.45.1 (noir-lang/noir#5469) ([97ecff5](97ecff5)) * Disable flaky cheat code test ([7b8c2ba](7b8c2ba)) * Document EmbeddedCurvePoint (noir-lang/noir#5468) ([97ecff5](97ecff5)) * Minimize usage of get_row in inverse computation ([#7431](#7431)) ([f177887](f177887)) * Private refund cleanup ([#7403](#7403)) ([ebec8ff](ebec8ff)) * Replace relative paths to noir-protocol-circuits ([842f6d1](842f6d1)) * Unbundle `check_array_is_initialized` (noir-lang/noir#5451) ([97ecff5](97ecff5)) </details> <details><summary>barretenberg: 0.46.3</summary> ## [0.46.3](barretenberg-v0.46.2...barretenberg-v0.46.3) (2024-07-11) ### Features * **avm:** Calldatacopy and return gadget ([#7415](#7415)) ([ec39e4e](ec39e4e)), closes [#7381](#7381) [#7211](#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](#7419)) ([108fc5f](108fc5f)) * Integrate new proving systems in e2e ([#6971](#6971)) ([723a0c1](723a0c1)) * MSM sorting ([#7351](#7351)) ([5cbdc54](5cbdc54)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](#7438)) ([2a7494b](2a7494b)) * Memory init with no other ops gate counting ([#7427](#7427)) ([e7177ba](e7177ba)) ### Miscellaneous * **bb:** Fix double increment ([#7428](#7428)) ([7870a58](7870a58)) * Minimize usage of get_row in inverse computation ([#7431](#7431)) ([f177887](f177887)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@aztec-package-v0.46.2...aztec-package-v0.46.3) (2024-07-11) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@barretenberg.js-v0.46.2...barretenberg.js-v0.46.3) (2024-07-11) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@aztec-packages-v0.46.2...aztec-packages-v0.46.3) (2024-07-11) ### Features * Add CLI argument for debugging comptime blocks (noir-lang/noir#5192) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Add reset tiny and optimize tail ([#7422](AztecProtocol/aztec-packages#7422)) ([399917b](AztecProtocol/aztec-packages@399917b)) * **avm:** Calldatacopy and return gadget ([#7415](AztecProtocol/aztec-packages#7415)) ([ec39e4e](AztecProtocol/aztec-packages@ec39e4e)), closes [#7381](AztecProtocol/aztec-packages#7381) [#7211](AztecProtocol/aztec-packages#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](AztecProtocol/aztec-packages#7419)) ([108fc5f](AztecProtocol/aztec-packages@108fc5f)) * Integrate new proving systems in e2e ([#6971](AztecProtocol/aztec-packages#6971)) ([723a0c1](AztecProtocol/aztec-packages@723a0c1)) * Lsp rename/find-all-references for struct members (noir-lang/noir#5443) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * MSM sorting ([#7351](AztecProtocol/aztec-packages#7351)) ([5cbdc54](AztecProtocol/aztec-packages@5cbdc54)) * **optimization:** Deduplicate more instructions (noir-lang/noir#5457) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Prefix operator overload trait dispatch (noir-lang/noir#5423) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Remove proof from L1 Rollup process ([#7347](AztecProtocol/aztec-packages#7347)) ([2645eab](AztecProtocol/aztec-packages@2645eab)), closes [#7346](AztecProtocol/aztec-packages#7346) * Remove ram tables in note_getter ([#7434](AztecProtocol/aztec-packages#7434)) ([fd67da3](AztecProtocol/aztec-packages@fd67da3)) * Sync from aztec-packages (noir-lang/noir#5467) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Typing return values of embedded_curve_ops ([#7413](AztecProtocol/aztec-packages#7413)) ([db96077](AztecProtocol/aztec-packages@db96077)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](AztecProtocol/aztec-packages#7438)) ([2a7494b](AztecProtocol/aztec-packages@2a7494b)) * Memory init with no other ops gate counting ([#7427](AztecProtocol/aztec-packages#7427)) ([e7177ba](AztecProtocol/aztec-packages@e7177ba)) * Pass secrets to ci-arm.yml ([#7436](AztecProtocol/aztec-packages#7436)) ([619501d](AztecProtocol/aztec-packages@619501d)) * Remove compile-time error for invalid indices (noir-lang/noir#5466) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Using different generators in private refund ([#7414](AztecProtocol/aztec-packages#7414)) ([59b92ca](AztecProtocol/aztec-packages@59b92ca)), closes [#7320](AztecProtocol/aztec-packages#7320) ### Miscellaneous * **bb:** Fix double increment ([#7428](AztecProtocol/aztec-packages#7428)) ([7870a58](AztecProtocol/aztec-packages@7870a58)) * **boxes:** Adding an init command for an empty project ([#7398](AztecProtocol/aztec-packages#7398)) ([a6a605d](AztecProtocol/aztec-packages@a6a605d)) * Bump bb to 0.45.1 (noir-lang/noir#5469) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Disable flaky cheat code test ([7b8c2ba](AztecProtocol/aztec-packages@7b8c2ba)) * Document EmbeddedCurvePoint (noir-lang/noir#5468) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Minimize usage of get_row in inverse computation ([#7431](AztecProtocol/aztec-packages#7431)) ([f177887](AztecProtocol/aztec-packages@f177887)) * Private refund cleanup ([#7403](AztecProtocol/aztec-packages#7403)) ([ebec8ff](AztecProtocol/aztec-packages@ebec8ff)) * Replace relative paths to noir-protocol-circuits ([842f6d1](AztecProtocol/aztec-packages@842f6d1)) * Unbundle `check_array_is_initialized` (noir-lang/noir#5451) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) </details> <details><summary>barretenberg: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@barretenberg-v0.46.2...barretenberg-v0.46.3) (2024-07-11) ### Features * **avm:** Calldatacopy and return gadget ([#7415](AztecProtocol/aztec-packages#7415)) ([ec39e4e](AztecProtocol/aztec-packages@ec39e4e)), closes [#7381](AztecProtocol/aztec-packages#7381) [#7211](AztecProtocol/aztec-packages#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](AztecProtocol/aztec-packages#7419)) ([108fc5f](AztecProtocol/aztec-packages@108fc5f)) * Integrate new proving systems in e2e ([#6971](AztecProtocol/aztec-packages#6971)) ([723a0c1](AztecProtocol/aztec-packages@723a0c1)) * MSM sorting ([#7351](AztecProtocol/aztec-packages#7351)) ([5cbdc54](AztecProtocol/aztec-packages@5cbdc54)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](AztecProtocol/aztec-packages#7438)) ([2a7494b](AztecProtocol/aztec-packages@2a7494b)) * Memory init with no other ops gate counting ([#7427](AztecProtocol/aztec-packages#7427)) ([e7177ba](AztecProtocol/aztec-packages@e7177ba)) ### Miscellaneous * **bb:** Fix double increment ([#7428](AztecProtocol/aztec-packages#7428)) ([7870a58](AztecProtocol/aztec-packages@7870a58)) * Minimize usage of get_row in inverse computation ([#7431](AztecProtocol/aztec-packages#7431)) ([f177887](AztecProtocol/aztec-packages@f177887)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

spalladino force-pushed the palla/remove-proof-from-l1 branch from 7649853 to 22c64f8 Compare July 8, 2024 12:53

spalladino marked this pull request as draft July 8, 2024 14:44

spalladino force-pushed the palla/remove-proof-from-l1 branch from 77c0647 to d8b2518 Compare July 8, 2024 19:54

spalladino marked this pull request as ready for review July 8, 2024 22:09

spalladino requested review from alexghr and ludamad and removed request for alexghr July 8, 2024 22:09

spalladino enabled auto-merge (squash) July 8, 2024 22:10

spalladino disabled auto-merge July 8, 2024 22:11

alexghr reviewed Jul 9, 2024

View reviewed changes

spalladino added 6 commits July 10, 2024 09:38

feat: Remove proof from L1 Rollup process

6f72f49

Batch proof for multiple blocks will be uploaded separately. Related to #7346

Fix formatting

f335a1e

Fix tests

d21d8c0

Lint

c2a7115

Recreate submitProof method and have sequencer push to it

3772971

Fix

e160151

spalladino force-pushed the palla/remove-proof-from-l1 branch from 321306e to e160151 Compare July 10, 2024 12:38

Extra logs

2ed3cad

spalladino enabled auto-merge (squash) July 10, 2024 14:03

alexghr approved these changes Jul 10, 2024

View reviewed changes

spalladino merged commit 2645eab into master Jul 10, 2024
91 checks passed

spalladino deleted the palla/remove-proof-from-l1 branch July 10, 2024 14:03

AztecBot mentioned this pull request Jul 10, 2024

chore(master): Release 0.46.3 #7423

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Remove proof from L1 Rollup process #7347

feat: Remove proof from L1 Rollup process #7347

spalladino commented Jul 4, 2024 •

edited

Loading

spalladino commented Jul 4, 2024

AztecBot commented Jul 4, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

spalladino commented Jul 8, 2024

spalladino commented Jul 8, 2024

alexghr left a comment

alexghr Jul 9, 2024

spalladino Jul 10, 2024

alexghr Jul 9, 2024

spalladino Jul 10, 2024

spalladino commented Jul 10, 2024

feat: Remove proof from L1 Rollup process #7347

feat: Remove proof from L1 Rollup process #7347

Conversation

spalladino commented Jul 4, 2024 • edited Loading

spalladino commented Jul 4, 2024

AztecBot commented Jul 4, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

spalladino commented Jul 8, 2024

spalladino commented Jul 8, 2024

alexghr left a comment

Choose a reason for hiding this comment

alexghr Jul 9, 2024

Choose a reason for hiding this comment

spalladino Jul 10, 2024

Choose a reason for hiding this comment

alexghr Jul 9, 2024

Choose a reason for hiding this comment

spalladino Jul 10, 2024

Choose a reason for hiding this comment

spalladino commented Jul 10, 2024

spalladino commented Jul 4, 2024 •

edited

Loading

AztecBot commented Jul 4, 2024 •

edited

Loading