Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added bb to noir-projects deps #7412

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: added bb to noir-projects deps #7412

merged 1 commit into from
Jul 10, 2024

Conversation

Thunkar
Copy link
Contributor

@Thunkar Thunkar commented Jul 10, 2024

No description provided.

@Thunkar Thunkar self-assigned this Jul 10, 2024
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • avm_simulation_time_ms (Token:mint_public): 47.1 (-87%)
  • avm_simulation_time_ms (Token:assert_minter_and_mint): 93.9 (+43%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,715 1,543 702 742 (+1%) 768
proof_construction_time_sha256_30_ms 11,743 3,141 1,401 (-1%) 1,428 1,458 (-1%)
proof_construction_time_sha256_100_ms 43,798 11,747 5,645 (+4%) 5,388 5,386
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 59.0 87.0
proof_construction_time_poseidon_hash_30_ms 1,515 415 199 222 (+1%) 276 (+3%)
proof_construction_time_poseidon_hash_100_ms 5,612 1,514 677 (-1%) 743 (+5%) 739 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,464 9,466 9,452
l1_rollup_execution_gas 613,492 613,645 613,782
l2_block_processing_time_in_ms 754 1,426 2,708 (+1%)
l2_block_building_time_in_ms 12,961 25,791 50,307
l2_block_rollup_simulation_time_in_ms 12,961 25,791 50,306
l2_block_public_tx_process_time_in_ms 10,906 23,511 48,070

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 7,088 10,032 (+1%)
node_database_size_in_bytes 12,431,440 16,216,144
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 109 (-1%) 427 (-1%) 15,096 (+6%) 20,002 55,022 76,256 2,316 524,288
private-kernel-inner 225 (-1%) 845 (+10%) 47,093 (-1%) 82,134 55,022 76,256 2,316 2,097,152
private-kernel-tail 1,046 (-2%) 2,534 (-1%) 44,640 62,409 62,089 14,944 400 2,097,152
base-parity 6.37 (-1%) 896 (-1%) 2,430 160 96.0 2,240 3.00 131,072
root-parity 70.9 (-1%) 62.0 (-7%) 34,146 27,868 96.0 2,752 19.0 2,097,152
base-rollup 4,172 4,975 (-2%) 77,585 (-1%) 172,028 632 3,552 44.0 4,194,304
root-rollup 129 (-1%) 76.9 (+1%) 19,570 (-1%) 25,053 652 3,488 42.0 1,048,576
public-kernel-setup 192 2,336 36,346 (-1%) 103,911 80,310 108,992 3,339 2,097,152
public-kernel-app-logic 148 (-1%) 3,225 (-3%) 36,713 (-1%) 103,911 80,310 108,992 3,339 2,097,152
public-kernel-tail 898 (-1%) 25,446 (-1%) 154,909 (-3%) 400,808 10,046 14,944 400 8,388,608
private-kernel-reset-small 292 1,178 (-1%) 28,850 (+1%) 79,273 55,022 76,256 2,316 1,048,576
public-kernel-teardown 142 (+4%) 3,344 (-1%) 36,631 (-1%) 103,911 80,310 108,992 3,339 2,097,152
merge-rollup 40.8 (+1%) N/A N/A 16,094 632 N/A N/A N/A
private-kernel-tail-to-public N/A 8,968 (+3%) 48,615 (-1%) N/A N/A 108,992 3,339 2,097,152

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,312 9,344 399 (+1%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,376 9,344 25.6 (+1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,888 9,344 669 N/A N/A N/A N/A
GasToken:deploy 1,344 9,344 574 N/A N/A N/A N/A
SchnorrAccount:constructor 1,280 9,344 511 N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,272 9,344 867 (+1%) 16,352 4,620 (-11%) 131,072 444
Token:privately_mint_private_note 1,248 9,344 593 N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,312 9,344 108 (+3%) 16,352 1,923 65,536 444
Token:transfer 1,280 9,344 1,755 (+1%) 16,352 11,105 (+3%) 524,288 444
AuthRegistry:set_authorized (avm) 19,222 N/A N/A 91,232 1,683 (-1%) N/A N/A
FPC:prepare_fee (avm) 26,664 N/A N/A 91,296 2,949 (-4%) N/A N/A
Token:transfer_public (avm) 42,914 N/A N/A 91,296 3,775 (-2%) N/A N/A
AuthRegistry:consume (avm) 33,100 N/A N/A 91,232 2,947 (-2%) N/A N/A
FPC:pay_refund (avm) 36,829 N/A N/A 91,264 18,097 (-6%) N/A N/A
Benchmarking:create_note 1,312 9,344 490 N/A N/A N/A N/A
SchnorrAccount:verify_private_authwit 1,248 9,344 41.5 N/A N/A N/A N/A
Token:unshield 1,344 9,344 1,390 (-1%) N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,344 9,344 1,808 (-1%) N/A N/A N/A N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
GasToken:_increase_public_balance 79.2 (-3%) 13,790
GasToken:set_portal 12.2 (-2%) 3,339
Token:constructor 103 (-7%) 23,692
FPC:constructor 72.8 13,592
GasToken:mint_public 61.5 (-7%) 10,158
Token:mint_public ⚠️ 47.1 (-87%) 19,034
Token:assert_minter_and_mint ⚠️ 93.9 (+43%) 12,925
AuthRegistry:set_authorized 35.5 (-3%) 7,812
FPC:prepare_fee 104 (-3%) 15,062
Token:transfer_public 37.2 (+25%) 31,218
FPC:pay_refund 127 (-7%) 25,260
Benchmarking:increment_balance 1,329 15,267
Token:_increase_public_balance 15.4 (-4%) 15,006
FPC:pay_refund_with_shielded_rebate 162 (-5%) 26,347

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.147 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.4 16.8 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.604 0.516 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.3 75.6 131 246 470
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.494 0.464 0.449 0.446 0.439
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 59.7 112 182 (+1%) 358 (+1%) 692
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.505 0.501 0.483 (+1%) 0.485 (+1%) 0.475
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 73.1 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 133 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.521 N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 74,105 667,868

Transaction size based on fee payment method

| Metric | |
| - | |

@Thunkar Thunkar merged commit 6d3ed3a into master Jul 10, 2024
91 checks passed
@Thunkar Thunkar deleted the gj/circleci_dep branch July 10, 2024 08:35
Thunkar pushed a commit that referenced this pull request Jul 10, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.46.1</summary>

##
[0.46.1](aztec-package-v0.46.0...aztec-package-v0.46.1)
(2024-07-10)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.46.1</summary>

##
[0.46.1](barretenberg.js-v0.46.0...barretenberg.js-v0.46.1)
(2024-07-10)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.46.1</summary>

##
[0.46.1](aztec-packages-v0.46.0...aztec-packages-v0.46.1)
(2024-07-10)


### Features

* Apply `no_predicates` in stdlib
(noir-lang/noir#5454)
([6237d96](6237d96))
* Lsp rename/find-all-references for globals
(noir-lang/noir#5415)
([6237d96](6237d96))
* Lsp rename/find-all-references for local variables
(noir-lang/noir#5439)
([6237d96](6237d96))
* Remove duplicated array reads at constant indices
(noir-lang/noir#5445)
([6237d96](6237d96))
* Remove redundant `EnableSideEffects` instructions
(noir-lang/noir#5440)
([6237d96](6237d96))


### Bug Fixes

* Account for the expected kind when resolving turbofish generics
(noir-lang/noir#5448)
([6237d96](6237d96))
* Added bb to noir-projects deps
([#7412](#7412))
([6d3ed3a](6d3ed3a))
* Fix issue with unresolved results
(noir-lang/noir#5453)
([6237d96](6237d96))
* Prevent `no_predicates` from removing predicates in calling function
(noir-lang/noir#5452)
([6237d96](6237d96))


### Miscellaneous

* Replace relative paths to noir-protocol-circuits
([db45302](db45302))
* Replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint`
([#7382](#7382))
([5279695](5279695))
* Replace usage of `GrumpkinPrivateKey` with `EmbeddedCurveScalar`
([#7384](#7384))
([a917198](a917198))
</details>

<details><summary>barretenberg: 0.46.1</summary>

##
[0.46.1](barretenberg-v0.46.0...barretenberg-v0.46.1)
(2024-07-10)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Jul 11, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.46.1</summary>

##
[0.46.1](AztecProtocol/aztec-packages@aztec-package-v0.46.0...aztec-package-v0.46.1)
(2024-07-10)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.46.1</summary>

##
[0.46.1](AztecProtocol/aztec-packages@barretenberg.js-v0.46.0...barretenberg.js-v0.46.1)
(2024-07-10)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.46.1</summary>

##
[0.46.1](AztecProtocol/aztec-packages@aztec-packages-v0.46.0...aztec-packages-v0.46.1)
(2024-07-10)


### Features

* Apply `no_predicates` in stdlib
(noir-lang/noir#5454)
([6237d96](AztecProtocol/aztec-packages@6237d96))
* Lsp rename/find-all-references for globals
(noir-lang/noir#5415)
([6237d96](AztecProtocol/aztec-packages@6237d96))
* Lsp rename/find-all-references for local variables
(noir-lang/noir#5439)
([6237d96](AztecProtocol/aztec-packages@6237d96))
* Remove duplicated array reads at constant indices
(noir-lang/noir#5445)
([6237d96](AztecProtocol/aztec-packages@6237d96))
* Remove redundant `EnableSideEffects` instructions
(noir-lang/noir#5440)
([6237d96](AztecProtocol/aztec-packages@6237d96))


### Bug Fixes

* Account for the expected kind when resolving turbofish generics
(noir-lang/noir#5448)
([6237d96](AztecProtocol/aztec-packages@6237d96))
* Added bb to noir-projects deps
([#7412](AztecProtocol/aztec-packages#7412))
([6d3ed3a](AztecProtocol/aztec-packages@6d3ed3a))
* Fix issue with unresolved results
(noir-lang/noir#5453)
([6237d96](AztecProtocol/aztec-packages@6237d96))
* Prevent `no_predicates` from removing predicates in calling function
(noir-lang/noir#5452)
([6237d96](AztecProtocol/aztec-packages@6237d96))


### Miscellaneous

* Replace relative paths to noir-protocol-circuits
([db45302](AztecProtocol/aztec-packages@db45302))
* Replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint`
([#7382](AztecProtocol/aztec-packages#7382))
([5279695](AztecProtocol/aztec-packages@5279695))
* Replace usage of `GrumpkinPrivateKey` with `EmbeddedCurveScalar`
([#7384](AztecProtocol/aztec-packages#7384))
([a917198](AztecProtocol/aztec-packages@a917198))
</details>

<details><summary>barretenberg: 0.46.1</summary>

##
[0.46.1](AztecProtocol/aztec-packages@barretenberg-v0.46.0...barretenberg-v0.46.1)
(2024-07-10)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants