-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Account for the expected kind when resolving turbofish generics #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2' into mv/turbofish-num-generic-fix-5442
jfecher
requested changes
Jul 9, 2024
Co-authored-by: jfecher <jake@aztecprotocol.com>
Co-authored-by: jfecher <jake@aztecprotocol.com>
jfecher
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 10, 2024
…oir-lang/noir#5439) feat: remove duplicated array reads at constant indices (noir-lang/noir#5445) fix: Account for the expected kind when resolving turbofish generics (noir-lang/noir#5448) fix: Fix issue with unresolved results (noir-lang/noir#5453) feat: apply `no_predicates` in stdlib (noir-lang/noir#5454) fix: prevent `no_predicates` from removing predicates in calling function (noir-lang/noir#5452) feat: lsp rename/find-all-references for globals (noir-lang/noir#5415) feat: remove redundant `EnableSideEffects` instructions (noir-lang/noir#5440)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 10, 2024
…oir#5439) feat: remove duplicated array reads at constant indices (noir-lang/noir#5445) fix: Account for the expected kind when resolving turbofish generics (noir-lang/noir#5448) fix: Fix issue with unresolved results (noir-lang/noir#5453) feat: apply `no_predicates` in stdlib (noir-lang/noir#5454) fix: prevent `no_predicates` from removing predicates in calling function (noir-lang/noir#5452) feat: lsp rename/find-all-references for globals (noir-lang/noir#5415) feat: remove redundant `EnableSideEffects` instructions (noir-lang/noir#5440)
sirasistant
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 10, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: lsp rename/find-all-references for local variables (noir-lang/noir#5439) feat: remove duplicated array reads at constant indices (noir-lang/noir#5445) fix: Account for the expected kind when resolving turbofish generics (noir-lang/noir#5448) fix: Fix issue with unresolved results (noir-lang/noir#5453) feat: apply `no_predicates` in stdlib (noir-lang/noir#5454) fix: prevent `no_predicates` from removing predicates in calling function (noir-lang/noir#5452) feat: lsp rename/find-all-references for globals (noir-lang/noir#5415) feat: remove redundant `EnableSideEffects` instructions (noir-lang/noir#5440) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch> Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
Thunkar
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 10, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.1</summary> ## [0.46.1](aztec-package-v0.46.0...aztec-package-v0.46.1) (2024-07-10) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.1</summary> ## [0.46.1](barretenberg.js-v0.46.0...barretenberg.js-v0.46.1) (2024-07-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.1</summary> ## [0.46.1](aztec-packages-v0.46.0...aztec-packages-v0.46.1) (2024-07-10) ### Features * Apply `no_predicates` in stdlib (noir-lang/noir#5454) ([6237d96](6237d96)) * Lsp rename/find-all-references for globals (noir-lang/noir#5415) ([6237d96](6237d96)) * Lsp rename/find-all-references for local variables (noir-lang/noir#5439) ([6237d96](6237d96)) * Remove duplicated array reads at constant indices (noir-lang/noir#5445) ([6237d96](6237d96)) * Remove redundant `EnableSideEffects` instructions (noir-lang/noir#5440) ([6237d96](6237d96)) ### Bug Fixes * Account for the expected kind when resolving turbofish generics (noir-lang/noir#5448) ([6237d96](6237d96)) * Added bb to noir-projects deps ([#7412](#7412)) ([6d3ed3a](6d3ed3a)) * Fix issue with unresolved results (noir-lang/noir#5453) ([6237d96](6237d96)) * Prevent `no_predicates` from removing predicates in calling function (noir-lang/noir#5452) ([6237d96](6237d96)) ### Miscellaneous * Replace relative paths to noir-protocol-circuits ([db45302](db45302)) * Replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` ([#7382](#7382)) ([5279695](5279695)) * Replace usage of `GrumpkinPrivateKey` with `EmbeddedCurveScalar` ([#7384](#7384)) ([a917198](a917198)) </details> <details><summary>barretenberg: 0.46.1</summary> ## [0.46.1](barretenberg-v0.46.0...barretenberg-v0.46.1) (2024-07-10) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.1</summary> ## [0.46.1](AztecProtocol/aztec-packages@aztec-package-v0.46.0...aztec-package-v0.46.1) (2024-07-10) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.1</summary> ## [0.46.1](AztecProtocol/aztec-packages@barretenberg.js-v0.46.0...barretenberg.js-v0.46.1) (2024-07-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.1</summary> ## [0.46.1](AztecProtocol/aztec-packages@aztec-packages-v0.46.0...aztec-packages-v0.46.1) (2024-07-10) ### Features * Apply `no_predicates` in stdlib (noir-lang/noir#5454) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Lsp rename/find-all-references for globals (noir-lang/noir#5415) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Lsp rename/find-all-references for local variables (noir-lang/noir#5439) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Remove duplicated array reads at constant indices (noir-lang/noir#5445) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Remove redundant `EnableSideEffects` instructions (noir-lang/noir#5440) ([6237d96](AztecProtocol/aztec-packages@6237d96)) ### Bug Fixes * Account for the expected kind when resolving turbofish generics (noir-lang/noir#5448) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Added bb to noir-projects deps ([#7412](AztecProtocol/aztec-packages#7412)) ([6d3ed3a](AztecProtocol/aztec-packages@6d3ed3a)) * Fix issue with unresolved results (noir-lang/noir#5453) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Prevent `no_predicates` from removing predicates in calling function (noir-lang/noir#5452) ([6237d96](AztecProtocol/aztec-packages@6237d96)) ### Miscellaneous * Replace relative paths to noir-protocol-circuits ([db45302](AztecProtocol/aztec-packages@db45302)) * Replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` ([#7382](AztecProtocol/aztec-packages#7382)) ([5279695](AztecProtocol/aztec-packages@5279695)) * Replace usage of `GrumpkinPrivateKey` with `EmbeddedCurveScalar` ([#7384](AztecProtocol/aztec-packages#7384)) ([a917198](AztecProtocol/aztec-packages@a917198)) </details> <details><summary>barretenberg: 0.46.1</summary> ## [0.46.1](AztecProtocol/aztec-packages@barretenberg-v0.46.0...barretenberg-v0.46.1) (2024-07-10) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Jul 11, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: lsp rename/find-all-references for local variables (noir-lang/noir#5439) feat: remove duplicated array reads at constant indices (noir-lang/noir#5445) fix: Account for the expected kind when resolving turbofish generics (noir-lang/noir#5448) fix: Fix issue with unresolved results (noir-lang/noir#5453) feat: apply `no_predicates` in stdlib (noir-lang/noir#5454) fix: prevent `no_predicates` from removing predicates in calling function (noir-lang/noir#5452) feat: lsp rename/find-all-references for globals (noir-lang/noir#5415) feat: remove redundant `EnableSideEffects` instructions (noir-lang/noir#5440) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch> Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
TomAFrench
added a commit
that referenced
this pull request
Jul 11, 2024
* master: (105 commits) chore: unbundle `check_array_is_initialized` (#5451) feat: Sync from aztec-packages (#5467) chore: bump bb to 0.45.1 (#5469) feat: prefix operator overload trait dispatch (#5423) feat: add CLI argument for debugging comptime blocks (#5192) chore: document EmbeddedCurvePoint (#5468) feat: lsp rename/find-all-references for struct members (#5443) feat(optimization): Deduplicate more instructions (#5457) fix: remove compile-time error for invalid indices (#5466) feat: lsp rename/find-all-references for local variables (#5439) feat: remove duplicated array reads at constant indices (#5445) fix: Account for the expected kind when resolving turbofish generics (#5448) fix: Fix issue with unresolved results (#5453) feat: apply `no_predicates` in stdlib (#5454) fix: prevent `no_predicates` from removing predicates in calling function (#5452) feat: lsp rename/find-all-references for globals (#5415) feat: remove redundant `EnableSideEffects` instructions (#5440) fix: Change panic to error in interpreter (#5446) feat: Add more slice methods to the stdlib (#5424) feat: Unquote multiple items from annotations (#5441) ...
TomAFrench
added a commit
that referenced
this pull request
Jul 11, 2024
* master: (62 commits) chore: keccak256 in Noir (#5316) chore: unbundle `check_array_is_initialized` (#5451) feat: Sync from aztec-packages (#5467) chore: bump bb to 0.45.1 (#5469) feat: prefix operator overload trait dispatch (#5423) feat: add CLI argument for debugging comptime blocks (#5192) chore: document EmbeddedCurvePoint (#5468) feat: lsp rename/find-all-references for struct members (#5443) feat(optimization): Deduplicate more instructions (#5457) fix: remove compile-time error for invalid indices (#5466) feat: lsp rename/find-all-references for local variables (#5439) feat: remove duplicated array reads at constant indices (#5445) fix: Account for the expected kind when resolving turbofish generics (#5448) fix: Fix issue with unresolved results (#5453) feat: apply `no_predicates` in stdlib (#5454) fix: prevent `no_predicates` from removing predicates in calling function (#5452) feat: lsp rename/find-all-references for globals (#5415) feat: remove redundant `EnableSideEffects` instructions (#5440) fix: Change panic to error in interpreter (#5446) feat: Add more slice methods to the stdlib (#5424) ...
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>0.32.0</summary> ## [0.32.0](v0.31.0...v0.32.0) (2024-07-18) ### ⚠ BREAKING CHANGES * constant inputs for blackbox (AztecProtocol/aztec-packages#7222) * error on too large integer value ([#5371](#5371)) * rename struct-specific TypeDefinition -> StructDefinition ([#5356](#5356)) * **frontend:** Explicit numeric generics and type kinds ([#5155](#5155)) ### Features * `mod.nr` entrypoint ([#5039](#5039)) ([076fe0a](076fe0a)) * `static_assert` builtin ([#5342](#5342)) ([ef44270](ef44270)) * Add `map`, `fold`, `reduce`, `any`, and `all` for slices ([#5331](#5331)) ([03e25b4](03e25b4)) * Add CLI argument for debugging comptime blocks ([#5192](#5192)) ([0b74a18](0b74a18)) * Add comptime support for `modulus_*` compiler builtins ([#5530](#5530)) ([5bbce79](5bbce79)) * Add debug codelens action ([#5474](#5474)) ([6bcdac4](6bcdac4)) * Add fuzzer for Noir programs ([#5251](#5251)) ([e100017](e100017)) * Add gate profiler for noir circuits (AztecProtocol/aztec-packages#7004) ([083070e](083070e)) * Add more slice methods to the stdlib ([#5424](#5424)) ([4020e77](4020e77)) * Add opcodes flamegraph and refactor gates flamegraph (AztecProtocol/aztec-packages#7282) ([32029f9](32029f9)) * Add support for fieldable in events (AztecProtocol/aztec-packages#7310) ([3f71169](3f71169)) * Add support for usage of `super` in import paths ([#5502](#5502)) ([256509e](256509e)) * Add support for wildcard types ([#5275](#5275)) ([7445efb](7445efb)) * Add TraitConstraint type ([#5499](#5499)) ([30cb65a](30cb65a)) * Add unquote function ([#5497](#5497)) ([2947aba](2947aba)) * Allow arguments to attribute functions ([#5494](#5494)) ([a33cafc](a33cafc)) * Allow comptime attributes on traits & functions ([#5496](#5496)) ([b59a29e](b59a29e)) * Apply `no_predicates` in stdlib ([#5454](#5454)) ([24d26c0](24d26c0)) * Build releases for `aarch64-unknown-linux-gnu` target ([#5289](#5289)) ([f35614a](f35614a)) * Build simple dictionary from inspecting ACIR program ([#5264](#5264)) ([508e677](508e677)) * Constant inputs for blackbox (AztecProtocol/aztec-packages#7222) ([fb97bb9](fb97bb9)) * Detect subgraphs that are completely independent from inputs or outputs ([#5402](#5402)) ([7ea83a9](7ea83a9)) * Disable nargo color output if stderr is tty ([#5346](#5346)) ([554dd6b](554dd6b)) * Error on too large integer value ([#5371](#5371)) ([0c4fffa](0c4fffa)) * **frontend:** Explicit numeric generics and type kinds ([#5155](#5155)) ([d4e03d0](d4e03d0)) * **frontend:** Where clause on impl ([#5320](#5320)) ([cf938bc](cf938bc)) * Handle ACIR calls in the debugger ([#5051](#5051)) ([0541568](0541568)) * Implement comptime support for `array_len` builtin ([#5272](#5272)) ([c91186a](c91186a)) * Implement comptime support for `as_slice` builtin ([#5276](#5276)) ([9db65d8](9db65d8)) * Implement trait dispatch in the comptime interpreter ([#5376](#5376)) ([8aa5b2e](8aa5b2e)) * Insert trait impls into the program from type annotations ([#5327](#5327)) ([efdd818](efdd818)) * Let `should_fail_with` check that the failure reason contains the expected message ([#5319](#5319)) ([cb9db55](cb9db55)) * Let LSP always work in a Noir workspace if there's any ([#5461](#5461)) ([e0d7833](e0d7833)) * Lsp "find all references" ([#5395](#5395)) ([ce1994c](ce1994c)) * Lsp "go to definition" for modules ([#5406](#5406)) ([3e7f1f2](3e7f1f2)) * LSP document symbol ([#5532](#5532)) ([1fabcde](1fabcde)) * LSP hover ([#5491](#5491)) ([010c835](010c835)) * LSP inlay hints for let and global ([#5510](#5510)) ([43f5b8d](43f5b8d)) * Lsp rename struct ([#5380](#5380)) ([ee8b0cd](ee8b0cd)) * Lsp rename/find-all-references for globals ([#5415](#5415)) ([fa9b444](fa9b444)) * Lsp rename/find-all-references for local variables ([#5439](#5439)) ([bb6913a](bb6913a)) * Lsp rename/find-all-references for struct members ([#5443](#5443)) ([a6d213d](a6d213d)) * Lsp rename/find-all-references for traits ([#5409](#5409)) ([bf3a75a](bf3a75a)) * Lsp rename/find-all-references for type aliases ([#5414](#5414)) ([24c621f](24c621f)) * **lsp:** Allow function rename ([#4294](#4294)) ([3d86dc6](3d86dc6)) * Make macros operate on token streams instead of AST nodes ([#5301](#5301)) ([7689d59](7689d59)) * **nargo:** Default expression width field in `Nargo.toml` ([#5505](#5505)) ([dea6b32](dea6b32)) * **optimization:** Deduplicate more instructions ([#5457](#5457)) ([c47242a](c47242a)) * Prefix operator overload trait dispatch ([#5423](#5423)) ([a3bb09e](a3bb09e)) * Remove duplicated array reads at constant indices ([#5445](#5445)) ([82a67a0](82a67a0)) * Remove redundant `EnableSideEffects` instructions ([#5440](#5440)) ([e153ecb](e153ecb)) * Rename struct-specific TypeDefinition -> StructDefinition ([#5356](#5356)) ([7ffccf7](7ffccf7)) * Run `comptime` code from annotations on a type definition ([#5256](#5256)) ([6cbe6a0](6cbe6a0)) * Skip reading values immediately after it being written into an array ([#5449](#5449)) ([141ecdd](141ecdd)) * **stdlib:** Update stdlib to use explicit numeric generics ([#5306](#5306)) ([8456185](8456185)) * Sync from aztec-packages ([#5347](#5347)) ([47b621f](47b621f)) * Sync from aztec-packages ([#5377](#5377)) ([7b77bbf](7b77bbf)) * Sync from noir (AztecProtocol/aztec-packages#7257) ([32029f9](32029f9)) * Sync from noir (AztecProtocol/aztec-packages#7288) ([322f863](322f863)) * Sync from noir (AztecProtocol/aztec-packages#7308) ([322f863](322f863)) * Sync from noir (AztecProtocol/aztec-packages#7332) ([3f71169](3f71169)) * Sync from noir (AztecProtocol/aztec-packages#7352) ([98e72ac](98e72ac)) * Sync from noir (AztecProtocol/aztec-packages#7392) ([fb97bb9](fb97bb9)) * Sync from noir (AztecProtocol/aztec-packages#7400) ([fb97bb9](fb97bb9)) * Unquote multiple items from annotations ([#5441](#5441)) ([be8eac6](be8eac6)) * Use runtime loops for brillig array initialization ([#5243](#5243)) ([0bd22bb](0bd22bb)) ### Bug Fixes * Account for the expected kind when resolving turbofish generics ([#5448](#5448)) ([82c335d](82c335d)) * Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code ([#5009](#5009)) ([318314d](318314d)) * Address compiler warnings coming from stdlib ([#5351](#5351)) ([758a905](758a905)) * Allow importing notes from other contracts and inject them in the macros (AztecProtocol/aztec-packages#7349) ([98e72ac](98e72ac)) * Avoid duplicating constant arrays ([#5287](#5287)) ([3ef3645](3ef3645)) * Avoid panic in type system ([#5332](#5332)) ([52d48ff](52d48ff)) * Avoid unnecessarily splitting expressions with multiplication terms with a shared term ([#5291](#5291)) ([19884f1](19884f1)) * Change panic to error in interpreter ([#5446](#5446)) ([d44f882](d44f882)) * Complete call stacks with no_predicates ([#5418](#5418)) ([df73fe2](df73fe2)) * Correct range for overlfowing/underflowing integer assignment ([#5416](#5416)) ([30c50f5](30c50f5)) * Correctly detect signed/unsigned integer overflows/underflows ([#5375](#5375)) ([0603bd3](0603bd3)) * **docs:** Fix broken docs link to gihtub ([#5398](#5398)) ([70ebf60](70ebf60)) * Don't benchmark the "prove" command as it doesn't exist anymore ([#5323](#5323)) ([3bb3b03](3bb3b03)) * Don't lazily elaborate functions ([#5282](#5282)) ([0ea608f](0ea608f)) * Don't panic when using undefined variables in the interpreter ([#5381](#5381)) ([94d209a](94d209a)) * Don't type error when calling certain trait impls in the interpreter ([#5471](#5471)) ([299703c](299703c)) * Error on empty function bodies ([#5519](#5519)) ([6a7f593](6a7f593)) * Error when a local function is called in a comptime context ([#5334](#5334)) ([7cd4a4d](7cd4a4d)) * Fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. ([#5278](#5278)) ([91a9b72](91a9b72)) * Fix issue with unresolved results ([#5453](#5453)) ([c4154cb](c4154cb)) * Fix tokenization of unquoted types in macros ([#5326](#5326)) ([6673c8b](6673c8b)) * Fix usage of `#[abi(tag)]` attribute with elaborator ([#5298](#5298)) ([64dd48a](64dd48a)) * Go to definition from `use` statement ([#5390](#5390)) ([53bae3b](53bae3b)) * Go to definition from aliased use ([#5396](#5396)) ([90b135c](90b135c)) * Handle struct with nested arrays in oracle return values ([#5244](#5244)) ([a30814f](a30814f)) * ICE when using a comptime let variable in runtime code ([#5391](#5391)) ([9fb7e4d](9fb7e4d)) * Ignore calls to `Intrinsic::AsWitness` during brillig codegen ([#5350](#5350)) ([9c11fd2](9c11fd2)) * Implement generic functions in the interpreter ([#5330](#5330)) ([d8b9870](d8b9870)) * Included argshash computation in public call_interfaces and cleanup (AztecProtocol/aztec-packages#7354) ([98e72ac](98e72ac)) * Lsp find struct reference in return locations and paths ([#5404](#5404)) ([e1bcb73](e1bcb73)) * Lsp hover wasn't always working ([#5515](#5515)) ([951e821](951e821)) * Lsp struct rename/reference difference ([#5411](#5411)) ([580c16d](580c16d)) * Move BigInt modulus checks to runtime in brillig ([#5374](#5374)) ([741d339](741d339)) * Mutability in the comptime interpreter ([#5517](#5517)) ([8cab4ac](8cab4ac)) * **nargo_fmt:** Account for spaces before the generic list of a function ([#5303](#5303)) ([ec728dd](ec728dd)) * Never panic in LSP inlay hints ([#5534](#5534)) ([6b11445](6b11445)) * Prevent `no_predicates` from removing predicates in calling function ([#5452](#5452)) ([66244b6](66244b6)) * Remove compile-time error for invalid indices ([#5466](#5466)) ([323e0c9](323e0c9)) * Remove panics in the interpreter when a builtin fails to type check ([#5382](#5382)) ([c8161c8](c8161c8)) * Replace expects in interpreter with errors ([#5383](#5383)) ([ac738b2](ac738b2)) * Replace panic in monomorphization with an error ([#5305](#5305)) ([49e1b0c](49e1b0c)) * Replace std::HashMap with FxHashMap to fix frontend indeterminism ([#5385](#5385)) ([9501495](9501495)) * Revert PR [#5449](#5449) ([#5548](#5548)) ([a213c15](a213c15)) * Run macro processors in the elaborator ([#5472](#5472)) ([89642c2](89642c2)) * Runtime brillig bigint id assignment ([#5369](#5369)) ([a8928dd](a8928dd)) * Skip emission of brillig calls which will never be executed ([#5314](#5314)) ([b859ef9](b859ef9)) * Truncate flamegraph text to the right (AztecProtocol/aztec-packages#7333) ([3f71169](3f71169)) * Update `in_contract` flag before handling function metadata in elaborator ([#5292](#5292)) ([4c4ea2d](4c4ea2d)) * Use proper serialization in `AbiValue` ([#5270](#5270)) ([d08b7b9](d08b7b9)) </details> <details><summary>0.48.0</summary> ## [0.48.0](v0.47.0...v0.48.0) (2024-07-18) ### ⚠ BREAKING CHANGES * constant inputs for blackbox (AztecProtocol/aztec-packages#7222) * add session id to foreign call RPC requests ([#5205](#5205)) * restrict noir word size to u32 ([#5180](#5180)) * switch `bb` over to read ACIR from nargo artifacts (AztecProtocol/aztec-packages#6283) * specify databus arrays for BB (AztecProtocol/aztec-packages#6239) * remove `Opcode::Brillig` from ACIR (AztecProtocol/aztec-packages#5995) * AES blackbox (AztecProtocol/aztec-packages#6016) * Bit shift is restricted to u8 right operand ([#4907](#4907)) * contract interfaces and better function calls (AztecProtocol/aztec-packages#5687) * change backend width to 4 (AztecProtocol/aztec-packages#5374) * Use fixed size arrays in black box functions where sizes are known (AztecProtocol/aztec-packages#5620) * trap with revert data (AztecProtocol/aztec-packages#5732) * **acir:** BrilligCall opcode (AztecProtocol/aztec-packages#5709) * remove fixed-length keccak256 (AztecProtocol/aztec-packages#5617) * storage_layout and `#[aztec(storage)]` (AztecProtocol/aztec-packages#5387) * **acir:** Add predicate to call opcode (AztecProtocol/aztec-packages#5616) * contract_abi-exports (AztecProtocol/aztec-packages#5386) * Brillig typed memory (AztecProtocol/aztec-packages#5395) * **acir:** Program and witness stack structure (AztecProtocol/aztec-packages#5149) * automatic NoteInterface and NoteGetterOptions auto select (AztecProtocol/aztec-packages#4508) * Acir call opcode (AztecProtocol/aztec-packages#4773) * Support contracts with no constructor (AztecProtocol/aztec-packages#5175) * Internal as a macro (AztecProtocol/aztec-packages#4898) ### Features * `multi_scalar_mul` blackbox func (AztecProtocol/aztec-packages#6097) ([73a635e](73a635e)) * `variable_base_scalar_mul` blackbox func (AztecProtocol/aztec-packages#6039) ([73a635e](73a635e)) * Acir call opcode (AztecProtocol/aztec-packages#4773) ([c3c9e19](c3c9e19)) * **acir_gen:** Brillig stdlib ([#4848](#4848)) ([0c8175c](0c8175c)) * **acir_gen:** Fold attribute at compile-time and initial non inlined ACIR (AztecProtocol/aztec-packages#5341) ([a0f7474](a0f7474)) * **acir:** Add predicate to call opcode (AztecProtocol/aztec-packages#5616) ([2bd006a](2bd006a)) * **acir:** BrilligCall opcode (AztecProtocol/aztec-packages#5709) ([0f9ae0a](0f9ae0a)) * **acir:** Program and witness stack structure (AztecProtocol/aztec-packages#5149) ([13eb71b](13eb71b)) * Activate return_data in ACIR opcodes ([#5080](#5080)) ([c9fda3c](c9fda3c)) * **acvm_js:** Execute program ([#4694](#4694)) ([386f6d0](386f6d0)) * **acvm:** Execute multiple circuits (AztecProtocol/aztec-packages#5380) ([a0f7474](a0f7474)) * Add CMOV instruction to brillig and brillig gen (AztecProtocol/aztec-packages#5308) ([13eb71b](13eb71b)) * Add native rust implementation of schnorr signature verification ([#5053](#5053)) ([fab1c35](fab1c35)) * Add native rust implementations of pedersen functions ([#4871](#4871)) ([fb039f7](fb039f7)) * Add return values to aztec fns (AztecProtocol/aztec-packages#5389) ([2bd006a](2bd006a)) * Add session id to foreign call RPC requests ([#5205](#5205)) ([14adafc](14adafc)) * AES blackbox (AztecProtocol/aztec-packages#6016) ([73a635e](73a635e)) * Automatic NoteInterface and NoteGetterOptions auto select (AztecProtocol/aztec-packages#4508) ([13eb71b](13eb71b)) * **avm:** Brillig CONST of size > u128 (AztecProtocol/aztec-packages#5217) ([c3c9e19](c3c9e19)) * **avm:** Integrate AVM with initializers (AztecProtocol/aztec-packages#5469) ([2bd006a](2bd006a)) * Bit shift is restricted to u8 right operand ([#4907](#4907)) ([c4b0369](c4b0369)) * Brillig heterogeneous memory cells (AztecProtocol/aztec-packages#5608) ([305bcdc](305bcdc)) * Brillig IR refactor (AztecProtocol/aztec-packages#5233) ([c3c9e19](c3c9e19)) * Brillig pointer codegen and execution (AztecProtocol/aztec-packages#5737) ([0f9ae0a](0f9ae0a)) * Brillig typed memory (AztecProtocol/aztec-packages#5395) ([0bc18c4](0bc18c4)) * Change backend width to 4 (AztecProtocol/aztec-packages#5374) ([0f9ae0a](0f9ae0a)) * Check initializer msg.sender matches deployer from address preimage (AztecProtocol/aztec-packages#5222) ([c3c9e19](c3c9e19)) * Constant inputs for blackbox (AztecProtocol/aztec-packages#7222) ([fb97bb9](fb97bb9)) * Contract interfaces and better function calls (AztecProtocol/aztec-packages#5687) ([0f9ae0a](0f9ae0a)) * Contract_abi-exports (AztecProtocol/aztec-packages#5386) ([2bd006a](2bd006a)) * Dynamic assertion payloads v2 (AztecProtocol/aztec-packages#5949) ([73a635e](73a635e)) * Handle `BrilligCall` opcodes in the debugger ([#4897](#4897)) ([b380dc4](b380dc4)) * Impl of missing functionality in new key store (AztecProtocol/aztec-packages#5750) ([0f9ae0a](0f9ae0a)) * Increase default expression width to 4 ([#4995](#4995)) ([f01d309](f01d309)) * Initial Earthly CI (AztecProtocol/aztec-packages#5069) ([c3c9e19](c3c9e19)) * Internal as a macro (AztecProtocol/aztec-packages#4898) ([5f57ebb](5f57ebb)) * Make ACVM generic across fields ([#5114](#5114)) ([70f374c](70f374c)) * Move abi demonomorphizer to noir_codegen and use noir_codegen in protocol types (AztecProtocol/aztec-packages#6302) ([436bbda](436bbda)) * Move to_radix to a blackbox (AztecProtocol/aztec-packages#6294) ([436bbda](436bbda)) * **nargo:** Handle call stacks for multiple Acir calls ([#4711](#4711)) ([5b23171](5b23171)) * **nargo:** Hidden option to show contract artifact paths written by `nargo compile` (AztecProtocol/aztec-packages#6131) ([ff67e14](ff67e14)) * New brillig field operations and refactor of binary operations (AztecProtocol/aztec-packages#5208) ([c3c9e19](c3c9e19)) * Parsing non-string assertion payloads in noir js (AztecProtocol/aztec-packages#6079) ([73a635e](73a635e)) * Private Kernel Recursion (AztecProtocol/aztec-packages#6278) ([436bbda](436bbda)) * Proper padding in ts AES and constrained AES in body and header computations (AztecProtocol/aztec-packages#6269) ([436bbda](436bbda)) * Remove conditional compilation of `bn254_blackbox_solver` ([#5058](#5058)) ([9420d7c](9420d7c)) * Remove external blackbox solver from acir simulator (AztecProtocol/aztec-packages#6586) ([a40a9a5](a40a9a5)) * Restore hashing args via slice for performance (AztecProtocol/aztec-packages#5539) ([2bd006a](2bd006a)) * Restrict noir word size to u32 ([#5180](#5180)) ([bdb2bc6](bdb2bc6)) * Separate runtimes of SSA functions before inlining ([#5121](#5121)) ([69eca9b](69eca9b)) * Set aztec private functions to be recursive (AztecProtocol/aztec-packages#6192) ([73a635e](73a635e)) * Signed integer division and modulus in brillig gen (AztecProtocol/aztec-packages#5279) ([c3c9e19](c3c9e19)) * **simulator:** Fetch return values at circuit execution (AztecProtocol/aztec-packages#5642) ([305bcdc](305bcdc)) * Specify databus arrays for BB (AztecProtocol/aztec-packages#6239) ([436bbda](436bbda)) * Storage_layout and `#[aztec(storage)]` (AztecProtocol/aztec-packages#5387) ([2bd006a](2bd006a)) * Support contracts with no constructor (AztecProtocol/aztec-packages#5175) ([c3c9e19](c3c9e19)) * Switch `bb` over to read ACIR from nargo artifacts (AztecProtocol/aztec-packages#6283) ([436bbda](436bbda)) * Sync from aztec-packages ([#4483](#4483)) ([fe8f277](fe8f277)) * Sync from noir (AztecProtocol/aztec-packages#5234) ([c3c9e19](c3c9e19)) * Sync from noir (AztecProtocol/aztec-packages#5286) ([c3c9e19](c3c9e19)) * Sync from noir (AztecProtocol/aztec-packages#5572) ([2bd006a](2bd006a)) * Sync from noir (AztecProtocol/aztec-packages#5619) ([2bd006a](2bd006a)) * Sync from noir (AztecProtocol/aztec-packages#5697) ([305bcdc](305bcdc)) * Sync from noir (AztecProtocol/aztec-packages#5794) ([0f9ae0a](0f9ae0a)) * Sync from noir (AztecProtocol/aztec-packages#5814) ([0f9ae0a](0f9ae0a)) * Sync from noir (AztecProtocol/aztec-packages#5935) ([1b867b1](1b867b1)) * Sync from noir (AztecProtocol/aztec-packages#5955) ([1b867b1](1b867b1)) * Sync from noir (AztecProtocol/aztec-packages#5999) ([1b867b1](1b867b1)) * Sync from noir (AztecProtocol/aztec-packages#6280) ([436bbda](436bbda)) * Sync from noir (AztecProtocol/aztec-packages#6332) ([436bbda](436bbda)) * Sync from noir (AztecProtocol/aztec-packages#6573) ([436bbda](436bbda)) * Sync from noir (AztecProtocol/aztec-packages#7392) ([fb97bb9](fb97bb9)) * Sync from noir (AztecProtocol/aztec-packages#7400) ([fb97bb9](fb97bb9)) * ToRadix BB + avm transpiler support (AztecProtocol/aztec-packages#6330) ([436bbda](436bbda)) * Trap with revert data (AztecProtocol/aztec-packages#5732) ([0f9ae0a](0f9ae0a)) * Use fixed size arrays in black box functions where sizes are known (AztecProtocol/aztec-packages#5620) ([0f9ae0a](0f9ae0a)) * Variable length returns (AztecProtocol/aztec-packages#5633) ([305bcdc](305bcdc)) ### Bug Fixes * **acvm:** Mark outputs of Opcode::Call solvable ([#4708](#4708)) ([8fea405](8fea405)) * Add support for nested arrays returned by oracles ([#5132](#5132)) ([f846879](f846879)) * Avoid huge unrolling in hash_args (AztecProtocol/aztec-packages#5703) ([305bcdc](305bcdc)) * Avoid unnecessarily splitting expressions with multiplication terms with a shared term ([#5291](#5291)) ([19884f1](19884f1)) * Catch panics from EC point creation (e.g. the point is at infinity) ([#4790](#4790)) ([645dba1](645dba1)) * Check for public args in aztec functions (AztecProtocol/aztec-packages#6355) ([436bbda](436bbda)) * Don't reuse brillig with slice arguments (AztecProtocol/aztec-packages#5800) ([0f9ae0a](0f9ae0a)) * Handle struct with nested arrays in oracle return values ([#5244](#5244)) ([a30814f](a30814f)) * Issue 4682 and add solver for unconstrained bigintegers ([#4729](#4729)) ([e4d33c1](e4d33c1)) * Move BigInt modulus checks to runtime in brillig ([#5374](#5374)) ([741d339](741d339)) * Noir test incorrect reporting (AztecProtocol/aztec-packages#4925) ([5f57ebb](5f57ebb)) * Proper field inversion for bigints ([#4802](#4802)) ([b46d0e3](b46d0e3)) * Runtime brillig bigint id assignment ([#5369](#5369)) ([a8928dd](a8928dd)) * Temporarily revert to_radix blackbox (AztecProtocol/aztec-packages#6304) ([436bbda](436bbda)) ### Miscellaneous Chores * Remove `Opcode::Brillig` from ACIR (AztecProtocol/aztec-packages#5995) ([73a635e](73a635e)) * Remove fixed-length keccak256 (AztecProtocol/aztec-packages#5617) ([305bcdc](305bcdc)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #5442
Summary*
In #5155 we make sure that we make sure we resolve against the correct type kind in various places such as when resolving trait bound generics or trait impl generics. This was not done for function calls. Now when resolving turbofish generics, rather than calling
resolve_type
in all cases aside type expressions, we check whether the variable we are elaborating is a function and fetch its already resolved generics and pass that in as the expected kind.To keep the resolution logic the simple (I just zipped together the
direct_generics
from the function meta and the user specified turbofish generics), aszip
uses the shortest iterator, I also added two checks for whether we have the correct turbofish count. We now have multiple of these checks rather than in justinstantiate
, but I felt it was the simplest logic and would lead to the least potential future confusion.I also have expanded the bug identified in the issue to also include turbofish generics for method calls. I have also included this as part of my test for this PR.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.