fix: included argshash computation in public call_interfaces and cleanup

[Thunkar]

During the development of the defunct #6751 I realized we weren't constraining the args_hash computation in public interfaces, but promptly forgot during the offsite craze.

This PR fixes that and cleanups the interface computation for readability. I would have loved to include the checks in the call interface itself instead of having it in the less clear macros, but we remove an if statement if the function takes no args, which in circuit land is very good.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 50.8 (-89%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 131 (+143%)
• avm_simulation_time_ms (Token:transfer_public): 38.2 (+38%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,772 (+1%)	1,564 (+1%)	713 (+1%)	766	781 (+1%)
proof_construction_time_sha256_30_ms	12,026 (+2%)	3,223 (+2%)	1,444 (+3%)	1,461 (+2%)	1,489 (+1%)
proof_construction_time_sha256_100_ms	44,547 (+2%)	11,970 (+2%)	5,591 (+3%)	5,497 (+2%)	5,450 (+2%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	59.0 (+2%)	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,528 (+1%)	420 (+1%)	201	225 (-1%)	273 (+2%)
proof_construction_time_poseidon_hash_100_ms	5,790 (+1%)	1,591 (+2%)	726 (+1%)	785 (+1%)	797 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,466	9,464
l1_rollup_execution_gas	611,203	611,356	611,505
l2_block_processing_time_in_ms	752 (-1%)	1,416	2,700 (-1%)
l2_block_building_time_in_ms	19,020	37,584 (+1%)	74,106
l2_block_rollup_simulation_time_in_ms	19,020	37,583 (+1%)	74,106
l2_block_public_tx_process_time_in_ms	16,245	34,626 (+1%)	71,162

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,164 (+2%)	10,007 (+1%)
node_database_size_in_bytes	12,456,016	16,187,472
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	108 (-2%)	396 (+1%)	14,399 (-3%)	19,990	55,022	74,432	2,259	524,288
private-kernel-inner	222 (+1%)	700	30,575 (+3%)	82,090	55,022	74,432	2,259	1,048,576
private-kernel-tail	1,051	2,484 (-3%)	54,641 (-5%)	62,345	62,057	14,912	399	2,097,152
base-parity	6.18 (-1%)	1,291 (-3%)	2,638 (-1%)	128	64.0	2,208	2.00	131,072
root-parity	48.9 (-1%)	67.6 (-1%)	40,503 (+2%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	5,959 (+1%)	4,980 (+2%)	91,973 (+3%)	170,330	728	3,648	47.0	4,194,304
root-rollup	111 (+1%)	81.0 (+2%)	23,211 (+1%)	25,253	620	3,456	41.0	1,048,576
public-kernel-setup	430 (-2%)	2,416 (+2%)	43,030 (+1%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-app-logic	395	3,333 (+3%)	41,229 (-2%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-tail	1,137	26,874 (+4%)	181,398 (+2%)	399,014	10,014	14,912	399	8,388,608
private-kernel-reset-small	290	1,104	25,910 (-8%)	79,209	55,022	74,432	2,259	1,048,576
public-kernel-teardown	377 (-1%)	3,353 (+5%)	43,931 (+1%)	102,121	80,278	106,912	3,274	2,097,152
merge-rollup	29.1	N/A	N/A	16,486	728	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,547 (-8%)	58,837 (+3%)	N/A	N/A	106,912	3,274	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,364	398 (+1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,364	24.7 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,364	652 (+2%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,364	568 (+5%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,364	477	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,364	824	16,000	4,544 (-5%)	131,072	433
Token:privately_mint_private_note	1,280	9,364	549 (+4%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,364	103 (+7%)	16,000	1,711 (+3%)	65,536	433
Token:transfer	1,312	9,364	1,629	16,000	11,295 (-4%)	524,288	433
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,345 (-1%)	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	2,795 (-2%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	3,848 (-2%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	2,745 (-1%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	23,422 (-1%)	N/A	N/A
Benchmarking:create_note	1,344	9,364	469 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	9,364	41.5 (+1%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,364	1,329 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,364	1,713	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	69.6	13,790
GasToken:set_portal	14.6 (+8%)	3,339
Token:constructor	93.2 (+2%)	23,692
FPC:constructor	63.2 (+1%)	13,592
GasToken:mint_public	53.5 (+9%)	10,158
Token:mint_public	⚠️ 50.8 (-89%)	19,034
Token:assert_minter_and_mint	⚠️ 131 (+143%)	12,925
AuthRegistry:set_authorized	28.2 (-1%)	7,812
FPC:prepare_fee	103 (-5%)	15,062
Token:transfer_public	⚠️ 38.2 (+38%)	31,218
FPC:pay_refund	123 (-5%)	25,260
Benchmarking:increment_balance	1,979 (+1%)	15,267
Token:_increase_public_balance	14.9 (-7%)	15,006
FPC:pay_refund_with_shielded_rebate	151 (-1%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.154 (-4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4 (+1%)	16.8 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.601 (+1%)	0.515	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.0	75.6	131	245	469
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.490	0.465	0.450	0.445	0.438
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.6	112 (+1%)	183	352	690 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.502	0.502 (+1%)	0.484	0.477	0.474 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.6	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.517	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,057	667,841

Transaction size based on fee payment method

| Metric | |
| - | |