fix: nuke app siloed incoming viewing keys

[sklppy88]

Please read contributing guidelines and remove this line.

[sklppy88]

• fix: nuke app siloed incoming viewing keys #7464 👈
• feat: populate recipient in outgoing #7390
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://6696f572a7f8eb4b315baf2f--aztec-docs-dev.netlify.app

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_100_ms (16): 6,217 (+23%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 70.8 (+44%)
• avm_simulation_time_ms (Token:_increase_public_balance): 80.0 (+335%)
• avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 111 (-45%)
• protocol_circuit_proving_time_in_ms (root-parity): 30,989 (-39%)
• protocol_circuit_proving_time_in_ms (public-kernel-setup): 18,126 (-18%)
• protocol_circuit_proving_time_in_ms (public-kernel-teardown): 18,058 (-20%)
• protocol_circuit_proving_time_in_ms (root-rollup): 28,499 (-30%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,765 (+7%)	1,552 (+5%)	711 (+7%)	745 (+2%)	773 (+6%)
proof_construction_time_sha256_30_ms	11,849 (+9%)	3,172 (+7%)	1,409 (+8%)	1,441 (+5%)	1,465 (+5%)
proof_construction_time_sha256_100_ms	44,113 (+6%)	11,811 (+4%)	⚠️ 6,217 (+23%)	5,388 (-5%)	5,356 (+5%)
proof_construction_time_poseidon_hash_ms	78.0 (+4%)	34.0	34.0	59.0 (+4%)	88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,530 (+6%)	418 (+4%)	201 (+4%)	226 (+6%)	269 (+3%)
proof_construction_time_poseidon_hash_100_ms	5,660 (+6%)	1,524 (+4%)	693 (+8%)	733 (+7%)	751 (+6%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,552	6,594	6,600
l1_rollup_execution_gas	583,014	583,207	583,364
l2_block_processing_time_in_ms	773 (-4%)	1,418 (-6%)	2,748 (-5%)
l2_block_building_time_in_ms	13,323 (-4%)	26,025 (-4%)	50,909 (-4%)
l2_block_rollup_simulation_time_in_ms	13,323 (-4%)	26,024 (-4%)	50,909 (-4%)
l2_block_public_tx_process_time_in_ms	11,155 (-4%)	23,678 (-4%)	48,541 (-4%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,074 (-5%)	9,913 (-5%)
node_database_size_in_bytes	12,460,112	16,441,424
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	115 (-5%)	398	21,732	54,085	N/A	N/A	N/A	N/A
private-kernel-inner	227 (-4%)	700 (-1%)	81,199	54,264	N/A	N/A	N/A	N/A
private-kernel-tail	1,112 (-2%)	2,452 (-2%)	61,808	61,554	N/A	N/A	N/A	N/A
base-parity	6.39 (-6%)	797 (-8%)	160	96.0	1,947 (-2%)	12,676	3.00	131,072
root-parity	108 (-3%)	118 (+1%)	64,860	96.0	⚠️ 30,989 (-39%)	12,676	3.00	4,194,304
base-rollup	4,210 (-4%)	4,880 (-1%)	180,315	632	43,300 (-11%)	13,476	28.0	4,194,304
root-rollup	151 (-6%)	122 (+1%)	51,261	652	⚠️ 28,499 (-30%)	13,412	26.0	4,194,304
public-kernel-setup	190 (-7%)	2,367 (-3%)	112,536	80,310	⚠️ 18,126 (-18%)	118,916	3,323	2,097,152
public-kernel-app-logic	149 (-4%)	3,313 (+2%)	112,536	80,310	10,148 (+1%)	118,916	3,323	1,048,576
public-kernel-tail	890 (-3%)	25,934 (-5%)	409,413	10,046	66,014 (-10%)	24,868	384	8,388,608
private-kernel-reset-tiny	295 (-5%)	982 (-2%)	77,007	53,954	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	6,630 (-3%)	2,917 (+3%)	777,415	1,632	N/A	N/A	N/A	N/A
public-kernel-teardown	136 (-6%)	3,207 (-2%)	112,536	80,310	⚠️ 18,058 (-20%)	118,916	3,323	2,097,152
merge-rollup	57.2 (-6%)	N/A	33,566	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	166,836 (+3%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	9,344	391 (-5%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	24.7 (-6%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	621 (-5%)	N/A	N/A
GasToken:deploy	1,344	9,344	553 (-6%)	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	422 (-8%)	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	759 (-7%)	N/A	N/A
Token:privately_mint_private_note	1,248	9,344	487 (-8%)	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	98.7 (-4%)	N/A	N/A
Token:transfer	1,280	9,344	1,412 (-8%)	N/A	N/A
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	95,392	2,106 (-1%)
FPC:prepare_fee (avm)	26,664	N/A	N/A	95,456	2,774 (-2%)
Token:transfer_public (avm)	42,914	N/A	N/A	95,456	3,161 (-1%)
AuthRegistry:consume (avm)	33,100	N/A	N/A	95,424	2,724 (-3%)
FPC:pay_refund (avm)	36,829	N/A	N/A	95,424	10,795 (-2%)
Benchmarking:create_note	1,312	9,344	422 (-10%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	40.3 (-12%)	N/A	N/A
Token:unshield	1,344	9,344	1,145 (-11%)	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,503 (-10%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	95.6 (-4%)	13,790
GasToken:set_portal	15.5 (+20%)	3,339
Token:constructor	126 (-2%)	23,692
FPC:constructor	91.3	13,592
GasToken:mint_public	79.3 (-4%)	10,158
Token:mint_public	331 (-5%)	19,034
Token:assert_minter_and_mint	⚠️ 70.8 (+44%)	12,925
AuthRegistry:set_authorized	44.2 (-8%)	7,812
FPC:prepare_fee	109 (-10%)	15,062
Token:transfer_public	39.2 (-9%)	31,218
FPC:pay_refund	127 (-1%)	25,260
Benchmarking:increment_balance	1,342 (-4%)	15,267
Token:_increase_public_balance	⚠️ 80.0 (+335%)	15,006
FPC:pay_refund_with_shielded_rebate	⚠️ 111 (-45%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.157 (+3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3 (-5%)	16.7 (-5%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.596 (-5%)	0.512 (-5%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.7 (-5%)	75.9 (-6%)	133 (-5%)	246 (-6%)	473 (-6%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.488 (-5%)	0.466 (-6%)	0.456 (-5%)	0.446 (-6%)	0.441 (-7%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.1 (-6%)	112 (-6%)	186 (-5%)	354 (-6%)	697 (-6%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.499 (-6%)	0.503 (-5%)	0.486 (-5%)	0.479 (-6%)	0.477 (-6%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.5 (-5%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.516 (-5%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	76,837	667,838

Transaction size based on fee payment method

| Metric | |
| - | |

[benesjan]

Looks good