chore: delete more unwanted stuff from noir code

[TomAFrench]

More warnings fixed.

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,389 (+105%)
• avm_simulation_time_ms (FeeJuice:_increase_public_balance): 155 (+242%)
• avm_simulation_time_ms (Token:mint_public): 465 (+854%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 45.6 (-90%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,751	1,561	712	748 (-2%)	772 (-1%)
proof_construction_time_sha256_30_ms	11,473	3,091	1,377	1,421 (-1%)	1,457
proof_construction_time_sha256_100_ms	44,087	11,815	5,442 (-1%)	5,431 (-3%)	5,642
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	57.0	88.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,528	420	203	223 (-1%)	262 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,643	1,514	676 (+1%)	725	742 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,208	92,950	178,168
l1_rollup_execution_gas	843,027	1,576,665	3,361,939
l2_block_processing_time_in_ms	255 (+1%)	453 (+3%)	823 (+2%)
l2_block_building_time_in_ms	11,230	22,225	44,292 (+1%)
l2_block_rollup_simulation_time_in_ms	11,230	22,224	44,292 (+1%)
l2_block_public_tx_process_time_in_ms	9,572 (-1%)	20,539	42,566 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,041 (+5%)	3,895 (+3%)
node_database_size_in_bytes	12,615,760	16,691,280
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	78.3 (-6%)	377 (-4%)	21,391	44,898	N/A
private-kernel-inner	156 (-1%)	677 (-3%)	72,372	45,020	N/A
private-kernel-reset-tiny	296 (-1%)	685 (-4%)	65,097	44,886	N/A
private-kernel-tail	160 (+1%)	133 (-2%)	50,608	52,921	N/A
base-parity	5.59	N/A	160	96.0	N/A
root-parity	34.9 (-3%)	N/A	73,948	96.0	N/A
base-rollup	3,121	N/A	189,207	664	N/A
block-root-rollup	40.9 (-2%)	N/A	58,205	2,448	N/A
public-kernel-setup	80.6 (-1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	95.0 (+1%)	N/A	104,899	71,222	N/A
public-kernel-tail	847 (+1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	293	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,389 (+105%)	590 (-3%)	453,751	1,825	N/A
public-kernel-teardown	80.2	N/A	105,349	71,222	N/A
merge-rollup	20.3 (+3%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	84,053 (+8%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	344 (+1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (-2%)
MultiCallEntrypoint:entrypoint	1,920	11,731	403
FeeJuice:deploy	1,376	11,731	385 (-1%)
SchnorrAccount:constructor	1,312	11,731	72.6 (-1%)
SchnorrAccount:entrypoint	2,336	11,731	384 (+1%)
FeeJuice:claim	1,344	11,731	35.4 (+1%)
Token:privately_mint_private_note	1,280	11,731	102 (-1%)
FPC:fee_entrypoint_public	1,344	11,731	26.2 (+7%)
Token:transfer	1,312	11,731	218 (-2%)
Benchmarking:create_note	1,344	11,731	85.9
SchnorrAccount:verify_private_authwit	1,280	11,731	31.4 (+20%)
Token:unshield	1,376	11,731	527 (+2%)
FPC:fee_entrypoint_private	1,376	11,731	698 (+2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 155 (+242%)	2,431
FeeJuice:set_portal	11.3 (-14%)	2,930
Token:constructor	76.7	15,813
FPC:constructor	49.6	9,720
FeeJuice:check_balance	37.7	2,357
Token:mint_public	⚠️ 465 (+854%)	5,011
Token:assert_minter_and_mint	⚠️ 45.6 (-90%)	3,155
AuthRegistry:set_authorized	44.5 (-5%)	924
FPC:prepare_fee	195 (-11%)	4,245
Token:transfer_public	26.9 (+29%)	21,586
FPC:pay_refund	51.5 (+16%)	5,303
Benchmarking:increment_balance	1,217 (+2%)	3,496
Token:_increase_public_balance	38.9 (+2%)	2,408
FPC:pay_refund_with_shielded_rebate	54.0 (+2%)	5,303

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.154 (+3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17 (+1%)	3.85 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112 (+1%)	0.108 (-3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.1 (-1%)	17.8 (+2%)	30.8	60.1 (+4%)	115 (+3%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.106 (-1%)	0.103 (+3%)	0.100 (+1%)	0.104 (+4%)	0.103 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.2 (-1%)	26.2 (+3%)	43.5 (+1%)	83.9 (+3%)	165 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	107 (-1%)	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109 (-1%)	0.105 (+3%)	0.105 (+1%)	0.104 (+3%)	0.104 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.7 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,838	668,997

Transaction size based on fee payment method

| Metric | |
| - | |