fix: Revert "feat: ultra keccak honk verifier"

[alexghr]

Reverts #8391, which reverted #8261 :)
Also adds a few enhancements to bring it up to date with latest crypto changes

[ludamad]

good to rerevert (vert?) once CI passes

[ludamad]

merging master to rekick off CI as it seemed to have a runner issue

[alexghr]

This is the extra code compared to what we had in the prior PR

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,393 (+76%)
• avm_simulation_time_ms (Token:mint_public): 44.2 (-86%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 334 (+445%)
• avm_simulation_time_ms (AuthRegistry:set_authorized): 46.7 (+31%)
• avm_simulation_time_ms (Token:transfer_public): 24.0 (+83%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,749	1,549	695 (-1%)	759 (+2%)	771 (-1%)
proof_construction_time_sha256_30_ms	11,504	3,050 (-1%)	1,360 (-1%)	1,422	1,454 (-1%)
proof_construction_time_sha256_100_ms	45,307	11,774	5,465	5,808 (-2%)	5,333 (-1%)
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0	34.0	57.0 (-2%)	89.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,527	416	199	225 (-1%)	271 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,647	1,497	669	738 (+2%)	746

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,160	92,816	178,048
l1_rollup_execution_gas	843,001	1,576,553	3,361,841
l2_block_processing_time_in_ms	254 (-1%)	454 (+1%)	799
l2_block_building_time_in_ms	11,584	22,757	45,337
l2_block_rollup_simulation_time_in_ms	11,584	22,757	45,336
l2_block_public_tx_process_time_in_ms	9,903	21,045	43,604

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,419 (-1%)	4,345 (-1%)
node_database_size_in_bytes	14,229,744	18,239,728
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	75.3 (+6%)	385 (+1%)	21,103	44,933	N/A
private-kernel-inner	140 (+1%)	687	71,855	45,067	N/A
private-kernel-reset-tiny	288 (-2%)	662 (-1%)	64,691	44,922	N/A
private-kernel-tail	149 (-1%)	127 (-1%)	50,557	56,996	N/A
base-parity	5.53	N/A	160	96.0	N/A
root-parity	34.9 (-1%)	N/A	73,964	96.0	N/A
base-rollup	2,598 (-1%)	N/A	189,128	664	N/A
block-root-rollup	41.1	N/A	58,217	2,448	N/A
public-kernel-setup	84.1 (+2%)	N/A	114,177	79,414	N/A
public-kernel-app-logic	95.9 (-1%)	N/A	113,995	79,414	N/A
public-kernel-tail	854	N/A	497,082	16,414	N/A
private-kernel-reset-small	272 (+1%)	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,393 (+76%)	589 (-1%)	448,133	1,825	N/A
public-kernel-teardown	84.7 (+2%)	N/A	114,441	79,414	N/A
merge-rollup	19.9	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	81,008 (-3%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	339 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.0 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	417
FeeJuice:deploy	1,376	11,731	386 (-1%)
SchnorrAccount:constructor	1,312	11,731	60.1
SchnorrAccount:entrypoint	2,336	11,731	366 (-1%)
FeeJuice:claim	1,344	11,731	35.4 (+2%)
Token:privately_mint_private_note	1,280	11,731	74.0 (+11%)
FPC:fee_entrypoint_public	1,344	11,731	24.5 (-9%)
Token:transfer	1,312	11,731	206
Benchmarking:create_note	1,344	11,731	73.3 (-2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.2
Token:unshield	1,376	11,731	480
FPC:fee_entrypoint_private	1,376	11,731	643

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	163 (-2%)	2,261
FeeJuice:set_portal	11.5 (+10%)	2,588
Token:constructor	78.0 (+5%)	12,938
FPC:constructor	49.2 (+11%)	7,744
FeeJuice:check_balance	40.6 (+11%)	1,980
Token:mint_public	⚠️ 44.2 (-86%)	4,419
Token:assert_minter_and_mint	⚠️ 334 (+445%)	2,899
AuthRegistry:set_authorized	⚠️ 46.7 (+31%)	923
FPC:prepare_fee	66.7 (+5%)	3,925
Token:transfer_public	⚠️ 24.0 (+83%)	8,887
FPC:pay_refund	43.3 (+10%)	4,851
Benchmarking:increment_balance	1,237 (-1%)	3,124
Token:_increase_public_balance	38.3 (-2%)	2,238
FPC:pay_refund_with_shielded_rebate	50.4 (+3%)	4,851

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.177 (+6%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17 (+1%)	4.03 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (+1%)	0.113 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.3 (-1%)	17.5 (-2%)	31.0 (-3%)	59.5 (-2%)	113 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (-1%)	0.101 (-2%)	0.101 (-3%)	0.103 (-1%)	0.101 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.4	25.6 (-1%)	44.4	82.8 (-2%)	162 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109 (-1%)	0.103 (-1%)	0.107 (+4%)	0.103 (-1%)	0.103 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.1	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,168	668,252

Transaction size based on fee payment method

| Metric | |
| - | |