Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multi-node metrics working #9486

Merged
merged 35 commits into from
Oct 30, 2024
Merged

fix: multi-node metrics working #9486

merged 35 commits into from
Oct 30, 2024

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Oct 28, 2024 •
edited
Loading

After this PR:

  • switched to deployment of metrics helm chart, meaning we are just a normal endpoint and don't try to do k8s-aware log scraping
  • Now code that passes LOG_JSON and OTEL_EXPORTER_OTLP_LOGS_ENDPOINT will use winston otel transport to log to that otel endpoint (making its way into grafana eventually)
  • Adjustments in helm chart and winston transport side enabling logging, see working here:
Screenshot 2024-10-29 at 8 38 01 PM

This was from the scripts/run_native_testnet_with_metrics.sh script that got the publicly available metrics deployment and pointed the local testnet scripts at it.

  • minor fix for earthly s3 caching
  • new post_deploy_spartan.sh script that runs 'network-bootstrap' that initializes the network with some key test contracts
  • refactor logging a bit to make it the negative patterns useful for all logging pathways + extract logic added for offsite demo into its own functional wrapper for adding 'fixed data'
  • Closes Use winston for opentelemetry logging #9234

@ludamad ludamad changed the title (WIP) fix: multi-node metrics working fix: multi-node metrics working Oct 30, 2024
@ludamad ludamad requested a review from just-mitch October 30, 2024 00:52
@github-actions GitHub Actions
Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: 6b5f67fca0fa5073518cfaa079320077b14bbf49, compared to commit: c71645f4cc9754d99eb3ac77ff8063495caa264d

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::keccak_hash +243 ❌ +9.37%
AvmTest::read_storage_list +2 ❌ +0.32%
AvmTest::return_oracle +1 ❌ +0.30%
DocsExample::get_shared_immutable_constrained_public_multiple +2 ❌ +0.28%
AvmTest::to_radix_le +1 ❌ +0.26%
Lending::get_assets +2 ❌ +0.25%
AvmTest::assert_calldata_copy +1 ❌ +0.22%
AvmTest::read_storage_single +1 ❌ +0.22%
AvmTest::keccak_f1600 +1 ❌ +0.21%
AvmInitializerTest::read_storage_immutable +1 ❌ +0.20%
NFT::public_get_symbol +1 ❌ +0.19%
TokenBridge::get_token +1 ❌ +0.19%
Token::get_admin +1 ❌ +0.19%
NFT::public_get_name +1 ❌ +0.19%
NFT::get_admin +1 ❌ +0.19%
Token::public_get_symbol +1 ❌ +0.19%
Token::public_get_name +1 ❌ +0.19%
DocsExample::get_shared_immutable_constrained_public +1 ❌ +0.19%
Token::public_get_decimals +1 ❌ +0.19%
TokenBridge::_assert_token_is_same +1 ❌ +0.19%
TokenBridge::get_portal_address_public +1 ❌ +0.18%
TokenBlacklist::total_supply +1 ❌ +0.16%
Token::total_supply +1 ❌ +0.16%
NFT::_store_payload_in_transient_storage_unsafe +2 ❌ +0.16%
Token::_store_payload_in_transient_storage_unsafe +2 ❌ +0.16%
AvmTest::set_read_storage_single +1 ❌ +0.15%
EasyPrivateVoting::end_vote +1 ❌ +0.14%
NFT::set_admin +1 ❌ +0.14%
Token::set_admin +1 ❌ +0.14%
AvmTest::poseidon2_hash +2 ❌ +0.12%
DocsExample::initialize_public_immutable +1 ❌ +0.12%
DocsExample::initialize_shared_immutable +1 ❌ +0.12%
Router::_check_block_number +1 ❌ +0.12%
AvmTest::get_args_hash +2 ❌ +0.12%
Router::_check_timestamp +1 ❌ +0.12%
FeeJuice::set_portal +1 ❌ +0.11%
TokenBlacklist::_reduce_total_supply +1 ❌ +0.10%
Token::_reduce_total_supply +1 ❌ +0.10%
AvmTest::pedersen_commit +1 ❌ +0.09%
Router::public_dispatch +2 ❌ +0.08%
AvmTest::pedersen_hash +2 ❌ +0.07%
AvmTest::pedersen_hash_with_index +2 ❌ +0.07%
AvmInitializerTest::public_dispatch +2 ❌ +0.06%
AuthRegistry::set_reject_all +1 ❌ +0.06%
NFT::_finish_transfer_to_public +1 ❌ +0.06%
Spam::public_dispatch +2 ❌ +0.06%
Auth::get_scheduled_authorized +1 ❌ +0.06%
AvmTest::read_storage_map +1 ❌ +0.06%
PriceFeed::set_price +1 ❌ +0.06%
StatefulTest::get_public_value +1 ❌ +0.05%
AvmTest::set_storage_map +1 ❌ +0.05%
AuthRegistry::is_reject_all +1 ❌ +0.05%
PriceFeed::get_price +1 ❌ +0.05%
AvmTest::sha256_hash +2 ❌ +0.05%
NFT::is_minter +1 ❌ +0.05%
Token::is_minter +1 ❌ +0.05%
AuthRegistry::set_authorized +1 ❌ +0.05%
PriceFeed::public_dispatch +2 ❌ +0.05%
Auth::get_authorized +1 ❌ +0.05%
AuthRegistry::_set_authorized +1 ❌ +0.05%
FeeJuice::balance_of_public +1 ❌ +0.05%
TokenBlacklist::balance_of_public +1 ❌ +0.05%
Token::balance_of_public +1 ❌ +0.05%
PrivateFPC::public_dispatch +2 ❌ +0.05%
InclusionProofs::public_dispatch +2 ❌ +0.05%
StatefulTest::increment_public_value_no_init_check +1 ❌ +0.05%
Test::create_l2_to_l1_message_public +1 ❌ +0.05%
AuthRegistry::is_consumable +1 ❌ +0.05%
StatefulTest::increment_public_value +1 ❌ +0.05%
Claim::public_dispatch +2 ❌ +0.05%
Token::set_minter +1 ❌ +0.05%
NFT::set_minter +1 ❌ +0.05%
Lending::get_asset +1 ❌ +0.05%
AvmTest::add_storage_map +1 ❌ +0.05%
Auth::get_authorized_delay +1 ❌ +0.05%
FeeJuice::check_balance +1 ❌ +0.04%
NFT::constructor +2 ❌ +0.04%
EasyPrivateVoting::add_to_tally_public +1 ❌ +0.04%
AvmInitializerTest::constructor +1 ❌ +0.04%
AppSubscription::public_dispatch +2 ❌ +0.04%
Token::assert_minter_and_mint +1 ❌ +0.04%
FeeJuice::_increase_public_balance +1 ❌ +0.04%
Token::constructor +2 ❌ +0.04%
InclusionProofs::constructor +1 ❌ +0.04%
TokenBlacklist::get_roles +1 ❌ +0.04%
NFT::owner_of +1 ❌ +0.04%
Spam::public_spam +1 ❌ +0.04%
TokenBlacklist::_increase_public_balance +1 ❌ +0.04%
Token::_increase_public_balance +1 ❌ +0.04%
FPC::constructor +1 ❌ +0.03%
Uniswap::constructor +1 ❌ +0.03%
EasyPrivateVoting::public_dispatch +2 ❌ +0.03%
Auth::constructor +1 ❌ +0.03%
FeeJuice::public_dispatch +2 ❌ +0.03%
PrivateFPC::constructor +1 ❌ +0.03%
Lending::init +1 ❌ +0.03%
EasyPrivateVoting::constructor +1 ❌ +0.03%
AuthRegistry::consume +1 ❌ +0.03%
TokenBridge::constructor +1 ❌ +0.03%
Claim::constructor +1 ❌ +0.03%
NFT::mint +1 ❌ +0.03%
Token::mint_private +1 ❌ +0.03%
Token::mint_public +1 ❌ +0.03%
Crowdfunding::init +1 ❌ +0.03%
AppSubscription::constructor +1 ❌ +0.03%
AuthRegistry::public_dispatch +2 ❌ +0.03%
TokenBlacklist::mint_private +1 ❌ +0.02%
TokenBlacklist::mint_public +1 ❌ +0.02%
CardGame::on_game_joined +1 ❌ +0.02%
Lending::get_position +1 ❌ +0.02%
Auth::public_dispatch +2 ❌ +0.02%
Lending::update_accumulator +1 ❌ +0.02%
Auth::set_authorized_delay +1 ❌ +0.02%
Auth::set_authorized +1 ❌ +0.02%
CardGame::on_card_played +1 ❌ +0.02%
CardGame::start_game +1 ❌ +0.01%
CardGame::on_cards_claimed +1 ❌ +0.01%
TokenBlacklist::update_roles +1 ❌ +0.01%
TokenBlacklist::constructor +1 ❌ +0.01%
CardGame::public_dispatch +2 ❌ +0.01%
AvmTest::bulk_testing -15 ✅ -0.06%
TokenBlacklist::public_dispatch -31 ✅ -0.13%
Token::public_dispatch -45 ✅ -0.14%
NFT::public_dispatch -45 ✅ -0.18%
NFT::_finalize_transfer_to_private_unsafe -12 ✅ -0.20%
NFT::finalize_transfer_to_private -12 ✅ -0.20%
Crowdfunding::public_dispatch -12 ✅ -0.20%
Token::complete_refund -12 ✅ -0.21%
TestLog::public_dispatch -12 ✅ -0.38%
TokenBlacklist::shield -32 ✅ -0.53%
TokenBlacklist::transfer_public -32 ✅ -0.54%
Lending::_repay -32 ✅ -0.56%
DocsExample::public_dispatch -31 ✅ -0.56%
TokenBlacklist::burn_public -32 ✅ -0.58%
AvmTest::public_dispatch -340 ✅ -0.59%
Token::shield -32 ✅ -0.65%
TestLog::emit_unencrypted_events -12 ✅ -0.68%
Benchmarking::broadcast -13 ✅ -0.69%
Token::transfer_public -32 ✅ -0.71%
Token::burn_public -32 ✅ -0.73%
NFT::transfer_in_public -32 ✅ -0.92%
Crowdfunding::_publish_donation_receipts -12 ✅ -0.94%
Parent::public_nested_static_call -31 ✅ -0.97%
Lending::_deposit -32 ✅ -1.12%
StaticChild::public_dispatch -40 ✅ -1.39%
AvmTest::emit_unencrypted_log -40 ✅ -1.39%
Test::public_dispatch -313 ✅ -1.64%
Child::pub_inc_value_internal -13 ✅ -1.69%
StaticChild::pub_illegal_inc_value -13 ✅ -1.70%
AuthWitTest::public_dispatch -31 ✅ -1.72%
Child::pub_inc_value -13 ✅ -1.75%
StaticChild::pub_inc_value -13 ✅ -1.75%
Uniswap::public_dispatch -478 ✅ -1.98%
ImportTest::public_dispatch -31 ✅ -2.07%
Lending::public_dispatch -568 ✅ -2.10%
Test::emit_unencrypted -40 ✅ -2.47%
Test::consume_mint_public_message -272 ✅ -2.66%
AvmTest::returndata_copy_oracle -55 ✅ -2.90%
AvmTest::debug_logging -38 ✅ -2.99%
TokenBridge::public_dispatch -718 ✅ -3.31%
Uniswap::_assert_token_is_same -32 ✅ -3.35%
AvmTest::revert_oracle -13 ✅ -3.35%
Test::consume_message_from_arbitrary_sender_public -259 ✅ -3.37%
DocsExample::get_shared_immutable_constrained_public_indirect -32 ✅ -3.44%
TokenBridge::_call_mint_on_token -32 ✅ -3.63%
AvmTest::nested_call_to_assert_same -32 ✅ -3.63%
AvmTest::nested_static_call_to_add -32 ✅ -3.63%
AvmTest::nested_call_to_add -32 ✅ -3.63%
StaticParent::public_get_value_from_child -32 ✅ -3.69%
AvmTest::nested_call_to_add_with_gas -32 ✅ -3.74%
Uniswap::swap_public -584 ✅ -3.84%
Child::pub_set_value -14 ✅ -4.05%
StaticChild::pub_set_value -14 ✅ -4.05%
Child::set_value_twice_with_nested_last -46 ✅ -4.09%
Child::set_value_twice_with_nested_first -46 ✅ -4.09%
Parent::public_dispatch -338 ✅ -4.12%
TokenBridge::exit_to_l1_public -392 ✅ -4.97%
StatefulTest::public_dispatch -391 ✅ -5.08%
Child::public_dispatch -308 ✅ -5.40%
Lending::_borrow -458 ✅ -5.40%
Lending::_withdraw -476 ✅ -5.45%
TokenBridge::claim_public -665 ✅ -5.57%
FPC::public_dispatch -502 ✅ -5.60%
AuthWitTest::consume_public -33 ✅ -6.00%
Parent::pub_entry_point -33 ✅ -6.32%
StaticParent::public_call -33 ✅ -6.32%
AvmTest::create_different_nullifier_in_nested_call -33 ✅ -7.05%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 -434 ✅ -7.09%
Parent::pub_entry_point_twice -66 ✅ -7.13%
AvmTest::create_same_nullifier_in_nested_call -33 ✅ -7.21%
StaticParent::public_dispatch -508 ✅ -7.24%
ImportTest::pub_call_public_fn -33 ✅ -7.28%
AvmTest::nested_static_call_to_set_storage -33 ✅ -7.30%
Benchmarking::public_dispatch -405 ✅ -7.47%
Child::set_value_with_two_nested_calls -80 ✅ -7.74%
StatefulTest::public_constructor -392 ✅ -10.85%
Benchmarking::increment_balance -392 ✅ -11.21%
StaticParent::public_nested_static_call -409 ✅ -18.06%
Lending::deposit_public -453 ✅ -19.03%
Lending::repay_public -444 ✅ -19.59%
Parent::public_static_call -207 ✅ -19.68%
StaticParent::public_static_call -207 ✅ -19.68%
FPC::pay_refund -411 ✅ -22.10%
FPC::prepare_fee -411 ✅ -22.57%
Lending::withdraw_public -411 ✅ -23.53%
Lending::borrow_public -411 ✅ -23.53%
FPC::pay_refund_with_shielded_rebate -393 ✅ -24.72%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::keccak_hash 2,836 (+243) +9.37%
AvmTest::read_storage_list 620 (+2) +0.32%
AvmTest::return_oracle 339 (+1) +0.30%
DocsExample::get_shared_immutable_constrained_public_multiple 707 (+2) +0.28%
AvmTest::to_radix_le 388 (+1) +0.26%
Lending::get_assets 799 (+2) +0.25%
AvmTest::assert_calldata_copy 450 (+1) +0.22%
AvmTest::read_storage_single 456 (+1) +0.22%
AvmTest::keccak_f1600 469 (+1) +0.21%
AvmInitializerTest::read_storage_immutable 494 (+1) +0.20%
NFT::public_get_symbol 519 (+1) +0.19%
TokenBridge::get_token 519 (+1) +0.19%
Token::get_admin 519 (+1) +0.19%
NFT::public_get_name 524 (+1) +0.19%
NFT::get_admin 524 (+1) +0.19%
Token::public_get_symbol 524 (+1) +0.19%
Token::public_get_name 524 (+1) +0.19%
DocsExample::get_shared_immutable_constrained_public 539 (+1) +0.19%
Token::public_get_decimals 539 (+1) +0.19%
TokenBridge::_assert_token_is_same 540 (+1) +0.19%
TokenBridge::get_portal_address_public 556 (+1) +0.18%
TokenBlacklist::total_supply 621 (+1) +0.16%
Token::total_supply 621 (+1) +0.16%
NFT::_store_payload_in_transient_storage_unsafe 1,291 (+2) +0.16%
Token::_store_payload_in_transient_storage_unsafe 1,291 (+2) +0.16%
AvmTest::set_read_storage_single 651 (+1) +0.15%
EasyPrivateVoting::end_vote 703 (+1) +0.14%
NFT::set_admin 704 (+1) +0.14%
Token::set_admin 704 (+1) +0.14%
AvmTest::poseidon2_hash 1,632 (+2) +0.12%
DocsExample::initialize_public_immutable 848 (+1) +0.12%
DocsExample::initialize_shared_immutable 848 (+1) +0.12%
Router::_check_block_number 851 (+1) +0.12%
AvmTest::get_args_hash 1,706 (+2) +0.12%
Router::_check_timestamp 868 (+1) +0.12%
FeeJuice::set_portal 953 (+1) +0.11%
TokenBlacklist::_reduce_total_supply 970 (+1) +0.10%
Token::_reduce_total_supply 975 (+1) +0.10%
AvmTest::pedersen_commit 1,146 (+1) +0.09%
Router::public_dispatch 2,395 (+2) +0.08%
AvmTest::pedersen_hash 2,859 (+2) +0.07%
AvmTest::pedersen_hash_with_index 2,859 (+2) +0.07%
AvmInitializerTest::public_dispatch 3,104 (+2) +0.06%
AuthRegistry::set_reject_all 1,728 (+1) +0.06%
NFT::_finish_transfer_to_public 1,780 (+1) +0.06%
Spam::public_dispatch 3,580 (+2) +0.06%
Auth::get_scheduled_authorized 1,810 (+1) +0.06%
AvmTest::read_storage_map 1,810 (+1) +0.06%
PriceFeed::set_price 1,813 (+1) +0.06%
StatefulTest::get_public_value 1,825 (+1) +0.05%
AvmTest::set_storage_map 1,833 (+1) +0.05%
AuthRegistry::is_reject_all 1,835 (+1) +0.05%
PriceFeed::get_price 1,853 (+1) +0.05%
AvmTest::sha256_hash 3,716 (+2) +0.05%
NFT::is_minter 1,873 (+1) +0.05%
Token::is_minter 1,873 (+1) +0.05%
AuthRegistry::set_authorized 1,886 (+1) +0.05%
PriceFeed::public_dispatch 3,800 (+2) +0.05%
Auth::get_authorized 1,902 (+1) +0.05%
AuthRegistry::_set_authorized 1,917 (+1) +0.05%
FeeJuice::balance_of_public 1,917 (+1) +0.05%
TokenBlacklist::balance_of_public 1,955 (+1) +0.05%
Token::balance_of_public 1,955 (+1) +0.05%
PrivateFPC::public_dispatch 3,912 (+2) +0.05%
InclusionProofs::public_dispatch 3,948 (+2) +0.05%
StatefulTest::increment_public_value_no_init_check 1,975 (+1) +0.05%
Test::create_l2_to_l1_message_public 1,979 (+1) +0.05%
AuthRegistry::is_consumable 1,998 (+1) +0.05%
StatefulTest::increment_public_value 2,008 (+1) +0.05%
Claim::public_dispatch 4,026 (+2) +0.05%
Token::set_minter 2,045 (+1) +0.05%
NFT::set_minter 2,050 (+1) +0.05%
Lending::get_asset 2,058 (+1) +0.05%
AvmTest::add_storage_map 2,189 (+1) +0.05%
Auth::get_authorized_delay 2,211 (+1) +0.05%
FeeJuice::check_balance 2,238 (+1) +0.04%
NFT::constructor 4,501 (+2) +0.04%
EasyPrivateVoting::add_to_tally_public 2,364 (+1) +0.04%
AvmInitializerTest::constructor 2,368 (+1) +0.04%
AppSubscription::public_dispatch 4,764 (+2) +0.04%
Token::assert_minter_and_mint 2,405 (+1) +0.04%
FeeJuice::_increase_public_balance 2,421 (+1) +0.04%
Token::constructor 4,849 (+2) +0.04%
InclusionProofs::constructor 2,452 (+1) +0.04%
TokenBlacklist::get_roles 2,588 (+1) +0.04%
NFT::owner_of 2,591 (+1) +0.04%
Spam::public_spam 2,617 (+1) +0.04%
TokenBlacklist::_increase_public_balance 2,660 (+1) +0.04%
Token::_increase_public_balance 2,660 (+1) +0.04%
FPC::constructor 2,859 (+1) +0.03%
Uniswap::constructor 2,859 (+1) +0.03%
EasyPrivateVoting::public_dispatch 5,719 (+2) +0.03%
Auth::constructor 2,884 (+1) +0.03%
FeeJuice::public_dispatch 5,895 (+2) +0.03%
PrivateFPC::constructor 2,965 (+1) +0.03%
Lending::init 2,979 (+1) +0.03%
EasyPrivateVoting::constructor 3,022 (+1) +0.03%
AuthRegistry::consume 3,037 (+1) +0.03%
TokenBridge::constructor 3,041 (+1) +0.03%
Claim::constructor 3,074 (+1) +0.03%
NFT::mint 3,125 (+1) +0.03%
Token::mint_private 3,263 (+1) +0.03%
Token::mint_public 3,298 (+1) +0.03%
Crowdfunding::init 3,324 (+1) +0.03%
AppSubscription::constructor 3,471 (+1) +0.03%
AuthRegistry::public_dispatch 7,984 (+2) +0.03%
TokenBlacklist::mint_private 4,069 (+1) +0.02%
TokenBlacklist::mint_public 4,322 (+1) +0.02%
CardGame::on_game_joined 4,833 (+1) +0.02%
Lending::get_position 4,867 (+1) +0.02%
Auth::public_dispatch 10,184 (+2) +0.02%
Lending::update_accumulator 5,379 (+1) +0.02%
Auth::set_authorized_delay 5,637 (+1) +0.02%
Auth::set_authorized 5,717 (+1) +0.02%
CardGame::on_card_played 5,718 (+1) +0.02%
CardGame::start_game 6,821 (+1) +0.01%
CardGame::on_cards_claimed 7,133 (+1) +0.01%
TokenBlacklist::update_roles 7,268 (+1) +0.01%
TokenBlacklist::constructor 7,497 (+1) +0.01%
CardGame::public_dispatch 15,848 (+2) +0.01%
AvmTest::bulk_testing 24,946 (-15) -0.06%
TokenBlacklist::public_dispatch 23,961 (-31) -0.13%
Token::public_dispatch 31,602 (-45) -0.14%
NFT::public_dispatch 24,949 (-45) -0.18%
NFT::_finalize_transfer_to_private_unsafe 6,128 (-12) -0.20%
NFT::finalize_transfer_to_private 6,097 (-12) -0.20%
Crowdfunding::public_dispatch 5,868 (-12) -0.20%
Token::complete_refund 5,694 (-12) -0.21%
TestLog::public_dispatch 3,142 (-12) -0.38%
TokenBlacklist::shield 6,020 (-32) -0.53%
TokenBlacklist::transfer_public 5,881 (-32) -0.54%
Lending::_repay 5,729 (-32) -0.56%
DocsExample::public_dispatch 5,495 (-31) -0.56%
TokenBlacklist::burn_public 5,474 (-32) -0.58%
AvmTest::public_dispatch 57,338 (-340) -0.59%
Token::shield 4,890 (-32) -0.65%
TestLog::emit_unencrypted_events 1,753 (-12) -0.68%
Benchmarking::broadcast 1,861 (-13) -0.69%
Token::transfer_public 4,461 (-32) -0.71%
Token::burn_public 4,349 (-32) -0.73%
NFT::transfer_in_public 3,434 (-32) -0.92%
Crowdfunding::_publish_donation_receipts 1,271 (-12) -0.94%
Parent::public_nested_static_call 3,167 (-31) -0.97%
Lending::_deposit 2,817 (-32) -1.12%
StaticChild::public_dispatch 2,840 (-40) -1.39%
AvmTest::emit_unencrypted_log 2,837 (-40) -1.39%
Test::public_dispatch 18,729 (-313) -1.64%
Child::pub_inc_value_internal 758 (-13) -1.69%
StaticChild::pub_illegal_inc_value 753 (-13) -1.70%
AuthWitTest::public_dispatch 1,767 (-31) -1.72%
Child::pub_inc_value 728 (-13) -1.75%
StaticChild::pub_inc_value 728 (-13) -1.75%
Uniswap::public_dispatch 23,661 (-478) -1.98%
ImportTest::public_dispatch 1,466 (-31) -2.07%
Lending::public_dispatch 26,511 (-568) -2.10%
Test::emit_unencrypted 1,582 (-40) -2.47%
Test::consume_mint_public_message 9,942 (-272) -2.66%
AvmTest::returndata_copy_oracle 1,844 (-55) -2.90%
AvmTest::debug_logging 1,232 (-38) -2.99%
TokenBridge::public_dispatch 20,976 (-718) -3.31%
Uniswap::_assert_token_is_same 924 (-32) -3.35%
AvmTest::revert_oracle 375 (-13) -3.35%
Test::consume_message_from_arbitrary_sender_public 7,424 (-259) -3.37%
DocsExample::get_shared_immutable_constrained_public_indirect 897 (-32) -3.44%
TokenBridge::_call_mint_on_token 850 (-32) -3.63%
AvmTest::nested_call_to_assert_same 849 (-32) -3.63%
AvmTest::nested_static_call_to_add 849 (-32) -3.63%
AvmTest::nested_call_to_add 849 (-32) -3.63%
StaticParent::public_get_value_from_child 835 (-32) -3.69%
AvmTest::nested_call_to_add_with_gas 824 (-32) -3.74%
Uniswap::swap_public 14,609 (-584) -3.84%
Child::pub_set_value 332 (-14) -4.05%
StaticChild::pub_set_value 332 (-14) -4.05%
Child::set_value_twice_with_nested_last 1,080 (-46) -4.09%
Child::set_value_twice_with_nested_first 1,080 (-46) -4.09%
Parent::public_dispatch 7,859 (-338) -4.12%
TokenBridge::exit_to_l1_public 7,502 (-392) -4.97%
StatefulTest::public_dispatch 7,301 (-391) -5.08%
Child::public_dispatch 5,398 (-308) -5.40%
Lending::_borrow 8,017 (-458) -5.40%
Lending::_withdraw 8,261 (-476) -5.45%
TokenBridge::claim_public 11,277 (-665) -5.57%
FPC::public_dispatch 8,456 (-502) -5.60%
AuthWitTest::consume_public 517 (-33) -6.00%
Parent::pub_entry_point 489 (-33) -6.32%
StaticParent::public_call 489 (-33) -6.32%
AvmTest::create_different_nullifier_in_nested_call 435 (-33) -7.05%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 5,687 (-434) -7.09%
Parent::pub_entry_point_twice 860 (-66) -7.13%
AvmTest::create_same_nullifier_in_nested_call 425 (-33) -7.21%
StaticParent::public_dispatch 6,508 (-508) -7.24%
ImportTest::pub_call_public_fn 420 (-33) -7.28%
AvmTest::nested_static_call_to_set_storage 419 (-33) -7.30%
Benchmarking::public_dispatch 5,018 (-405) -7.47%
Child::set_value_with_two_nested_calls 954 (-80) -7.74%
StatefulTest::public_constructor 3,222 (-392) -10.85%
Benchmarking::increment_balance 3,105 (-392) -11.21%
StaticParent::public_nested_static_call 1,856 (-409) -18.06%
Lending::deposit_public 1,928 (-453) -19.03%
Lending::repay_public 1,822 (-444) -19.59%
Parent::public_static_call 845 (-207) -19.68%
StaticParent::public_static_call 845 (-207) -19.68%
FPC::pay_refund 1,449 (-411) -22.10%
FPC::prepare_fee 1,410 (-411) -22.57%
Lending::withdraw_public 1,336 (-411) -23.53%
Lending::borrow_public 1,336 (-411) -23.53%
FPC::pay_refund_with_shielded_rebate 1,197 (-393) -24.72%

@ludamad ludamad enabled auto-merge (squash) October 30, 2024 16:29
just-mitch
just-mitch reviewed Oct 30, 2024
View reviewed changes
spartan/aztec-network/templates/validator.yaml
@@ -130,6 +130,8 @@ spec:
value: {{ include "aztec-network.otelCollectorMetricsEndpoint" . | quote }}
- name: OTEL_EXPORTER_OTLP_TRACES_ENDPOINT
value: {{ include "aztec-network.otelCollectorTracesEndpoint" . | quote }}
- name: OTEL_EXPORTER_OTLP_LOGS_ENDPOINT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add the above to the prover node yaml.

@ludamad ludamad merged commit fd974e1 into master Oct 30, 2024
59 checks passed
@ludamad ludamad deleted the ad/metrics-working branch October 30, 2024 18:03
@AztecBot AztecBot mentioned this pull request Oct 30, 2024
Merged
rahul-kothari pushed a commit that referenced this pull request Nov 1, 2024
@AztecBot
chore(master): Release 0.62.0 (#9583)
edf6389 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.62.0</summary>

##
[0.62.0](aztec-package-v0.61.0...aztec-package-v0.62.0)
(2024-11-01)


### Features

* Token private mint optimization
([#9606](#9606))
([e8fadc7](e8fadc7))


### Bug Fixes

* **k8s:** Boot node long sync
([#9610](#9610))
([1b85840](1b85840))
* Multi-node metrics working
([#9486](#9486))
([fd974e1](fd974e1))
* Stop bot in case of tx errors
([#9421](#9421))
([6650641](6650641))


### Miscellaneous

* Replacing unshield naming with transfer_to_public
([#9608](#9608))
([247e9eb](247e9eb))
* Token partial notes refactor pt. 1
([#9490](#9490))
([3d631f5](3d631f5))
</details>

<details><summary>barretenberg.js: 0.62.0</summary>

##
[0.62.0](barretenberg.js-v0.61.0...barretenberg.js-v0.62.0)
(2024-11-01)


### Features

* Faster square roots
([#2694](#2694))
([722ec5c](722ec5c))
</details>

<details><summary>aztec-packages: 0.62.0</summary>

##
[0.62.0](aztec-packages-v0.61.0...aztec-packages-v0.62.0)
(2024-11-01)


### ⚠ BREAKING CHANGES

* **avm:** use 32 bit locations
([#9596](#9596))
* Unique L1 to L2 messages
([#9492](#9492))

### Features

* Add increment secret oracles
([#9573](#9573))
([97a4c0c](97a4c0c))
* **avm:** Use 32 bit locations
([#9596](#9596))
([5f38696](5f38696))
* Barebones addressbook for tagging
([#9572](#9572))
([6526069](6526069))
* Biggroup_goblin handles points at infinity + 1.8x reduction in ECCVM
size
([#9366](#9366))
([9211d8a](9211d8a))
* Faster square roots
([#2694](#2694))
([722ec5c](722ec5c))
* Fixed private log size
([#9585](#9585))
([755c70a](755c70a))
* Removing register recipient in e2e tests as it is unnecessary now !
([#9499](#9499))
([9f52cbb](9f52cbb))
* Reorg test
([#9607](#9607))
([54488b3](54488b3))
* Simulate validateEpochProofQuoteHeader in the future
([#9641](#9641))
([284c8f8](284c8f8))
* Spartan proving
([#9584](#9584))
([392114a](392114a))
* Sync tagged logs
([#9595](#9595))
([0cc4a48](0cc4a48))
* Token private mint optimization
([#9606](#9606))
([e8fadc7](e8fadc7))
* Unique L1 to L2 messages
([#9492](#9492))
([4e5ae95](4e5ae95)),
closes
[#9450](#9450)


### Bug Fixes

* E2e event logs test
([#9621](#9621))
([737c573](737c573))
* E2e labels
([#9609](#9609))
([ed1deb9](ed1deb9))
* Ensuring translator range constraint polynomials are zeroes outside of
minicircuit
([#9251](#9251))
([04dd2c4](04dd2c4))
* EventMetadata class implementation for serialisation
([#9574](#9574))
([bdff73a](bdff73a))
* Force bb-sanitizers true
([#9614](#9614))
([39cda86](39cda86))
* **k8s:** Boot node long sync
([#9610](#9610))
([1b85840](1b85840))
* Multi-node metrics working
([#9486](#9486))
([fd974e1](fd974e1))
* Remove all register recipient functionality in ts
([#9548](#9548))
([2f7127b](2f7127b))
* Remove unnecessary ivpk references in ts
([#9463](#9463))
([0c5121f](0c5121f))
* Resolution of bugs from bigfield audits
([#9547](#9547))
([feace70](feace70))
* Stop bot in case of tx errors
([#9421](#9421))
([6650641](6650641))
* Typing of artifacts
([#9581](#9581))
([c71645f](c71645f))


### Miscellaneous

* Add guides to get_e2e_jobs.sh
([#9624](#9624))
([8891ead](8891ead))
* Add sender to encode and encrypt
([#9562](#9562))
([8ce6834](8ce6834))
* Add signed int deserialization to decoder
([#9557](#9557))
([0435d00](0435d00))
* Bb sanitizers on master
([#9564](#9564))
([747bff1](747bff1))
* Cleaning up token test utils
([#9633](#9633))
([325bdb0](325bdb0))
* Disable breaking e2e_event_logs test
([#9602](#9602))
([cf2ca2e](cf2ca2e))
* Dont generate vks for simulated circuits
([#9625](#9625))
([366eff3](366eff3))
* Fixing broken sample-dapp tests
([#9597](#9597))
([5e52900](5e52900))
* Nuking `Token::privately_mint_private_note(...)`
([#9616](#9616))
([bf53f5e](bf53f5e))
* Pass on docker_fast.sh
([#9615](#9615))
([1c53459](1c53459))
* Remove outgoing tagging field in logs
([#9502](#9502))
([c473380](c473380))
* Replace relative paths to noir-protocol-circuits
([288099b](288099b))
* Replacing unshield naming with transfer_to_public
([#9608](#9608))
([247e9eb](247e9eb))
* Token partial notes refactor pt. 1
([#9490](#9490))
([3d631f5](3d631f5))
</details>

<details><summary>barretenberg: 0.62.0</summary>

##
[0.62.0](barretenberg-v0.61.0...barretenberg-v0.62.0)
(2024-11-01)


### ⚠ BREAKING CHANGES

* **avm:** use 32 bit locations
([#9596](#9596))

### Features

* **avm:** Use 32 bit locations
([#9596](#9596))
([5f38696](5f38696))
* Biggroup_goblin handles points at infinity + 1.8x reduction in ECCVM
size
([#9366](#9366))
([9211d8a](9211d8a))
* Faster square roots
([#2694](#2694))
([722ec5c](722ec5c))
* Spartan proving
([#9584](#9584))
([392114a](392114a))


### Bug Fixes

* Ensuring translator range constraint polynomials are zeroes outside of
minicircuit
([#9251](#9251))
([04dd2c4](04dd2c4))
* Resolution of bugs from bigfield audits
([#9547](#9547))
([feace70](feace70))


### Miscellaneous

* Bb sanitizers on master
([#9564](#9564))
([747bff1](747bff1))
* Pass on docker_fast.sh
([#9615](#9615))
([1c53459](1c53459))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Nov 2, 2024
@AztecBot
chore(master): Release 0.62.0 (#9583)
7b583d3 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.62.0</summary>

##
[0.62.0](AztecProtocol/aztec-packages@aztec-package-v0.61.0...aztec-package-v0.62.0)
(2024-11-01)


### Features

* Token private mint optimization
([#9606](AztecProtocol/aztec-packages#9606))
([e8fadc7](AztecProtocol/aztec-packages@e8fadc7))


### Bug Fixes

* **k8s:** Boot node long sync
([#9610](AztecProtocol/aztec-packages#9610))
([1b85840](AztecProtocol/aztec-packages@1b85840))
* Multi-node metrics working
([#9486](AztecProtocol/aztec-packages#9486))
([fd974e1](AztecProtocol/aztec-packages@fd974e1))
* Stop bot in case of tx errors
([#9421](AztecProtocol/aztec-packages#9421))
([6650641](AztecProtocol/aztec-packages@6650641))


### Miscellaneous

* Replacing unshield naming with transfer_to_public
([#9608](AztecProtocol/aztec-packages#9608))
([247e9eb](AztecProtocol/aztec-packages@247e9eb))
* Token partial notes refactor pt. 1
([#9490](AztecProtocol/aztec-packages#9490))
([3d631f5](AztecProtocol/aztec-packages@3d631f5))
</details>

<details><summary>barretenberg.js: 0.62.0</summary>

##
[0.62.0](AztecProtocol/aztec-packages@barretenberg.js-v0.61.0...barretenberg.js-v0.62.0)
(2024-11-01)


### Features

* Faster square roots
([#2694](AztecProtocol/aztec-packages#2694))
([722ec5c](AztecProtocol/aztec-packages@722ec5c))
</details>

<details><summary>aztec-packages: 0.62.0</summary>

##
[0.62.0](AztecProtocol/aztec-packages@aztec-packages-v0.61.0...aztec-packages-v0.62.0)
(2024-11-01)


### ⚠ BREAKING CHANGES

* **avm:** use 32 bit locations
([#9596](AztecProtocol/aztec-packages#9596))
* Unique L1 to L2 messages
([#9492](AztecProtocol/aztec-packages#9492))

### Features

* Add increment secret oracles
([#9573](AztecProtocol/aztec-packages#9573))
([97a4c0c](AztecProtocol/aztec-packages@97a4c0c))
* **avm:** Use 32 bit locations
([#9596](AztecProtocol/aztec-packages#9596))
([5f38696](AztecProtocol/aztec-packages@5f38696))
* Barebones addressbook for tagging
([#9572](AztecProtocol/aztec-packages#9572))
([6526069](AztecProtocol/aztec-packages@6526069))
* Biggroup_goblin handles points at infinity + 1.8x reduction in ECCVM
size
([#9366](AztecProtocol/aztec-packages#9366))
([9211d8a](AztecProtocol/aztec-packages@9211d8a))
* Faster square roots
([#2694](AztecProtocol/aztec-packages#2694))
([722ec5c](AztecProtocol/aztec-packages@722ec5c))
* Fixed private log size
([#9585](AztecProtocol/aztec-packages#9585))
([755c70a](AztecProtocol/aztec-packages@755c70a))
* Removing register recipient in e2e tests as it is unnecessary now !
([#9499](AztecProtocol/aztec-packages#9499))
([9f52cbb](AztecProtocol/aztec-packages@9f52cbb))
* Reorg test
([#9607](AztecProtocol/aztec-packages#9607))
([54488b3](AztecProtocol/aztec-packages@54488b3))
* Simulate validateEpochProofQuoteHeader in the future
([#9641](AztecProtocol/aztec-packages#9641))
([284c8f8](AztecProtocol/aztec-packages@284c8f8))
* Spartan proving
([#9584](AztecProtocol/aztec-packages#9584))
([392114a](AztecProtocol/aztec-packages@392114a))
* Sync tagged logs
([#9595](AztecProtocol/aztec-packages#9595))
([0cc4a48](AztecProtocol/aztec-packages@0cc4a48))
* Token private mint optimization
([#9606](AztecProtocol/aztec-packages#9606))
([e8fadc7](AztecProtocol/aztec-packages@e8fadc7))
* Unique L1 to L2 messages
([#9492](AztecProtocol/aztec-packages#9492))
([4e5ae95](AztecProtocol/aztec-packages@4e5ae95)),
closes
[#9450](AztecProtocol/aztec-packages#9450)


### Bug Fixes

* E2e event logs test
([#9621](AztecProtocol/aztec-packages#9621))
([737c573](AztecProtocol/aztec-packages@737c573))
* E2e labels
([#9609](AztecProtocol/aztec-packages#9609))
([ed1deb9](AztecProtocol/aztec-packages@ed1deb9))
* Ensuring translator range constraint polynomials are zeroes outside of
minicircuit
([#9251](AztecProtocol/aztec-packages#9251))
([04dd2c4](AztecProtocol/aztec-packages@04dd2c4))
* EventMetadata class implementation for serialisation
([#9574](AztecProtocol/aztec-packages#9574))
([bdff73a](AztecProtocol/aztec-packages@bdff73a))
* Force bb-sanitizers true
([#9614](AztecProtocol/aztec-packages#9614))
([39cda86](AztecProtocol/aztec-packages@39cda86))
* **k8s:** Boot node long sync
([#9610](AztecProtocol/aztec-packages#9610))
([1b85840](AztecProtocol/aztec-packages@1b85840))
* Multi-node metrics working
([#9486](AztecProtocol/aztec-packages#9486))
([fd974e1](AztecProtocol/aztec-packages@fd974e1))
* Remove all register recipient functionality in ts
([#9548](AztecProtocol/aztec-packages#9548))
([2f7127b](AztecProtocol/aztec-packages@2f7127b))
* Remove unnecessary ivpk references in ts
([#9463](AztecProtocol/aztec-packages#9463))
([0c5121f](AztecProtocol/aztec-packages@0c5121f))
* Resolution of bugs from bigfield audits
([#9547](AztecProtocol/aztec-packages#9547))
([feace70](AztecProtocol/aztec-packages@feace70))
* Stop bot in case of tx errors
([#9421](AztecProtocol/aztec-packages#9421))
([6650641](AztecProtocol/aztec-packages@6650641))
* Typing of artifacts
([#9581](AztecProtocol/aztec-packages#9581))
([c71645f](AztecProtocol/aztec-packages@c71645f))


### Miscellaneous

* Add guides to get_e2e_jobs.sh
([#9624](AztecProtocol/aztec-packages#9624))
([8891ead](AztecProtocol/aztec-packages@8891ead))
* Add sender to encode and encrypt
([#9562](AztecProtocol/aztec-packages#9562))
([8ce6834](AztecProtocol/aztec-packages@8ce6834))
* Add signed int deserialization to decoder
([#9557](AztecProtocol/aztec-packages#9557))
([0435d00](AztecProtocol/aztec-packages@0435d00))
* Bb sanitizers on master
([#9564](AztecProtocol/aztec-packages#9564))
([747bff1](AztecProtocol/aztec-packages@747bff1))
* Cleaning up token test utils
([#9633](AztecProtocol/aztec-packages#9633))
([325bdb0](AztecProtocol/aztec-packages@325bdb0))
* Disable breaking e2e_event_logs test
([#9602](AztecProtocol/aztec-packages#9602))
([cf2ca2e](AztecProtocol/aztec-packages@cf2ca2e))
* Dont generate vks for simulated circuits
([#9625](AztecProtocol/aztec-packages#9625))
([366eff3](AztecProtocol/aztec-packages@366eff3))
* Fixing broken sample-dapp tests
([#9597](AztecProtocol/aztec-packages#9597))
([5e52900](AztecProtocol/aztec-packages@5e52900))
* Nuking `Token::privately_mint_private_note(...)`
([#9616](AztecProtocol/aztec-packages#9616))
([bf53f5e](AztecProtocol/aztec-packages@bf53f5e))
* Pass on docker_fast.sh
([#9615](AztecProtocol/aztec-packages#9615))
([1c53459](AztecProtocol/aztec-packages@1c53459))
* Remove outgoing tagging field in logs
([#9502](AztecProtocol/aztec-packages#9502))
([c473380](AztecProtocol/aztec-packages@c473380))
* Replace relative paths to noir-protocol-circuits
([288099b](AztecProtocol/aztec-packages@288099b))
* Replacing unshield naming with transfer_to_public
([#9608](AztecProtocol/aztec-packages#9608))
([247e9eb](AztecProtocol/aztec-packages@247e9eb))
* Token partial notes refactor pt. 1
([#9490](AztecProtocol/aztec-packages#9490))
([3d631f5](AztecProtocol/aztec-packages@3d631f5))
</details>

<details><summary>barretenberg: 0.62.0</summary>

##
[0.62.0](AztecProtocol/aztec-packages@barretenberg-v0.61.0...barretenberg-v0.62.0)
(2024-11-01)


### ⚠ BREAKING CHANGES

* **avm:** use 32 bit locations
([#9596](AztecProtocol/aztec-packages#9596))

### Features

* **avm:** Use 32 bit locations
([#9596](AztecProtocol/aztec-packages#9596))
([5f38696](AztecProtocol/aztec-packages@5f38696))
* Biggroup_goblin handles points at infinity + 1.8x reduction in ECCVM
size
([#9366](AztecProtocol/aztec-packages#9366))
([9211d8a](AztecProtocol/aztec-packages@9211d8a))
* Faster square roots
([#2694](AztecProtocol/aztec-packages#2694))
([722ec5c](AztecProtocol/aztec-packages@722ec5c))
* Spartan proving
([#9584](AztecProtocol/aztec-packages#9584))
([392114a](AztecProtocol/aztec-packages@392114a))


### Bug Fixes

* Ensuring translator range constraint polynomials are zeroes outside of
minicircuit
([#9251](AztecProtocol/aztec-packages#9251))
([04dd2c4](AztecProtocol/aztec-packages@04dd2c4))
* Resolution of bugs from bigfield audits
([#9547](AztecProtocol/aztec-packages#9547))
([feace70](AztecProtocol/aztec-packages@feace70))


### Miscellaneous

* Bb sanitizers on master
([#9564](AztecProtocol/aztec-packages#9564))
([747bff1](AztecProtocol/aztec-packages@747bff1))
* Pass on docker_fast.sh
([#9615](AztecProtocol/aztec-packages#9615))
([1c53459](AztecProtocol/aztec-packages@1c53459))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just-mitch just-mitch just-mitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use winston for opentelemetry logging
2 participants
@ludamad @just-mitch