-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add canPruneAtTime #9751
feat: add canPruneAtTime #9751
Conversation
I thought about making this change here when I added it to the quote validation stuff, but had a concern: Suppose you're in the beginning of slot 12 of an epoch, and no proof quote has been claimed. Doesn't this change make it so that if a proof does land after I look, I've already unwound? But considering further, even if that does happen, it should just rebuild the chain, so maybe it is fine? Regardless, it almost seems like the current behavior is the correct one? |
I don't get what you say? If it lands after you looked, it landed after it should be pruned. There should be no time for a proof to land in between you looking and it pruning? If we can do that, it is an inconsistency in the flow, e.g., a bug. Looking at This nicely shows why #7868 is needed. Doing the change breaks 0 tests, so something is missing. Some of the tests also state they check pruning but don't actually do any pruning. |
15db211
to
73a89d1
Compare
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
A minor change to help on #9308. Instead of the archiver using the current time, it will use the time of the next ethereum block.
Also addresses an issue, where it would be possible to submit a proof for blocks that should have been pruned, but have not yet been because of no new publications.