Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated outputs for Private FQDN & Private DNS Zone #563

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Updated outputs for Private FQDN & Private DNS Zone #563

merged 4 commits into from
Mar 29, 2023

Conversation

owainow
Copy link
Contributor

@owainow owainow commented Mar 28, 2023 •
edited by Gordonby
Loading

PR Summary

Added bicep outputs for Private FQDN & Private DNS Zone.
This will allow the private dns zone to be more easily linked to other virtual networks.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@owainow owainow mentioned this pull request Mar 28, 2023
Closed
5 tasks
@owainow owainow added test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge labels Mar 28, 2023
@owainow owainow closed this Mar 28, 2023
@owainow owainow reopened this Mar 28, 2023
@Gordonby
Copy link
Collaborator

The language expression property 'privateFQDN' doesn't exist

So this property is dynamic. If ternary operator condition will need to be based off an input parameter rather than the emptiness of a property that may or may not exist.

@owainow owainow closed this Mar 29, 2023
@owainow owainow reopened this Mar 29, 2023
@owainow owainow enabled auto-merge (squash) March 29, 2023 08:38
Gordonby
Gordonby requested changes Mar 29, 2023
View reviewed changes
bicep/main.bicep Outdated Show resolved Hide resolved
@owainow owainow temporarily deployed to csu March 29, 2023 09:07 — with GitHub Actions Inactive
@owainow owainow closed this Mar 29, 2023
auto-merge was automatically disabled March 29, 2023 10:14

Pull request was closed

@owainow owainow reopened this Mar 29, 2023
@owainow owainow temporarily deployed to csu March 29, 2023 10:47 — with GitHub Actions Inactive
Gordonby
Gordonby approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gordonby Gordonby merged commit b5f58e3 into main Mar 29, 2023
@Gordonby Gordonby deleted the new_private_dns_outputs branch March 29, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gordonby Gordonby Gordonby approved these changes

Assignees
No one assigned
Labels
test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owainow @Gordonby