Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated outputs for Private FQDN & Private DNS Zone #563

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Updated outputs for Private FQDN & Private DNS Zone #563

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88200b5
Updated outputs for Private FQDN & Private DNS Zone
Mar 28, 2023
5184d0f
Updated if condition to be based on input param.
Mar 29, 2023
8f6881d
Updated to more complex operator condition.
Mar 29, 2023
0a71a29
Merge branch 'main' into new_private_dns_outputs
owainow Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bicep/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,9 @@ var aks_addons1 = ingressApplicationGateway ? union(aks_addons, deployAppGw ? {
@description('Sets the private dns zone id if provided')
var aksPrivateDnsZone = privateClusterDnsMethod=='privateDnsZone' ? (!empty(dnsApiPrivateZoneId) ? dnsApiPrivateZoneId : 'system') : privateClusterDnsMethod
output aksPrivateDnsZone string = aksPrivateDnsZone
output privateFQDN string = enablePrivateCluster && privateClusterDnsMethod != 'none' ? aks.properties.privateFQDN : ''
// Dropping cluster name at start of privateFQDN to get private dns zone name.
output aksPrivateDnsZoneName string = enablePrivateCluster && privateClusterDnsMethod != 'none' ? join(skip(split(aks.properties.privateFQDN, '.'),1),'.') : ''

@description('Needing to seperately declare and union this because of https://github.com/Azure/AKS-Construction/issues/344')
var managedNATGatewayProfile = {
Expand Down