-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated regions and VM SKUs available in Helper UI, and changed default SKU selections #705
Conversation
- Updated region list to include all current regions - Updated SKU families to include latest v5 and remove oldest v2 - Updated generate-vm-sku-list.sh logic to pick correct storage parameter for ephemeral storage
- Updated cost optimised clusters to use Standard_B4s_v2, and performance clusters to Standard_D8ds_v4 - Updated workflows to use current gen VM SKUs Standard_D4ds_v5
…align more closely with the Portal
…-Construction into paullewis-regions-skus
…o try and address build issues
Updated workflow to use in-branch version of AksDeploy-Basic.parameters.json isntead of hosted version (which won't be up-to-date with any changes in current branch)
…en effect as this is pulled from the latest published release rather than in-branch
…s to fail until changes in this PR get published.
Over to you @samaea to review before merging :) LMK if you want a quick call to run through the changes |
I think at least part of the problem with this change is that with the
I pushed a change to update the I have also reverted the API version to |
…h for PRs - Reverted AKS API version to 2024-01-01
`unknown field \\\"natGatewayProfile\\\" Check that the field is in the right location, is spelled correctly, and is supported in the API version`
- Reverting previous changes to `managedNATGatewayProfile` JSON snippets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
PR Summary
PR Checklist
List of regions:
List of VM SKUs: