Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated regions and VM SKUs available in Helper UI, and changed default SKU selections #705

Merged
merged 35 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
fd019a1
- Updated K8s version to current default
pjlewisuk Aug 7, 2024
fa060bc
- Updated default system and user node SKU to use Standard_D4ds_v5
pjlewisuk Aug 7, 2024
be265db
- Changed default node pool names to "agentpool" and "userpool01" to …
pjlewisuk Aug 7, 2024
3b8eb83
- Changed default OS disk size to 128 GB (to match portal behaviour)
pjlewisuk Aug 7, 2024
b42a742
- Updated default Kubernetes versions in main.bicep and other JSON co…
pjlewisuk Aug 7, 2024
48f0a3a
Adding userpool and agentpool to spell expections
pjlewisuk Aug 7, 2024
8b14d85
Merge branch 'main' into paullewis-regions-skus
pjlewisuk Aug 8, 2024
84b1b7e
Reverting managedClusters API version
pjlewisuk Aug 8, 2024
5a8495a
Merge branch 'paullewis-regions-skus' of https://github.com/Azure/AKS…
pjlewisuk Aug 8, 2024
09dfd3a
Updated aksOutboundTrafficType from natGateway to managedNatGateway t…
pjlewisuk Aug 8, 2024
f7d67ba
Updated aksOutboundTrafficType to loadBalancer to try and address bui…
pjlewisuk Aug 8, 2024
88149a9
Changed managedClusters API version to 2023-11-01
pjlewisuk Aug 8, 2024
628d916
Changed 'natGateway' to 'managedNatGateway' to align with current exa…
pjlewisuk Aug 8, 2024
cf197a8
Changed 'natGateway' to 'managedNATGateway' to align with current API…
pjlewisuk Aug 8, 2024
c953131
Updated another reference to natGateway
pjlewisuk Aug 8, 2024
cac7d97
Reverting to 0.10.4 as reverting to API version 2023-11-01 hasn't tak…
pjlewisuk Aug 8, 2024
189e8f6
Enclosing `natGatewayProfile` in `networkProfile` key
pjlewisuk Aug 8, 2024
974c89f
Pointing workflow at local parameter file to reflect changes in local…
pjlewisuk Aug 8, 2024
2d9233d
Pointing workflow at local parameter file to reflect changes in local…
pjlewisuk Aug 8, 2024
f8b4121
Pointing workflow at local parameter file to reflect changes in local…
pjlewisuk Aug 8, 2024
c7a0efa
Pointing workflow at local parameter file to reflect changes in local…
pjlewisuk Aug 8, 2024
4563b58
Temporarily pointing to this working branch for testing
pjlewisuk Aug 8, 2024
108a56d
Reverting to 0.10.5 as 0.10.4 contains a parameter thats been removed…
pjlewisuk Aug 8, 2024
1151d92
Reverting ParamFile to the file on main branch. This will cause build…
pjlewisuk Aug 8, 2024
05ec33d
- Added branch variable to allow workflows to build off current branc…
pjlewisuk Aug 9, 2024
14330c5
- Added branch variable to allow workflows to build off current branc…
pjlewisuk Aug 9, 2024
b615b61
- Added branch variable to allow workflows to build off current branc…
pjlewisuk Aug 9, 2024
7ff49d6
- Reverting change from natGateway to managedNATGateway, back to natG…
pjlewisuk Aug 9, 2024
78f2abf
- Reverting change from natGateway to managedNATGateway, back to natG…
pjlewisuk Aug 9, 2024
f7cdd6b
- Trying to fix the error about the natGatewayProfile:
pjlewisuk Aug 9, 2024
92ce3d0
Enclosing `natGatewayProfile` in `networkProfile` key
pjlewisuk Aug 9, 2024
418a8f1
- Commenting out problematic code for testing
pjlewisuk Aug 9, 2024
f88131f
Merge branch 'main' into paullewis-regions-skus
pjlewisuk Aug 9, 2024
0ebae28
- Changed default outbound type to loadBalancer for pipeline tests
pjlewisuk Aug 9, 2024
93dcf15
Merge branch 'main' into paullewis-regions-skus
pjlewisuk Aug 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows_dep/AksDeploy-Basic.parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"value": 1
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"enable_aad": {
"value": true
Expand All @@ -39,7 +39,7 @@
"value": "Standard"
},
"aksOutboundTrafficType" : {
"value": "natGateway"
"value": "loadBalancer"
}
}
}
2 changes: 1 addition & 1 deletion .github/workflows_dep/AksDeploy-ByoVnet.parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"value": 1
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows_dep/AksDeploy-Private.parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"value": "priv"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 2
Expand Down Expand Up @@ -93,7 +93,7 @@
"value": true
},
"aksOutboundTrafficType" : {
"value": "natGateway"
"value": "managedNATGateway"
},
"createNatGateway" : {
"value": true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/byoKms.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-kmsbyopub"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"JustUseSystemPool": {
"value": true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-kmsbyopl"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"JustUseSystemPool": {
"value": true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"value": "WestCentralUs"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"networkDataplane": {
"value": "cilium"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"value": 1
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/dapr.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-dapr"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"daprAddon": {
"value": true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/defender.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"value": "az-k8s-def"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/edgeK8sVersion.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-edged"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"kubernetesVersion": {
"value": "1.26.3"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/gitOps.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-flux"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"fluxGitOpsAddon": {
"value": true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"value": 1
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 5
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-3zb3"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 20
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/managed-public.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "manpub"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows_dep/regressionparams/managedNatGw.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"value": "az-k8s-natgw"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"aksOutboundTrafficType" : {
"value": "natGateway"
"value": "managedNATGateway"
},
"natGwIpCount" : {
"value": 3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/open-secure.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-4chu"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"custom_vnet": {
"value": true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"value": "Standard"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 20
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/publicKms.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-kmspp1"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"JustUseSystemPool": {
"value": true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"value": 0
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
},
"agentCountMax": {
"value": 3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows_dep/regressionparams/simple-simple.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "az-k8s-7zw4"
},
"agentVMSize": {
"value": "Standard_DS3_v2"
"value": "Standard_D4ds_v5"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"value": 1
},
"agentVMSize": {
"value": "Standard_B2ms"
"value": "Standard_B2s_v2"
},
"agentCountMax": {
"value": 2
Expand Down
4 changes: 2 additions & 2 deletions bicep/aksagentpool.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ var spotProperties = {
// Default OS Disk Size in GB for Linux is 30, for Windows is 100
var defaultOsDiskSizeGB = osType == 'Linux' ? 30 : 100

resource aks 'Microsoft.ContainerService/managedClusters@2024-01-01' existing = {
resource aks 'Microsoft.ContainerService/managedClusters@2023-11-01' existing = {
name: AksName
}

resource userNodepool 'Microsoft.ContainerService/managedClusters/agentPools@2024-01-01' = {
resource userNodepool 'Microsoft.ContainerService/managedClusters/agentPools@2023-11-01' = {
parent: aks
name: PoolName
properties: union({
Expand Down
2 changes: 1 addition & 1 deletion bicep/automationrunbook/aksRbac.bicep
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
param principalId string
param aksName string

resource aks 'Microsoft.ContainerService/managedClusters@2024-01-01' existing = {
resource aks 'Microsoft.ContainerService/managedClusters@2023-11-01' existing = {
name: aksName
}

Expand Down
34 changes: 18 additions & 16 deletions bicep/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,7 @@ output ApplicationGatewayName string = deployAppGw ? appgw.name : ''
param dnsPrefix string = '${resourceName}-dns'

@description('Kubernetes Version')
param kubernetesVersion string = '1.28.5'
param kubernetesVersion string = '1.29.7'

@description('Enable Azure AD integration on AKS')
param enable_aad bool = false
Expand Down Expand Up @@ -904,7 +904,7 @@ param upgradeChannel string = 'none'
param osDiskType string = 'Ephemeral'

@description('VM SKU')
param agentVMSize string = 'Standard_DS3_v2'
param agentVMSize string = 'Standard_D4ds_v5'

@description('Disk size in GB')
param osDiskSizeGB int = 0
Expand All @@ -919,7 +919,7 @@ var autoScale = agentCountMax > agentCount
@minLength(3)
@maxLength(12)
@description('Name for user node pool')
param nodePoolName string = 'npuser01'
param nodePoolName string = 'userpool01'

@description('Config the user node pool as a spot instance')
param nodePoolSpot bool = false
Expand Down Expand Up @@ -1057,7 +1057,7 @@ param AutoscaleProfile object = {

@allowed([
'loadBalancer'
'natGateway'
'managedNATGateway'
'userDefinedRouting'
])
@description('Outbound traffic type for the egress traffic of your cluster')
Expand Down Expand Up @@ -1123,20 +1123,20 @@ var serviceMeshProfileObj = {
}

@description('This resolves the friendly natGateway to the actual outbound traffic type value used by AKS')
var outboundTrafficType = aksOutboundTrafficType=='natGateway' ? ( custom_vnet ? 'userAssignedNATGateway' : 'managedNATGateway' ) : aksOutboundTrafficType
var outboundTrafficType = aksOutboundTrafficType=='managedNATGateway' ? ( custom_vnet ? 'userAssignedNATGateway' : 'managedNATGateway' ) : aksOutboundTrafficType

@description('System Pool presets are derived from the recommended system pool specs')
var systemPoolPresets = {
CostOptimised : {
vmSize: 'Standard_B4ms'
vmSize: 'Standard_B4s_v2'
count: 1
minCount: 1
maxCount: 3
enableAutoScaling: true
availabilityZones: []
}
Standard : {
vmSize: 'Standard_DS2_v2'
vmSize: 'Standard_D4ds_v5'
count: 3
minCount: 3
maxCount: 5
Expand All @@ -1148,7 +1148,7 @@ var systemPoolPresets = {
]
}
HighSpec : {
vmSize: 'Standard_D4s_v3'
vmSize: 'Standard_D8ds_v4'
count: 3
minCount: 3
maxCount: 5
Expand All @@ -1162,7 +1162,7 @@ var systemPoolPresets = {
}

var systemPoolBase = {
name: JustUseSystemPool ? nodePoolName : 'npsystem'
name: JustUseSystemPool ? nodePoolName : 'agentpool'
vmSize: agentVMSize
count: agentCount
mode: 'System'
Expand All @@ -1183,7 +1183,7 @@ var systemPoolBase = {
var agentPoolProfiles = JustUseSystemPool ? array(systemPoolBase) : concat(array(union(systemPoolBase, SystemPoolType=='Custom' && SystemPoolCustomPreset != {} ? SystemPoolCustomPreset : systemPoolPresets[SystemPoolType])))

output userNodePoolName string = nodePoolName
output systemNodePoolName string = JustUseSystemPool ? nodePoolName : 'npsystem'
output systemNodePoolName string = JustUseSystemPool ? nodePoolName : 'agentpool'

var akssku = AksPaidSkuForSLA ? 'Standard' : 'Free'

Expand Down Expand Up @@ -1244,11 +1244,13 @@ output aksPrivateDnsZoneName string = enablePrivateCluster && privateClusterDns

pjlewisuk marked this conversation as resolved.
Show resolved Hide resolved
@description('Needing to seperately declare and union this because of https://github.com/Azure/AKS-Construction/issues/344')
var managedNATGatewayProfile = {
natGatewayProfile : {
managedOutboundIPProfile: {
count: natGwIpCount
networkProfile: {
natGatewayProfile : {
managedOutboundIPProfile: {
count: natGwIpCount
}
idleTimeoutInMinutes: natGwIdleTimeout
}
idleTimeoutInMinutes: natGwIdleTimeout
}
}

Expand Down Expand Up @@ -1335,7 +1337,7 @@ keyVaultKmsCreateAndPrereqs || !empty(keyVaultKmsByoKeyId) ? azureKeyVaultKms :
!empty(serviceMeshProfile) ? { serviceMeshProfile: serviceMeshProfileObj } : {}
)

resource aks 'Microsoft.ContainerService/managedClusters@2024-01-01' = {
resource aks 'Microsoft.ContainerService/managedClusters@2023-11-01' = {
name: 'aks-${resourceName}'
location: location
properties: aksProperties
Expand Down Expand Up @@ -1375,7 +1377,7 @@ param osSKU string = 'Ubuntu'
var poolName = osType == 'Linux' ? nodePoolName : take(nodePoolName, 6)

// Default OS Disk Size in GB for Linux is 30, for Windows is 100
var defaultOsDiskSizeGB = osType == 'Linux' ? 30 : 100
var defaultOsDiskSizeGB = 128

module userNodePool '../bicep/aksagentpool.bicep' = if (!JustUseSystemPool){
name: take('${deployment().name}-userNodePool',64)
Expand Down
2 changes: 2 additions & 0 deletions cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"aadgroupids",
"accv",
"ACRNAME",
"agentpool",
"AGIC",
"aksc",
"aksvnetparams",
Expand Down Expand Up @@ -138,6 +139,7 @@
"updatevals",
"urlname",
"userauth",
"userpool",
"valres",
"vaultname",
"VNET",
Expand Down
2 changes: 1 addition & 1 deletion helper/.playwrighttests/helper-test-managednatgw.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test('managed-natgw-option-is-now-the-prod-default', async ({ page }) => {
await page.waitForSelector('[data-testid="deploy-deploycmd"]')
const clitextbox = await page.$('[data-testid="deploy-deploycmd"]')
await expect(clitextbox).toBeVisible()
await expect(clitextbox).not.toContainText('natGateway')
await expect(clitextbox).not.toContainText('managedNATGateway')

});

Expand Down
4 changes: 2 additions & 2 deletions helper/src/components/clusterTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default function ({ defaults, tabValues, updateFn, featureFlag, invalidAr
console.log (`maxCount=${newp.maxCount} MIN=${MAXCOUNT_MIN}`)

if(newp.SystemPoolType!=='none' && !cluster.nodepoolName){
cluster.nodepoolName = 'npuser01'
cluster.nodepoolName = 'userpool01'
}

if (newp.maxCount < MAXCOUNT_MIN) {
Expand Down Expand Up @@ -165,7 +165,7 @@ export default function ({ defaults, tabValues, updateFn, featureFlag, invalidAr
onChange={(val, range) => sliderUpdateFn(cluster.autoscale ? {agentCount: range[0], maxCount: range[1]} : {agentCount: val})} />

<TextField
placeholder='npuser01'
placeholder='userpool01'
label="Node pool name"
maxLength={cluster.osType==='Windows' ? 6 : 12}
onChange={(ev, val) => updateFn('nodepoolName', val)}
Expand Down
Loading
Loading