Fix for DPs not loading in tab when task change not detected #1511
Conversation
| @@ -30,7 +30,8 @@ export class TaskDependencyBrowserComponent implements OnChanges { | |||
| this._tasks.clear(); | |||
| } | |||
|
|
|||
| if (changes.jobId || ComponentUtils.recordChangedId(changes.task)) { | |||
| // Task initially loaded with no dedendsOn. Change to task properties was not handled here. | |||
| if (changes.jobId || ComponentUtils.recordChangedId(changes.task) || changes.task) { | |||
There was a problem hiding this comment.
hhm, I don't think so, here it will recompute every time the task change(which is every 5 seconds as it polls for a new one)
There was a problem hiding this comment.
ok, need something to trigger the first time its reloaded then. The first time there are no DPs, second time they are there. I could do something with the InitialChange or FirstChange or whatever that property is called. Or add the task change to another conditional that only executes once.
There was a problem hiding this comment.
yeah so maybe there is a bug in recordChangedId because that should have triggered I believe
There was a problem hiding this comment.
recordChangedId only seems to care about the task ID changing. Not the properties of the task.
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
+ Coverage 60.75% 60.75% +<.01%
==========================================
Files 1070 1070
Lines 25064 25068 +4
Branches 3456 3458 +2
==========================================
+ Hits 15228 15231 +3
- Misses 9836 9837 +1
Continue to review full report at Codecov.
|
| @@ -30,12 +30,18 @@ export class TaskDependencyBrowserComponent implements OnChanges { | |||
| this._tasks.clear(); | |||
| } | |||
|
|
|||
| if (changes.jobId || ComponentUtils.recordChangedId(changes.task)) { | |||
| // Task initially loaded with no dedendsOn. Change to task properties was not handled here. | |||
| if (changes.jobId || ComponentUtils.recordChangedId(changes.task) || this._hasUnloadedDependencies) { | |||
| this._loaded = 0; | |||
There was a problem hiding this comment.
This only gets called twice now if it needs to be. The first time and the next time if there was a change in the DP property
|
confirmed that this is now fixed. |
No description provided.