Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DPs not loading in tab when task change not detected #1511

Merged
merged 5 commits into from
Jul 30, 2018
Merged

Fix for DPs not loading in tab when task change not detected #1511

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e38239
fix for DPs not loading in tab when task change not detected
ascobie Jul 27, 2018
77af155
stop being called for every task refresh
ascobie Jul 30, 2018
f364be7
Merge branch 'master' into fix/dependancy-status-css
timotheeguerin Jul 30, 2018
560809c
Check for other attributes
timotheeguerin Jul 30, 2018
a852c91
Fix table style
timotheeguerin Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/components/task/details/task-dependency-browser/task-dependency-browser.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ export class TaskDependencyBrowserComponent implements OnChanges {
this._tasks.clear();
}

if (changes.jobId || ComponentUtils.recordChangedId(changes.task)) {
// Task initially loaded with no dedendsOn. Change to task properties was not handled here.
if (changes.jobId || ComponentUtils.recordChangedId(changes.task) || changes.task) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tim, is this OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hhm, I don't think so, here it will recompute every time the task change(which is every 5 seconds as it polls for a new one)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, need something to trigger the first time its reloaded then. The first time there are no DPs, second time they are there. I could do something with the InitialChange or FirstChange or whatever that property is called. Or add the task change to another conditional that only executes once.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah so maybe there is a bug in recordChangedId because that should have triggered I believe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recordChangedId only seems to care about the task ID changing. Not the properties of the task.

this._loaded = 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only gets called twice now if it needs to be. The first time and the next time if there was a change in the DP property

this._refresh(this.task);
}
Expand Down