Disable Auto-update #2139
Disable Auto-update #2139
Conversation
|
Why is this needed? There is a settings that disable auto update on quit already. |
Codecov Report
@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
+ Coverage 65.13% 65.13% +<.01%
==========================================
Files 898 898
Lines 25698 25701 +3
Branches 5066 5067 +1
==========================================
+ Hits 16739 16741 +2
- Misses 8959 8960 +1
Continue to review full report at Codecov.
|
Merge master into stable for release 2.5.0
| @@ -68,6 +68,11 @@ export async function startBatchExplorer(args: BatchExplorerArgs) { | |||
| app.commandLine.appendSwitch("ignore-certificate-errors", "true"); | |||
| } | |||
|
|
|||
| if (args.doNotAutoupdate) { | |||
| log.warn("Application will not autoupdate"); | |||
| autoUpdater.autoInstallOnAppQuit = false; | |||
There was a problem hiding this comment.
Should likelymake this both set this and update config
|
A little confused by the point of having this flag. Do you expect user to start BatchExplorer from the command line with the flag just to not be able to auto update? |
* Changed naming for cmdline flag
|
@timotheeguerin Yes, the goal is to allow users to use this flag to disable auto-update when opening the app for an instance. I've noted your other suggestions mentioned offline and will revisit them. |
|
Fixes #2152 |
Setting a command line flag to disable auto-update upon application launch.