Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into stable for release 2.5.0 #2144

Merged
merged 12 commits into from
Dec 12, 2019
Merged

Merge master into stable for release 2.5.0 #2144

merged 12 commits into from
Dec 12, 2019

Conversation

bgklein
Copy link
Contributor

@bgklein bgklein commented Dec 12, 2019

No description provided.

cRui861 and others added 12 commits November 1, 2019 15:01
Merging Stable into Master
* Error message details opened by default

* Hide error details

* Minor fix (#2122)
* Fix duration picker bugs

* Update test

* Update test

* fix dependency
* Fix caret toggling for error display

* minor fix
* duration changes and cleanup

* minor fixes

* cleanup

* minor fix
* Update list fetch to follow empty responses

* remove extra import

* Update to switchmap

* lint

* special case first page as it goes through special logic
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #2144 into stable will increase coverage by <.01%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #2144      +/-   ##
==========================================
+ Coverage   65.13%   65.13%   +<.01%     
==========================================
  Files         898      898              
  Lines       25694    25701       +7     
  Branches     5065     5067       +2     
==========================================
+ Hits        16735    16741       +6     
- Misses       8959     8960       +1
Impacted Files Coverage Δ
src/@batch-flask/core/record/decorators.ts 89.65% <ø> (-0.97%) ⬇️
...ob/action/add/job-release-task-picker.component.ts 38.46% <ø> (ø) ⬆️
.../components/node/connect/node-connect.component.ts 90.9% <ø> (ø) ⬆️
src/app/models/forms/create-account-model.ts 0% <ø> (ø) ⬆️
...ction/add/job-preparation-task-picker.component.ts 33.33% <0%> (ø) ⬆️
...nt/action/create/batch-account-create.component.ts 68.91% <0%> (ø) ⬆️
...ervices/batch-account/arm-batch-account.service.ts 42.99% <0%> (ø) ⬆️
src/@batch-flask/core/constants.ts 100% <100%> (ø) ⬆️
src/@batch-flask/ui/banner/banner.component.ts 82.6% <100%> (ø) ⬆️
src/app/models/constraints.ts 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149ebd6...85437d3. Read the comment docs.

@bgklein bgklein merged commit be7ef3a into stable Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants