Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report -Existing Management Group #1080

Closed
aj-msft opened this issue Oct 12, 2022 · 6 comments · Fixed by #1094
Closed

Bug Report -Existing Management Group #1080

aj-msft opened this issue Oct 12, 2022 · 6 comments · Fixed by #1094
Assignees
Labels
documentation Improvements or additions to documentation engineering engineering work enhancement New feature or request Needs: Attention 👋 Needs attention from the maintainers Status: Fixed

Comments

@aj-msft
Copy link

aj-msft commented Oct 12, 2022

Existing Management Group with the same name under the Root Tenant gets moved while running the Accelerator

Steps to reproduce

  1. Create MG named "ELZ-Corp" under root tenant
  2. Move subscriptions under the newly created MG
  3. Run the Accelerator deployment and specify the prefix as ELZ.
  4. Leave the existing name for Corp as is and run the accelerator
  5. The Landing zone deployment would have moved the initially created "ELZ-Corp" Management Group along with the subscription to the newly created Landing zone that was built using the accelerator.

This is an issue as customers who have existing Management Group with the same name as what is specified within the Accelerator could face issues when the MG and subscriptions are moved under the new Landing zone and policies are applied. It would be good to see a warning if there are any MG groups with the same name already present in the customer environment.

@aj-msft aj-msft added the bug Something isn't working label Oct 12, 2022
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Oct 12, 2022
@jtracey93
Copy link
Collaborator

Hey @aj-msft,

Good find.

What would you want the error message to say and where would you like it to appear?

We can then get this implemented.

We can make this a dynamic warning though it would just be a generic warning displayed all the time. As in the portal experience we cannot do any pre-validation I'm afraid. The error would look similar to this on the MG blade:
image

@jtracey93 jtracey93 added documentation Improvements or additions to documentation enhancement New feature or request Needs: Author Feedback and removed Needs: Triage 🔍 Needs triaging by the team labels Oct 13, 2022
@aj-msft
Copy link
Author

aj-msft commented Oct 17, 2022

Hey @jtracey93

Thanks for getting back to me.

A warning along the lines stating that any existing management groups with the same name as what is specified in the Accelerator deployment would be moved to the new Landing zone would suffice if it were displayed in the validation screen.

Thanks
Ajay

@ghost ghost added Needs: Attention 👋 Needs attention from the maintainers and removed Needs: Author Feedback labels Oct 17, 2022
@jtracey93
Copy link
Collaborator

Hey @aj-msft we cannot make this appear on the validation screen, as this is a screen that is provided by the underlying service used for custom portal experiences.

However, we can make it appear on the "Azure core" tab/page, would that be sufficient?

Let us know

Thanks

Jack

@jtracey93 jtracey93 added Needs: Author Feedback and removed bug Something isn't working Needs: Attention 👋 Needs attention from the maintainers labels Oct 18, 2022
@ghost
Copy link

ghost commented Oct 23, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days.

@jtracey93
Copy link
Collaborator

Hey @aj-msft,

Any thoughts on my last suggestion (#1080 (comment))?

Let us know

Thanks

Jack

@aj-msft
Copy link
Author

aj-msft commented Oct 24, 2022

Hi @jtracey93,

Would it be possible to add it to the tabs where Management Groups are created (Platform, Azure Core, Landing Zone etc) ?
If so, that would be great.

Regards
Ajay

@ghost ghost added Needs: Attention 👋 Needs attention from the maintainers and removed Needs: Author Feedback labels Oct 24, 2022
@jtracey93 jtracey93 self-assigned this Oct 25, 2022
@jtracey93 jtracey93 added the engineering engineering work label Oct 25, 2022
jtracey93 added a commit that referenced this issue Oct 25, 2022
* fixes for 1080

* jf review comment
@ghost ghost added the Status: Fixed label Oct 25, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation engineering engineering work enhancement New feature or request Needs: Attention 👋 Needs attention from the maintainers Status: Fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants