Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FAQ & Portal Warning for #1080 #1094

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Add FAQ & Portal Warning for #1080 #1094

merged 2 commits into from
Oct 25, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Oct 25, 2022 •
edited
Loading

Overview/Summary

Add FAQ & Portal Warning for #1080

This PR fixes/adds/changes/removes

  1. Fixes Bug Report -Existing Management Group #1080
    • Add 2 new FAQs
    • Add Warning Note to ALZ Portal Experience linking to FAQ

Breaking Changes

None

Testing Evidence

image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jtracey93 jtracey93 requested a review from a team as a code owner October 25, 2022 08:11
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Oct 25, 2022
@jtracey93 jtracey93 added documentation Improvements or additions to documentation enhancement New feature or request engineering engineering work and removed Needs: Triage 🔍 Needs triaging by the team labels Oct 25, 2022
jfaurskov
jfaurskov suggested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from comment looks good

@ghost ghost removed the Needs: Author Feedback label Oct 25, 2022
@jtracey93 jtracey93 temporarily deployed to csu-rw October 25, 2022 08:31 Inactive
jfaurskov
jfaurskov approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit d35199a into Azure:main Oct 25, 2022
@jtracey93 jtracey93 deleted the fix-1080 branch October 25, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaurskov jfaurskov jfaurskov approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation engineering engineering work enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report -Existing Management Group
2 participants
@jtracey93 @jfaurskov