Overlay ECMP with BFD support #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prsunny
commented
Sep 10, 2021
•
prsunny
commented
- Vxlan based overlay ECMP
- Reference to BFD HLD
- Implementation PRs:
- [vnetorch] Add ECMP support for vnet tunnel routes sonic-swss#1960
- [bgpcfgd] Add bgpcfgd support to advertise routes sonic-buildimage#9197
- Add support for overlay ECMP sonic-restapi#96
- [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor sonic-swss#1955
- Add support for BFD notification sonic-sairedis#903
- [bfdorch] Orchagent support hardware BFD sonic-swss#1883
- Add show command for BFD sessions sonic-utilities#1942
- [vnetorch] Advertise vnet tunnel routes sonic-swss#2058
- Add test cases for hardware BFD sonic-mgmt#4992 [BFD]
- Automating VxLAN Test Cases for T1 and T1-Lag: TC1 sonic-mgmt#4954
- VxLAN Automation: Adding all remaining testcases, and the required modifications. sonic-mgmt#5059
Vxlan Overlay ECMP BFD orchagent and HW support
doc/vxlan/Overlay ECMP with BFD.md
Outdated
| - Better performance in re-programming routes in ASIC instead of separate process to monitor and modify each route prefix by updating DB entries | ||
|
|
||
| ### BfdOrch | ||
| Sonic may offload the BFD session handling to hardware that has BFD capabilities. A new module, BfdOrch shall be introduced to handle BFD session to monitoring endpoints and check the health of remote endpoints. BfdOrch shall offload the session initiation/sustenance to hardware via SAI APIs and gets the notifications of session state from SAI. The session state shall be updated in STATE_DB and to any other observer orchestration agents. |
There was a problem hiding this comment.
The path from SYNCD to ORCH is quite slow, in such cases the BFD state notification from SYNCD to BFDOrch may add a delta to the desired BFD timeout. The actual BFD timeout achieved may be significantly higher than desired timeout.
prsunny
changed the title
dgsudharsan
reviewed
Sep 14, 2021
|
All the comments have been addressed and need reviewer to approve |
shi-su
previously approved these changes
Oct 19, 2021
rameshsanth
reviewed
Nov 3, 2021
shi-su
approved these changes
Dec 4, 2021
shi-su
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.