Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add e2e test for openshift vnet #2991

Closed
wants to merge 1 commit into from
Closed

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented May 16, 2018

What this PR does / why we need it:
Add e2e test for Openshift with vnet

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

@ghost ghost assigned ritazh May 16, 2018
@ghost ghost added the in progress label May 16, 2018
@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #2991 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2991      +/-   ##
==========================================
+ Coverage   50.71%   50.75%   +0.04%     
==========================================
  Files          97       97              
  Lines       14687    14682       -5     
==========================================
+ Hits         7448     7452       +4     
+ Misses       6539     6533       -6     
+ Partials      700      697       -3
Impacted Files Coverage Δ
pkg/acsengine/defaults.go 83.56% <0%> (+0.03%) ⬆️
pkg/acsengine/transform/transform.go 63.17% <0%> (+0.12%) ⬆️
pkg/api/vlabs/validate.go 45.88% <0%> (+0.18%) ⬆️
pkg/acsengine/engine.go 62.59% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6457e15...b8e45d4. Read the comment docs.

@CecileRobertMichon
Copy link
Contributor

/lgtm

@CecileRobertMichon
Copy link
Contributor

/approve

@acs-bot
Copy link

acs-bot commented May 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot
Copy link

acs-bot commented May 18, 2018

New changes are detected. LGTM label has been removed.

@0xmichalis
Copy link
Contributor

/hold

I think this should be a separate test vs updating the existing test.

@jim-minter @pweil-

@0xmichalis
Copy link
Contributor

Fixes #2985

@0xmichalis
Copy link
Contributor

We are flakying a lot on #2982

@jim-minter
Copy link
Member

I agree this should be a separate test.
@ritazh please cc @jim-minter @Kargakis @pweil- on openshift-related PRs

@kwoodson
Copy link
Contributor

@ritazh, could you rebase and fix the conflicts for this PR? Thanks!

@jim-minter
Copy link
Member

@kwoodson this needs to be an additional test, not replacing the existing one - can you open a new PR based on Rita's work to take this forward?

@kwoodson
Copy link
Contributor

@jim-minter @ritazh

I have added #3274 to take the place of this PR. Feel free to comment there.

@kwoodson kwoodson closed this Jun 14, 2018
@ghost ghost removed the in progress label Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants