-
Notifications
You must be signed in to change notification settings - Fork 560
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2991 +/- ##
==========================================
+ Coverage 50.71% 50.75% +0.04%
==========================================
Files 97 97
Lines 14687 14682 -5
==========================================
+ Hits 7448 7452 +4
+ Misses 6539 6533 -6
+ Partials 700 697 -3
Continue to review full report at Codecov.
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
/hold I think this should be a separate test vs updating the existing test. |
Fixes #2985 |
We are flakying a lot on #2982 |
I agree this should be a separate test. |
@ritazh, could you rebase and fix the conflicts for this PR? Thanks! |
@kwoodson this needs to be an additional test, not replacing the existing one - can you open a new PR based on Rita's work to take this forward? |
I have added #3274 to take the place of this PR. Feel free to comment there. |
What this PR does / why we need it:
Add e2e test for Openshift with vnet
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #