Adding OpenShift e2e test for existing vnet. #3274
Conversation
ghost
assigned 
kwoodson
changed the title
|
looks good so far, I guess you need to get that vnet created and values substituted into the json file before acs-engine reads it? |
|
@ritazh @CecileRobertMichon, Is there a way to verify this circleci test before merging? I attempted to run it locally but ran into some issues with the DNSPrefix. If you could kindly instruct what the next step here it would be appreciated. Thanks! |
|
@kwoodson it's running as part of the PR at https://circleci.com/gh/Azure/acs-engine/32522 I think it's not showing in the GitHub PR checks below because we have too many tests + it's not selected as required in repo settings |
kwoodson
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3274 +/- ##
=========================================
- Coverage 52.62% 52.6% -0.02%
=========================================
Files 104 104
Lines 15579 15575 -4
=========================================
- Hits 8198 8194 -4
Misses 6649 6649
Partials 732 732 |
|
@CecileRobertMichon, I believe this is ready to merge. Please review. Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, kwoodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* 'master' of https://github.com/Azure/acs-engine: (44 commits) remove duplicate ebtables (Azure#3308) Kubernetes: Remove Windows-specific foo for control plane config (Azure#3240) add k8s 1.8.14 (Azure#3303) run /usr/lib/apt/apt.systemd.daily in background (Azure#3304) add annotation to secrets field (Azure#3292) fix(oms): pull oms directly from docker (Azure#3294) ensure params vals are bool, with test (Azure#3285) udpate to latest 16.04 LTS image (Azure#3286) Enable openshift e2e tests on centos (Azure#2910) remove docker dependency from hyperkube extract (Azure#3296) remove pathological test (Azure#3291) Refactor validateDNSPrefix function in one place (Azure#3276) remove unnecessary nil check (Azure#3290) Fixing panic issue in Validate when properties are nil (Azure#3242) Updating the omsagent yaml file to include new changes for node zero dependency (Azure#3277) revert Azure CNI to 1.0.4 (Azure#3289) Add e2e test for openshift vnet (Azure#3274) Support upgrading a Kubernetes cluster that contains Virtual Machine Scale Sets (Azure#3223) Set extension for custom DNS (Azure#3264) don't exit CSE on apt.systemd.daily error (Azure#3278) ...
Adding a test for deploying an openshift cluster with an existing vnet.