don't exit CSE on apt.systemd.daily error #3278
Conversation
ghost
assigned 
| @@ -177,7 +177,7 @@ function installDocker() { | |||
| } | |||
|
|
|||
| function runAptDaily() { | |||
| retrycmd_if_failure 20 30 60 /usr/lib/apt/apt.systemd.daily || exit $ERR_APT_DAILY_TIMEOUT | |||
| /usr/lib/apt/apt.systemd.daily | |||
There was a problem hiding this comment.
should we keep the retry there? So that it catches transient behaviors? Or maybe keep it but reduce the number of retries
There was a problem hiding this comment.
I think we should fire and forget once. If there is a reservation on an apt lock while this is requested, for example, we should defer to letting apt.system.daily do its thing according to its regular schedule. In other words, the idea is that CSE runs apt.systemd.daily as a convenience, but not as a requirement.
Codecov Report
@@ Coverage Diff @@
## master #3278 +/- ##
=========================================
- Coverage 53.31% 52.62% -0.7%
=========================================
Files 104 104
Lines 15574 15579 +5
=========================================
- Hits 8304 8198 -106
- Misses 6537 6649 +112
+ Partials 733 732 -1 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* 'master' of https://github.com/Azure/acs-engine: (44 commits) remove duplicate ebtables (Azure#3308) Kubernetes: Remove Windows-specific foo for control plane config (Azure#3240) add k8s 1.8.14 (Azure#3303) run /usr/lib/apt/apt.systemd.daily in background (Azure#3304) add annotation to secrets field (Azure#3292) fix(oms): pull oms directly from docker (Azure#3294) ensure params vals are bool, with test (Azure#3285) udpate to latest 16.04 LTS image (Azure#3286) Enable openshift e2e tests on centos (Azure#2910) remove docker dependency from hyperkube extract (Azure#3296) remove pathological test (Azure#3291) Refactor validateDNSPrefix function in one place (Azure#3276) remove unnecessary nil check (Azure#3290) Fixing panic issue in Validate when properties are nil (Azure#3242) Updating the omsagent yaml file to include new changes for node zero dependency (Azure#3277) revert Azure CNI to 1.0.4 (Azure#3289) Add e2e test for openshift vnet (Azure#3274) Support upgrading a Kubernetes cluster that contains Virtual Machine Scale Sets (Azure#3223) Set extension for custom DNS (Azure#3264) don't exit CSE on apt.systemd.daily error (Azure#3278) ...
What this PR does / why we need it: Run apt.systemd.daily but don't fail CSE on a transient error
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: