Support upgrading a Kubernetes cluster that contains Virtual Machine Scale Sets #3223
Conversation
|
@trstringer: GitHub didn't allow me to request PR reviews from the following users: trstringer. Note that only Azure members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
trstringer
changed the title
|
/assign @CecileRobertMichon |
|
Thanks so much @trstringer, will begin testing! |
Codecov Report
@@ Coverage Diff @@
## master #3223 +/- ##
=========================================
- Coverage 52.66% 52.06% -0.6%
=========================================
Files 103 103
Lines 15505 15691 +186
=========================================
+ Hits 8165 8169 +4
- Misses 6600 6778 +178
- Partials 740 744 +4 |
|
/lgtm Thanks @trstringer! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, trstringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* 'master' of https://github.com/Azure/acs-engine: (44 commits) remove duplicate ebtables (Azure#3308) Kubernetes: Remove Windows-specific foo for control plane config (Azure#3240) add k8s 1.8.14 (Azure#3303) run /usr/lib/apt/apt.systemd.daily in background (Azure#3304) add annotation to secrets field (Azure#3292) fix(oms): pull oms directly from docker (Azure#3294) ensure params vals are bool, with test (Azure#3285) udpate to latest 16.04 LTS image (Azure#3286) Enable openshift e2e tests on centos (Azure#2910) remove docker dependency from hyperkube extract (Azure#3296) remove pathological test (Azure#3291) Refactor validateDNSPrefix function in one place (Azure#3276) remove unnecessary nil check (Azure#3290) Fixing panic issue in Validate when properties are nil (Azure#3242) Updating the omsagent yaml file to include new changes for node zero dependency (Azure#3277) revert Azure CNI to 1.0.4 (Azure#3289) Add e2e test for openshift vnet (Azure#3274) Support upgrading a Kubernetes cluster that contains Virtual Machine Scale Sets (Azure#3223) Set extension for custom DNS (Azure#3264) don't exit CSE on apt.systemd.daily error (Azure#3278) ...
What this PR does / why we need it: this PR will add support for upgrading (
acs-engine upgrade) a Kubernetes cluster that includes one or more virtual machine scale sets for their agent pools.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #3122Special notes for your reviewer: this is currently a work in progress
Release note:
// cc @sozercan