remove docker dependency from hyperkube extract #3296
Conversation
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
ghost
assigned 
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
jessfraz
force-pushed
the
remove-hyperkube-extract
branch
from
718b219
to
9f410da
Compare
Codecov Report
@@ Coverage Diff @@
## master #3296 +/- ##
=======================================
Coverage 52.87% 52.87%
=======================================
Files 104 104
Lines 15714 15714
=======================================
Hits 8308 8308
Misses 6671 6671
Partials 735 735 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jessfraz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
thanks @CecileRobertMichon |
* 'master' of https://github.com/Azure/acs-engine: (44 commits) remove duplicate ebtables (Azure#3308) Kubernetes: Remove Windows-specific foo for control plane config (Azure#3240) add k8s 1.8.14 (Azure#3303) run /usr/lib/apt/apt.systemd.daily in background (Azure#3304) add annotation to secrets field (Azure#3292) fix(oms): pull oms directly from docker (Azure#3294) ensure params vals are bool, with test (Azure#3285) udpate to latest 16.04 LTS image (Azure#3286) Enable openshift e2e tests on centos (Azure#2910) remove docker dependency from hyperkube extract (Azure#3296) remove pathological test (Azure#3291) Refactor validateDNSPrefix function in one place (Azure#3276) remove unnecessary nil check (Azure#3290) Fixing panic issue in Validate when properties are nil (Azure#3242) Updating the omsagent yaml file to include new changes for node zero dependency (Azure#3277) revert Azure CNI to 1.0.4 (Azure#3289) Add e2e test for openshift vnet (Azure#3274) Support upgrading a Kubernetes cluster that contains Virtual Machine Scale Sets (Azure#3223) Set extension for custom DNS (Azure#3264) don't exit CSE on apt.systemd.daily error (Azure#3278) ...
|
Why removing condition 'if [[ "$CONTAINER_RUNTIME" == "clear-containers" ]] || [[ "$CONTAINER_RUNTIME" == "containerd" ]]; from 'installContainerd'? If user is using another runtime, is it supposed to download containerd binary? |
|
Seems 'img pull' has some dependency on it, shall we turn to 'docker pull' if runtime is set to docker? |
|
it has a dep on runc which docker does as well so its relative, there is no point in having a different command that is only tested under certain scenarios it would give more likely hood for failure |
doing this in parts til I find the dns issue in #2973