Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

don't exit CSE on apt.systemd.daily error #3278

Merged
merged 1 commit into from
Jun 15, 2018
Merged

don't exit CSE on apt.systemd.daily error #3278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parts/k8s/kubernetescustomscript.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ function installDocker() {
}

function runAptDaily() {
retrycmd_if_failure 20 30 60 /usr/lib/apt/apt.systemd.daily || exit $ERR_APT_DAILY_TIMEOUT
/usr/lib/apt/apt.systemd.daily
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep the retry there? So that it catches transient behaviors? Or maybe keep it but reduce the number of retries

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fire and forget once. If there is a reservation on an apt lock while this is requested, for example, we should defer to letting apt.system.daily do its thing according to its regular schedule. In other words, the idea is that CSE runs apt.systemd.daily as a convenience, but not as a requirement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

function generateAggregatedAPICerts() {
Expand Down