Generate correct docstrings for paging and LRO operations #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into improve_multiapi_lro_paging_docstring * 'autorestv3' of https://github.com/Azure/autorest.python: added generating wiki to readme for better access (#646) correct item name of paging response model (#648)
…into improve_multiapi_lro_paging_docstring * 'autorestv3' of https://github.com/Azure/autorest.python: LRO Continuation Token [need azure-core 1.6.0] (#565) fix http request verb to always be get for next operation if not defined (#664) Fix generation of pkgutil files (#661) deal with optional return types correctly (#656) include new testserver test for paging model whose item name has an x-ms-client-name (#654)
iscai-msft
commented
Jun 4, 2020
| @@ -452,15 +452,15 @@ async def get_not_provided( | |||
| async def get_base64_encoded( | |||
| self, | |||
| **kwargs | |||
| ) -> bytearray: | |||
| ) -> bytes: | |||
There was a problem hiding this comment.
These changes from bytearray to bytes are due to this testserver change
lmazuel
approved these changes
Jun 4, 2020
iscai-msft
added a commit
that referenced
this pull request
Jun 12, 2020
…into add_nullable_to_validation_map * 'autorestv3' of https://github.com/Azure/autorest.python: (59 commits) Support other auth policies (#686) correct return type for head operations (#680) update mypy.ini (#670) import models in operation group if there are just enums (#676) add type annotation for empty class model definitions in service client (#672) add type ignore to patch file import (#671) don't generate namespace test when generating individual swaggers (#683) Update package.json Update ChangeLog.md Fix stdin passthrough when running start.py through run-python3 (#678) update to latest testserver (#673) Add unicode test routes (#668) Generate correct docstrings for paging and LRO operations (#652) add missing license headers (#667) LRO Continuation Token [need azure-core 1.6.0] (#565) fix http request verb to always be get for next operation if not defined (#664) Fix generation of pkgutil files (#661) deal with optional return types correctly (#656) include new testserver test for paging model whose item name has an x-ms-client-name (#654) added generating wiki to readme for better access (#646) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is both now generating the correct docstring for multiapi mixins, and it has also corrected the spacing of non-multiapi paging and LRO generation. Previously, the description would look like this, and it now looks like this