Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix http request verb to always be get for next operation if not defined #664

Merged
merged 6 commits into from
Jun 3, 2020

Conversation

iscai-msft
Copy link
Contributor

fixes #662

Here is the LRO paging swagger call, with the initial post call and next get (removed x-ms-long-running-operation from the testserver swagger to generate):
image

@iscai-msft iscai-msft requested a review from lmazuel June 3, 2020 20:37

Verified

This commit was signed with the committer’s verified signature.
@iscai-msft iscai-msft merged commit 86c1c0f into autorestv3 Jun 3, 2020
@iscai-msft iscai-msft deleted the fix_paging_next_http_verb branch June 3, 2020 21:57
iscai-msft added a commit that referenced this pull request Jun 4, 2020
…into improve_multiapi_lro_paging_docstring

* 'autorestv3' of https://github.com/Azure/autorest.python:
  LRO Continuation Token [need azure-core 1.6.0] (#565)
  fix http request verb to always be get for next operation if not defined (#664)
  Fix generation of pkgutil files (#661)
  deal with optional return types correctly (#656)
  include new testserver test for paging model whose item name has an x-ms-client-name (#654)
iscai-msft added a commit that referenced this pull request Jun 4, 2020
…into mypy_fixes_2

* 'autorestv3' of https://github.com/Azure/autorest.python:
  LRO Continuation Token [need azure-core 1.6.0] (#565)
  fix http request verb to always be get for next operation if not defined (#664)
  Fix generation of pkgutil files (#661)
iscai-msft added a commit that referenced this pull request Jun 4, 2020
…into add_unicode_test_routes

* 'autorestv3' of https://github.com/Azure/autorest.python:
  LRO Continuation Token [need azure-core 1.6.0] (#565)
  fix http request verb to always be get for next operation if not defined (#664)
  Fix generation of pkgutil files (#661)
iscai-msft added a commit that referenced this pull request Jun 12, 2020
…into add_nullable_to_validation_map

* 'autorestv3' of https://github.com/Azure/autorest.python: (59 commits)
  Support other auth policies (#686)
  correct return type for head operations (#680)
  update mypy.ini (#670)
  import models in operation group if there are just enums (#676)
  add type annotation for empty class model definitions in service client (#672)
  add type ignore to patch file import (#671)
  don't generate namespace test when generating individual swaggers (#683)
  Update package.json
  Update ChangeLog.md
  Fix stdin passthrough when running start.py through run-python3 (#678)
  update to latest testserver (#673)
  Add unicode test routes (#668)
  Generate correct docstrings for paging and LRO operations (#652)
  add missing license headers (#667)
  LRO Continuation Token [need azure-core 1.6.0] (#565)
  fix http request verb to always be get for next operation if not defined (#664)
  Fix generation of pkgutil files (#661)
  deal with optional return types correctly (#656)
  include new testserver test for paging model whose item name has an x-ms-client-name (#654)
  added generating wiki to readme for better access (#646)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants