Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Service Connector} Add quotation marks for cmd parameters in run_cli_cmd #7920

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

xfz11
Copy link
Member

@xfz11 xfz11 commented Aug 28, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 28, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @xfz11,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @xfz11,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 28, 2024

Service Connector passwordless

Copy link

github-actions bot commented Aug 28, 2024

@AllyW AllyW changed the title {Service Connector passwordless}: fix run_cli_cmd and add quotation marks {serviceconnector-passwordless} Fix run_cli_cmd and add quotation marks for cmd parameters Sep 3, 2024
@AllyW AllyW changed the title {serviceconnector-passwordless} Fix run_cli_cmd and add quotation marks for cmd parameters {Service Connector} Fix run_cli_cmd and add quotation marks for cmd parameters Sep 4, 2024
@AllyW AllyW changed the title {Service Connector} Fix run_cli_cmd and add quotation marks for cmd parameters {Service Connector} Add quotation marks for cmd parameters in run_cli_cmd Sep 4, 2024
@AllyW
Copy link
Member

AllyW commented Sep 4, 2024

Discussion under relevent pr: Azure/azure-cli#29798

@AllyW AllyW merged commit f80ba90 into Azure:main Sep 4, 2024
20 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 4, 2024

[Release] Update index.json for extension [ serviceconnector-passwordless ] : https://dev.azure.com/azclitools/release/_build/results?buildId=186737&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants