Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to Capacity Reservation resource to display maximum fault domain count supported #23414

Closed
hari-bodicherla opened this issue Aug 2, 2022 · 14 comments
Assignees
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request

Comments

@hari-bodicherla
Copy link

Related command

Is your feature request related to a problem? Please describe.
we currently support VMSS deployments against Capacity Reservation with FD count depending up on if the VM Size supports tenant spanning or not . So the max fd count will be 1 if tenant spanning doesnt exist for the vm size in the CR and if yes, max fd count will be 3. This is ok for now, but in feature, we need to restrict the fd count to 2 for some speciality skus due to vm sizes being special and capacity constraints issues in the regions. Due to this, we need a property which can be managed and populated from platform side and returned to customer. This will be readonly property for customer. So Customer or client tools like portal should know the max fd count that we support when using the specific capacity reservation. The proposed changes in this PR ensure we return the max fd count supported in the Get CR response which can be used by client tools and customers to decide if they can go ahead with the resource deployments with the CR.

Describe the solution you'd like
we are adding a readonly property which can be managed and populated from platform side and returned to customer. So Customer or client tools like portal should know the max fd count that we support when using the specific capacity reservation. The proposed changes in this PR ensure we return the max fd count supported in the Get CR response which can be used by client tools and customers to decide if they can go ahead with the resource deployments with the CR.

Describe alternatives you've considered
Customer can do trial and error on recieving the client or server errors to change the desired FD and vm size when using the Capacity Reservation group.

Additional context
I am not able to find any cmdlet for adding the param in the Get Capacity Reservation response. Please let me know if this review is not needed for the platform generated properties in the response.

@yonzhan yonzhan added Compute az vm/vmss/image/disk/snapshot feature-request labels Aug 2, 2022
@yonzhan yonzhan added this to the Aug 2022 (2022-09-06) milestone Aug 2, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 2, 2022

Compute

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Aug 3, 2022

@hari-bodicherla Could you please provide the Swagger PR link, the design of CLI commands and parameters, the minimum api-version required, and the expected ETA?

In addition, it is recommended that you use the [Microsoft Internal / Service Team] Feature Request to create internal feature requests, so we can better understand the information of this demand, like this feature request #22275
Screenshot 2022-08-03 104241

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Aug 3, 2022

@hari-bodicherla Could you please provide the Swagger PR link, the design of CLI commands and parameters, the minimum api-version required, and the expected ETA?

In addition, it is recommended that you use the [Microsoft Internal / Service Team] Feature Request to create internal feature requests, so we can better understand the information of this demand, like this feature request #22275 Screenshot 2022-08-03 104241

@zhoxing-ms Here are the Details

Swagger link: Azure/azure-rest-api-specs#20076

Design:
There wont be any change in the existing cmdlets , since this is a readonly property that is set by the Platform and return it in the response to customer for az capacity reservation show cmdlet.
The new readonly property is platform-fault-domain-count

Expected ETA:
Earliest Date for CLI release.

Minimum API version required:
2022-08-01

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Aug 8, 2022

@hari-bodicherla Currently, the latest version of Python SDK azure-mgmt-compute does not contain the folder of api-version 2022-08-01. And I see that the readme.py is not modified in this PR https://github.com/Azure/azure-rest-api-specs/pull/20076/files , so it can't release a new SDK package version for this api-version folder.
Please note that since CLI is dependent on the Python SDK, so please contact the python SDK team @msyyc to release a new SDK package version which containing the 2022-08-01 version folder first, thanks

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Aug 9, 2022 via email

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Aug 9, 2022 via email

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Aug 10, 2022 via email

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Aug 11, 2022 via email

@yonzhan yonzhan added the Azure CLI Team The command of the issue is owned by Azure CLI team label Aug 14, 2022
@hari-bodicherla
Copy link
Author

hari-bodicherla commented Aug 18, 2022 via email

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Oct 11, 2022 via email

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Oct 11, 2022 via email

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Oct 11, 2022 via email

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Mar 13, 2023 via email

@hari-bodicherla
Copy link
Author

hari-bodicherla commented Mar 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request
Projects
None yet
Development

No branches or pull requests

4 participants