Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM] Fix #19468: pip installs azure-cli 2.0.73 because of the dependency on deprecated jsmin #19495

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

zhoxing-ms
Copy link
Contributor

@zhoxing-ms zhoxing-ms commented Sep 9, 2021

Issue: #19468

Description

In order to solve the package conflict introduced by jsmin, the jsmin code is referenced into json_min()

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@zhoxing-ms zhoxing-ms requested a review from jsntcy as a code owner September 9, 2021 02:04
@zhoxing-ms zhoxing-ms requested a review from jiasli September 9, 2021 02:07
@zhoxing-ms zhoxing-ms changed the title [ARM] Fix the package conflict that use_2to3 is invalid introduced by jsmin [ARM] Fix the package install issue that use_2to3 is invalid introduced by jsmin Sep 9, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 9, 2021

ARM

@jiasli
Copy link
Member

jiasli commented Sep 9, 2021

Please include the the license of jsmin in NOTICE.txt, such as

azure-cli/NOTICE.txt

Lines 2663 to 2686 in c145c29

zipp 3.1.0 - MIT
Copyright Jason R. Coombs
Copyright Jason R. Coombs
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to
deal in the Software without restriction, including without limitation the
rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
sell copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
IN THE SOFTWARE.

@jiasli
Copy link
Member

jiasli commented Sep 9, 2021

We can just release for PyPI. But be careful we shouldn't push main branch, otherwise az upgrade from other packages like deb, rpm will check the version on main branch (#19191) and think there is an update but there is actually none. This will cause endless loop in certain conditions (#19196).

return outs.getvalue()


# pylint: disable=attribute-defined-outside-init, too-many-branches, too-many-statements, too-many-instance-attributes
Copy link
Member

@jiasli jiasli Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can disable all checks for the whole file with

# pylint: skip-file

Copy link
Contributor Author

@zhoxing-ms zhoxing-ms Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to put JSON related functions in this file in the future, so I just disable the pylint of this function for the time being

# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------


Copy link
Member

@jiasli jiasli Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zhoxing-ms zhoxing-ms changed the title [ARM] Fix the package install issue that use_2to3 is invalid introduced by jsmin [ARM] Fix #19468: pip installs azure-cli 2.0.73 because of the dependency on deprecated jsmin Sep 9, 2021
@jiasli
Copy link
Member

jiasli commented Sep 23, 2021

Kind reminder: tikitu/jsmin#34 has been merged and jsmin 3.0.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants