Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Bump PyGithub #20041

Merged
merged 1 commit into from
Oct 29, 2021
Merged

{Packaging} Bump PyGithub #20041

merged 1 commit into from
Oct 29, 2021

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Oct 26, 2021

Description

Fix Homebrew/homebrew-core#86758 (comment)

The old PyGithub 1.33 fails to install with the latest setuptools:

https://github.com/Homebrew/homebrew-core/runs/3822014268?check_suite_focus=true#step:7:477

error in PyGithub setup command: use_2to3 is invalid.

This can also be reproduced locally:

> pip install PyGithub==1.38 --force-reinstall --no-cache
Collecting PyGithub==1.38
  Downloading PyGithub-1.38.tar.gz (2.6 MB)
     |████████████████████████████████| 2.6 MB 939 kB/s
  Preparing metadata (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: 'D:\cli\py310\Scripts\python.exe' -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\jiasli\\AppData\\Local\\Temp\\pip-install-ucdnpr32\\pygithub_0d915833b57340d9ba94217798ac9ac0\\setup.py'"'"'; __file__='"'"'C:\\Users\\jiasli\\AppData\\Local\\Temp\\pip-install-ucdnpr32\\pygithub_0d915833b57340d9ba94217798ac9ac0\\setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\jiasli\AppData\Local\Temp\pip-pip-egg-info-ldrl09zy'
       cwd: C:\Users\jiasli\AppData\Local\Temp\pip-install-ucdnpr32\pygithub_0d915833b57340d9ba94217798ac9ac0\
  Complete output (1 lines):
  error in PyGithub setup command: use_2to3 is invalid.

This issue is similar to #19468 (fixed by #19495)

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 26, 2021

Packaging

Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiasli jiasli merged commit 79baeeb into Azure:dev Oct 29, 2021
@jiasli jiasli deleted the pygithub branch October 29, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants