Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Bump setuptools from 52.0.0 to 65.5.1 #24992

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 28, 2022

Bumps setuptools from 52.0.0 to 65.5.1.

Release notes

Sourced from setuptools's releases.

v65.5.1

No release notes provided.

v65.5.0

No release notes provided.

v65.4.1

No release notes provided.

v65.4.0

No release notes provided.

v65.3.0

No release notes provided.

v65.2.0

No release notes provided.

v65.1.1

No release notes provided.

v65.1.0

No release notes provided.

v65.0.2

No release notes provided.

v65.0.1

No release notes provided.

v65.0.0

No release notes provided.

v64.0.3

No release notes provided.

v64.0.2

No release notes provided.

v64.0.1

No release notes provided.

v64.0.0

No release notes provided.

v63.4.3

No release notes provided.

v63.4.2

No release notes provided.

... (truncated)

Changelog

Sourced from setuptools's changelog.

v65.5.1

Misc ^^^^

  • #3638: Drop a test dependency on the mock package, always use :external+python:py:mod:unittest.mock -- by :user:hroncok
  • #3659: Fixed REDoS vector in package_index.

v65.5.0

Changes ^^^^^^^

  • #3624: Fixed editable install for multi-module/no-package src-layout projects.
  • #3626: Minor refactorings to support distutils using stdlib logging module.

Documentation changes ^^^^^^^^^^^^^^^^^^^^^

  • #3419: Updated the example version numbers to be compliant with PEP-440 on the "Specifying Your Project’s Version" page of the user guide.

Misc ^^^^

  • #3569: Improved information about conflicting entries in the current working directory and editable install (in documentation and as an informational warning).
  • #3576: Updated version of validate_pyproject.

v65.4.1

Misc ^^^^

v65.4.0

Changes ^^^^^^^

v65.3.0

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Dec 28, 2022
@ghost
Copy link

ghost commented Dec 28, 2022

Thank you for your contribution dependabot[bot]! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yonzhan December 28, 2022 04:05
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 28, 2022
@ghost ghost requested a review from wangzelin007 December 28, 2022 04:05
@ghost ghost assigned jiasli Dec 28, 2022
@ghost ghost added the Installation label Dec 28, 2022
@ghost ghost requested review from jiasli and jsntcy December 28, 2022 04:05
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 28, 2022

Bump setuptools

@yonzhan yonzhan requested a review from bebound December 28, 2022 07:53
@yonzhan yonzhan added this to the Dec 2022 (2023-01-10) milestone Dec 28, 2022
@wangzelin007 wangzelin007 changed the title Bump setuptools from 52.0.0 to 65.5.1 {CI} Bump setuptools from 52.0.0 to 65.5.1 Jan 3, 2023
@wangzelin007
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

bebound
bebound previously approved these changes Jan 3, 2023
wangzelin007
wangzelin007 previously approved these changes Jan 4, 2023
@jiasli
Copy link
Member

jiasli commented Jan 4, 2023

The new setuptools 65.6.3 behaves differently as the old 52.0.0, causing issue #24982. Let's defer this PR to next sprint until it is fully tested.

@dependabot dependabot bot dismissed stale reviews from wangzelin007 and bebound via 120a100 January 6, 2023 04:16
@dependabot dependabot bot force-pushed the dependabot/pip/setuptools-65.5.1 branch 2 times, most recently from 120a100 to 6e2fb39 Compare January 11, 2023 05:41
Bumps [setuptools](https://github.com/pypa/setuptools) from 52.0.0 to 65.5.1.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst)
- [Commits](pypa/setuptools@v52.0.0...v65.5.1)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/setuptools-65.5.1 branch from 6e2fb39 to b4a242c Compare February 3, 2023 04:27
@yonzhan yonzhan removed this from the Jan 2023 (2023-02-07) milestone Feb 3, 2023
@yonzhan yonzhan added this to the Feb 2023 (2023-03-07) milestone Feb 3, 2023
@jiasli jiasli assigned bebound and unassigned jiasli and wangzelin007 Feb 3, 2023
@jiasli
Copy link
Member

jiasli commented Feb 7, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bebound bebound merged commit 91916cd into dev Feb 7, 2023
@dependabot dependabot bot deleted the dependabot/pip/setuptools-65.5.1 branch February 7, 2023 08:03
@@ -1,3 +1,3 @@
# basic
setuptools==52.0.0
setuptools==65.5.1
Copy link
Member

@jiasli jiasli Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest setuptools is already 67.2.0: https://pypi.org/project/setuptools/

We are already using the latest pip. Maybe we should unpin setuptools altogether. Azure CLI's Windows MSI package always use the latest setuptools.

> & "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe" -m pip list
Package                Version
---------------------- ---------
...
setuptools             67.1.0

However, setuptools is released too frequently, so it may introduce breaking changes at any point.

Copy link
Contributor

@bebound bebound Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to unpin it.
Linux packages and homebrew do not use this file either.

/opt/az/bin/python3 -Im pip list | grep setup
setuptools                              63.2.0
/opt/homebrew/Cellar/azure-cli/2.44.0/libexec/bin/python -Im pip list | grep setup
setuptools                              65.6.3

Copy link
Contributor

@bebound bebound Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another issue caused by old setuptools version. #25682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. do-not-merge External Dependency Installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants