Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{CI} Bump setuptools from 52.0.0 to 65.5.1 #24992

Merged
merged 1 commit into from
Feb 7, 2023
Merged

{CI} Bump setuptools from 52.0.0 to 65.5.1 #24992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# basic
setuptools==52.0.0
setuptools==65.5.1
Copy link
Member

@jiasli jiasli Feb 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest setuptools is already 67.2.0: https://pypi.org/project/setuptools/

We are already using the latest pip. Maybe we should unpin setuptools altogether. Azure CLI's Windows MSI package always use the latest setuptools.

> & "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe" -m pip list
Package                Version
---------------------- ---------
...
setuptools             67.1.0

However, setuptools is released too frequently, so it may introduce breaking changes at any point.

Copy link
Contributor

@bebound bebound Feb 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to unpin it.
Linux packages and homebrew do not use this file either.

/opt/az/bin/python3 -Im pip list | grep setup
setuptools                              63.2.0

/opt/homebrew/Cellar/azure-cli/2.44.0/libexec/bin/python -Im pip list | grep setup
setuptools                              65.6.3

Copy link
Contributor

@bebound bebound Mar 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another issue caused by old setuptools version. #25682

pip>=9.0.1