{Packaging} Use deb822 format in DEB installation script #28250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
konstruktoid
requested review from
kairu-ms,
jiasli,
wangzelin007,
calvinhzy and
bebound
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @konstruktoid, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
konstruktoid
changed the title
|
/retest |
bebound
reviewed
Feb 19, 2024
bebound
reviewed
Feb 19, 2024
bebound
changed the title
bebound
reviewed
Feb 19, 2024
|
This is the script I used for testing: |
Co-authored-by: Hang <bebound@gmail.com>
Co-authored-by: Hang <bebound@gmail.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
|
#28250 (comment) #!/bin/bash
CLI_VERSION="2.57.0"
set -euo pipefail
# use deb_install.sh in current directry
images=("ubuntu:18.04" "ubuntu:20.04" "ubuntu:22.04" "debian:10" "debian:11" "debian:12")
for image in "${images[@]}"; do
echo "Testing ${image}"
docker run -v "$(pwd)/deb_install.sh:/deb_install.sh" --rm "${image}" bash -c "bash /deb_install.sh"
if ! az version | grep "\"azure-cli\": \"${CLI_VERSION}\""; then
echo "Test failed in ${image}"
exit 1
fi
done |
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
I don't have a preference regarding adding it to the repo. @jiasli, what's your opinion? PS: deb822 is supported by apt since version 1.1, making it compatible with Ubuntu 16.04, Debian 9 and later. |
|
Yeah, it was more of a concept, if it was worth spending time on. |
bebound
reviewed
Apr 16, 2024
bebound
reviewed
Apr 16, 2024
bebound
modified the milestones:
April 2024 (2024-04-30),
May 2024 (2024-05-21)❗ Breaking change release ❗
jiasli
reviewed
May 7, 2024
jiasli
reviewed
May 7, 2024
jiasli
reviewed
May 7, 2024
| @@ -42,12 +42,15 @@ setup() { | |||
| set -v | |||
| export DEBIAN_FRONTEND=noninteractive | |||
| apt-get update | |||
| apt-get install -y apt-transport-https lsb-release gnupg curl | |||
| apt-get install --assume-yes --no-install-recommends apt-transport-https ca-certificates curl gnupg lsb-release | |||
There was a problem hiding this comment.
It's specified in https://github.com/konstruktoid/azure-docs-cli/blob/main/docs-ref-conceptual/includes/cli-install-linux-apt.md#option-2-step-by-step-installation-instructions, and (needed or not) most often included in installation scripts just-in-case, just as gnupg and curl that tends to be installed by default as well.
jiasli
requested changes
May 7, 2024
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
jiasli
approved these changes
May 8, 2024
bebound
approved these changes
May 8, 2024
jiasli
reviewed
May 20, 2024
jiasli
reviewed
Jul 15, 2024
| Suites: ${CLI_REPO} | ||
| Components: main | ||
| Architectures: $(dpkg --print-architecture) | ||
| Signed-by: /etc/apt/keyrings/microsoft.gpg" | tee /etc/apt/sources.list.d/azure-cli.sources |
There was a problem hiding this comment.
This /etc/apt/sources.list.d/azure-cli.list -> /etc/apt/sources.list.d/azure-cli.sources renaming breaks the logic of check_distro_consistency from #5755:
azure-cli/src/azure-cli-core/azure/cli/core/extension/operations.py
Lines 564 to 591 in b6ab754
and result in error in debug log:
cli.azure.cli.core.extension.operations: [Errno 2] No such file or directory: '/etc/apt/sources.list.d/azure-cli.list'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.