Add a check for linux version consistency

[yorek]

Followin up #5747

[promptws]

View a preview at https://prompt.ws/r/Azure/azure-cli/5755
This is an experimental preview for @microsoft users.

[yorek]

saw that the build was failing on whitespace rules, fixed it, and already pushed the changes

[derekbekoe]

Everything is good except for this:

************* Module azure.cli.command_modules.extension.custom
C:285, 0: Line too long (132/120) (line-too-long)
C:288, 0: Unnecessary parens after 'if' keyword (superfluous-parens)
C:290, 0: Line too long (159/120) (line-too-long)
C:291, 0: Line too long (150/120) (line-too-long)
W:282,15: Catching too general exception Exception (broad-except)
W:279,42: Using deprecated method linux_distribution() (deprecated-method)

[derekbekoe]

For W:282,15: Catching too general exception Exception (broad-except), you can add # pylint: disable=line-too-long

Also, you can run pylint locally with azdev style --ci --module extension instead of having to wait for CI.

[yorek]

changed code to comply with pyling rules. Had to get rid of deprecated function.

[derekbekoe]

In the last call to logger.warning, can you add current_linux_dist_name.strip()?

I just tried it and I see this.

az extension add -n webapp 
Linux distro check: Mismatch distribution name in /etc/apt/sources.list.d/azure-cli.list file
Linux distro check: If command fails, install the appropriate package for your distribution or change the above file accordingly.
Linux distro check: /etc/apt/sources.list.d/azure-cli.list has 'wheezy', current distro is 'xenial
'
An error occurred. Pip failed with status code 1. Use --debug for more information.

As you can see, the last ' ends up on a new line.

[derekbekoe]

Same with Linux distro check: Reported by API: ... message.
So might be best to do return rel.strip() in get_lsb_release.

[derekbekoe]

I verified that return rel.strip() would resolve the issue.

[derekbekoe]

Thanks for the contribution @yorek

[yorek]

You're welcome :)