[dla] az dla: Deprecate azure datalake analytics from CLI
#29879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
dla |
microsoft-github-policy-service
bot
requested review from
yonzhan and
jsntcy
jiasli
reviewed
Sep 10, 2024
| @@ -187,5 +187,5 @@ def load_command_table(self, _): | |||
| g.show_command('show', 'get') | |||
| g.command('delete', 'delete') | |||
|
|
|||
| with self.command_group('dla', is_preview=True): | |||
| with self.command_group('dla', deprecate_info=self.deprecate(expiration='2.67.0')): | |||
There was a problem hiding this comment.
Be aware that declaring expiration in deprecate_info will break the release pipeline if it is forgotten: #27792.
There was a problem hiding this comment.
It's by design because I won't want to miss next breaking change window.
And as you may noticed, I didn't leverage the upcoming breaking change framework
azure-cli/src/azure-cli-core/azure/cli/core/breaking_change.py
Lines 584 to 586 in b3199bd
And @ReaNAiveD said that I will lose version info if I use default old deprecated_info rather than register_command_group_deprecate. That's another reason I explicitly declare expiration here
jiasli
approved these changes
Sep 11, 2024
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az dlaDescription
Azure Data Lake analytics has been retired as of Feb 29, 2024: migrate-to-azure-synapse-analytics
This PR is for deprecate it from CLI
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.