Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dla] az dla: Deprecate azure datalake analytics from CLI #29879

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[dla] az dla: Deprecate azure datalake analytics from CLI #29879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/dla/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,5 +187,5 @@ def load_command_table(self, _):
g.show_command('show', 'get')
g.command('delete', 'delete')

with self.command_group('dla', is_preview=True):
with self.command_group('dla', deprecate_info=self.deprecate(expiration='2.67.0')):
Copy link
Member

@jiasli jiasli Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware that declaring expiration in deprecate_info will break the release pipeline if it is forgotten: #27792.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's by design because I won't want to miss next breaking change window.

And as you may noticed, I didn't leverage the upcoming breaking change framework

azure-cli/src/azure-cli-core/azure/cli/core/breaking_change.py

Lines 584 to 586 in b3199bd

def register_command_group_deprecate(command_group, redirect=None, hide=None,
target_version=NextBreakingChangeWindow(), **kwargs):
register_deprecate_info(command_group, redirect=redirect, hide=hide, target_version=target_version, **kwargs)

And @ReaNAiveD said that I will lose version info if I use default old deprecated_info rather than register_command_group_deprecate. That's another reason I explicitly declare expiration here

pass