[App Service] az functionapp create: Add --zone-redundant parameter to support zone redundant for Functions Flex SKU
#29984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khkh-ms
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| functionapp create | cmd functionapp create added parameter zone_redundant |
||
| functionapp list-flexconsumption-locations | cmd functionapp list-flexconsumption-locations added parameter zone_redundant |
khkh-ms
changed the title
az functionapp create: Adding zone redundant support for Functions Flex SKU. az functionapp create: Adding zone redundant support for Functions Flex SKU.
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
khkh-ms
changed the title
az functionapp create: Adding zone redundant support for Functions Flex SKU. az functionapp create: Add zone redundant support for Functions Flex SKU.
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29984 in repo Azure/azure-cli |
khkh-ms
changed the title
az functionapp create: Add zone redundant support for Functions Flex SKU. az functionapp create: Add zone redundant support for Functions Flex SKU.
khkh-ms
changed the title
az functionapp create: Add zone redundant support for Functions Flex SKU.az functionapp create: Add zone redundant support for Functions Flex SKU
sidkri
reviewed
Oct 4, 2024
| if flexconsumption_location is None: | ||
| if zone_redundant: | ||
| raise ArgumentUsageError( | ||
| '--zone-redundant is only valid input for Azure Functions on the Flex Consumption plan. ' |
There was a problem hiding this comment.
nit: I would reword as "is only valid for the Flex Consumption plan. ' (at least remove the word "input")
as the command this was specified on was already Functions specific right?
There was a problem hiding this comment.
You are right. I will change the wording. Thanks!
sidkri
reviewed
Oct 4, 2024
| @@ -822,6 +826,8 @@ def load_arguments(self, _): | |||
| c.argument('deployment_storage_auth_value', options_list=['--deployment-storage-auth-value', '--dsav'], help="The deployment storage account authentication value. For the user-assigned managed identity authentication type, " | |||
| "this should be the user assigned identity resource id. For the storage account connection string authentication type, this should be the name of the app setting that will contain the storage account connection " | |||
| "string. For the system assigned managed-identity authentication type, this parameter is not applicable and should be left empty.", is_preview=True) | |||
| c.argument('zone_redundant', arg_type=get_three_state_flag(), | |||
| help='Enable zone redundancy for high availability. Applies to Flex Consumption only.', is_preview=True) | |||
There was a problem hiding this comment.
"Applies to Flex Consumption SKU only."
sidkri
approved these changes
Oct 9, 2024
| @@ -822,6 +826,8 @@ def load_arguments(self, _): | |||
| c.argument('deployment_storage_auth_value', options_list=['--deployment-storage-auth-value', '--dsav'], help="The deployment storage account authentication value. For the user-assigned managed identity authentication type, " | |||
| "this should be the user assigned identity resource id. For the storage account connection string authentication type, this should be the name of the app setting that will contain the storage account connection " | |||
| "string. For the system assigned managed-identity authentication type, this parameter is not applicable and should be left empty.", is_preview=True) | |||
| c.argument('zone_redundant', arg_type=get_three_state_flag(), | |||
| help='Enable zone redundancy for high availability. Applies to Flex Consumption only.', is_preview=True) | |||
There was a problem hiding this comment.
Let's check if we want to mark this as preview
There was a problem hiding this comment.
Everything related is flex is in preview mode. When we will remove the preview parameters from all Flex related flags, the preview from --zone_redundant will be removed at that time.
| zone_redundant_location = next((loc for loc in zone_redundant_locations | ||
| if loc['name'].lower() == flexconsumption_location.lower()), None) | ||
| if zone_redundant_location is None: | ||
| raise ValidationError("Location doesn't support zone redundancy in Flex Consumption. " |
There was a problem hiding this comment.
nit: "The specified location "USER_SPECIFIED_LOCATION" doesn't support...."
| @@ -4752,6 +4756,13 @@ def is_exactly_one_true(*args): | |||
| return found | |||
|
|
|||
|
|
|||
| def list_flexconsumption_zone_redundant_locations(cmd): | |||
| client = web_client_factory(cmd.cli_ctx) | |||
| regions = client.list_geo_regions(sku="FlexConsumption") | |||
There was a problem hiding this comment.
What happens when this API call fails? Does the operation fail or the method return no locations?
There was a problem hiding this comment.
API errors are surfaced to users in cli. The user will be able to see the actual error message from the backend. User can use --debug flag for further details for the API requests/responses.
sidkri
approved these changes
Oct 10, 2024
|
please add test for the newly added parameter to verify if it can meet your expectations. |
yanzhudd
changed the title
az functionapp create: Add zone redundant support for Functions Flex SKUaz functionapp create: Add --zone-redundant parameter to support zone redundant for Functions Flex SKU
|
Added the tests. |
|
Please fix CI issues |
|
All the recent PRs are failing because the same failure. Please check and fix the pipeline if possible. It is not related to the PR. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp create
Description
Adding the support of --zone-redundant flag in
az functionapp createfor Flex SKU.Testing Guide
az functionapp create -g [rg] -n [name] -s [storage-account-name] --functions-version 4 --runtime python --runtime-version 3.11 --flexconsumption-location eastasia --zone-redundant
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.